admin-template-configure-settings

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts

    • -0
    • +3
    ./admin-template-configure-settings.controller.spec.js
    • -1
    • +1
    ./template-facility-type.factory.spec.js
  1. … 29 more files in changeset.
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

    • -7
    • +15
    ./admin-template-configure-settings.controller.spec.js
    • -1
    • +2
    ./template-facility-type.factory.spec.js
  1. … 57 more files in changeset.
If you are not sure about your changes it means that: (1) you don't trust our tests, (2) those tests are written incorrectly or (3) we don't have tests for them. I hope in this case we talk about 1...

If you are not sure about your changes it means that: (1) you don't trust our tests, (2) those tests are written incorrectly or (3) we don't have tests for them. I hope in this case we talk about 1st option

LGTM

LGTM

Double check this file, please. There were some changes that weren't merely indentation changes.

Double check this file, please. There were some changes that weren't merely indentation changes.

OLMIS-4833: ESlint tech debt fixes - part 1
OLMIS-4833: ESlint tech debt fixes - part 1
OLMIS-4833: ESlint tech debt fixes - part 1

    • -16
    • +24
    ./admin-template-configure-settings.controller.js
    • -18
    • +20
    ./admin-template-configure-settings.routes.js
  1. … 14 more files in changeset.
probably the same situation as in FEOLMIS-2817

probably the same situation as in FEOLMIS-2817

OLMIS-4548: Fixed displaying newly added facility types
OLMIS-4548: Fixed displaying newly added facility types
OLMIS-4548: Fixed displaying newly added facility types

  1. … 1 more file in changeset.
Fair enough.

Fair enough.

Yeah but we can still have it in the controller. To be honest, we should use v7 architecture here and just let the FacilityType class object decide which endpoint should it call.

Yeah but we can still have it in the controller. To be honest, we should use v7 architecture here and just let the FacilityType class object decide which endpoint should it call.

which save method? you told me to split save method in facility type service into two separate for create and update

which save method? you told me to split save method in facility type service into two separate for create and update

We don't this is just default sort order that we have to pass from UI

We don't this is just default sort order that we have to pass from UI

Do we have any other sort options for this screen? If so, could we extract them to a constant?

Do we have any other sort options for this screen? If so, could we extract them to a constant?