openlmis-requisition-ui/src/admin-template-configure-columns

template.html

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 25 Sep 18
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 25 Sep 2018
3:20 pm

Adugna Worku

1:43 pm

Elias , Mateusz Kwiatkowski and Łukasz Lewczyński

6:55 am

Adugna Worku

OLMIS-4968 - make packsToShip Rnr column to be visible on approval page or on all pages based on the new admin template option
OLMIS-4968 - make packsToShip Rnr column to be visible on approval page or on all pages based on the new admin template option
6:29 am

Adugna Worku

OLMIS-4968 Make packsToShip column to be seen only on Rnr approval screen or on all Rnr screens bases on admin template configuration

Options
    • -2
    • +2
    ./template.html
  2. … 5 more files in changeset.
Friday 14 Sep 2018
10:01 am

Mateusz Kwiatkowski

9:45 am

Klaudia Pałkowska and Nikodem Graczewski

9:02 am

Mateusz Kwiatkowski

OLMIS-5395: enabled max stock quantity and calculated order quantity columns
OLMIS-5395: enabled max stock quantity and calculated order quantity columns
8:32 am

Mateusz Kwiatkowski

OLMIS-5395: enabled max stock quantity and calc order quantity columns

Options
    • -4
    • +4
    ./template.html
  2. … 11 more files in changeset.
Tuesday 29 May 2018
4:04 pm

Elias

2:31 pm

Nikodem Graczewski

Great, you're most welcome! https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Great, you're most welcome!

2:04 pm

Elias

Ah, Yes. It was mostly an endless loading screen or a white screen. loading it on https:// seems to have fixed the issue. Thanks again.

Ah, Yes. It was mostly an endless loading screen or a white screen. loading it on https:// seems to have fixed the issue. Thanks again.

2:01 pm

Elias

Thanks Nikodem Graczewski

Thanks Nikodem Graczewski

1:45 pm

Nikodem Graczewski and Łukasz Lewczyński

1:45 pm

Nikodem Graczewski

Elias What kind of error were you encountering by the way? If it was and endless loading perhaps you're using http protocol instead of https when connecting to the Fisheye?

Elias What kind of error were you encountering by the way? If it was and endless loading perhaps you're using http protocol instead of https when connecting to the Fisheye?

1:39 pm

Nikodem Graczewski

I've added the related commits so we have everything in the same place https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

I've added the related commits so we have everything in the same place

1:36 pm

Łukasz Lewczyński

LGFM

LGFM

1:28 pm

Elias

Done. Added changelog entries on both requisition and requisition UI repositories. https://github.com/OpenLMIS/openlmis-requisition-ui/commit/fa908e94f991a18da22c1ec916b38ff5cfe47ca0 https://githu...

Done. Added changelog entries on both requisition and requisition UI repositories.

https://github.com/OpenLMIS/openlmis-requisition-ui/commit/fa908e94f991a18da22c1ec916b38ff5cfe47ca0
https://github.com/OpenLMIS/openlmis-requisition/commit/db0da9b8acb5f9c80b119ecb1c4abed22ef21c8c

7:19 am

Łukasz Lewczyński

Looks good but I don't see entries in changelogs

Looks good but I don't see entries in changelogs

Monday 28 May 2018
7:59 pm

Elias

Thanks for pointing me to the message filter. I have removed the translateLabel method and used the "message" filter as recommended. Adding a change set to the review has been giving me an error. T...

Thanks for pointing me to the message filter. I have removed the translateLabel method and used the "message" filter as recommended.
Adding a change set to the review has been giving me an error. The change that I committed for resolving these issues is here.
https://github.com/OpenLMIS/openlmis-requisition-ui/commit/4d7d0fd3770a1cb528524b2cc6f637b771d2ea36

7:56 pm

Elias

done. https://github.com/OpenLMIS/openlmis-requisition-ui/commit/4d7d0fd3770a1cb528524b2cc6f637b771d2ea36

done. https://github.com/OpenLMIS/openlmis-requisition-ui/commit/4d7d0fd3770a1cb528524b2cc6f637b771d2ea36

4:47 pm

Elias

OLMIS-4792: use the existing message filter, remove translateLabel method.

Options
    • -2
    • +2
    ./template.html
  2. … 1 more file in changeset.
4:16 pm

Elias

Thanks for the feedback Lukasz. is there any example in the requisition UI for using the "| message" filter within ng-options?

Thanks for the feedback Lukasz. is there any example in the requisition UI for using the "| message" filter within ng-options?

7:11 am

Nikodem Graczewski

Yeah, it should use the message filter here.

Yeah, it should use the message filter here.

5:01 am

Łukasz Lewczyński

On the UI we could use the optionName column like: <p>{{ 'requisitionConstants.' + column.option.optionName | message}}</p>

On the UI we could use the optionName column like:

<p>{{ 'requisitionConstants.' + column.option.optionName | message}}</p>
5:00 am

Łukasz Lewczyński

same here

same here

5:00 am

Łukasz Lewczyński

Nikodem Graczewski please, let me know if my code is incorrect <div \[...\]>{{column.option.optionLabel | message}}</div>

Nikodem Graczewski please, let me know if my code is incorrect 

<div \[...\]>{{column.option.optionLabel | message}}</div>
4:58 am

Łukasz Lewczyński

I think this method is not needed

I think this method is not needed

4:58 am

Łukasz Lewczyński

I am not sure if those changes are required. Also maybe we could remove the optionLabel column (cc: Chongsun Ahn) because from the service perspective the column is redundant. Even if we decide to ...

I am not sure if those changes are required. Also maybe we could remove the optionLabel column (cc: Chongsun Ahn) because from the service perspective the column is redundant. Even if we decide to do this it should be done in separate ticket

4:56 am

Łukasz Lewczyński

Friday 25 May 2018
1:58 pm

Elias

OLMIS-4792: Make dropdown in additional options column of requisition template translatable.
OLMIS-4792: Make dropdown in additional options column of requisition template translatable.