Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-4968 - make packsToShip Rnr column to be visible on approval page or on all pages based on the new admin template option
OLMIS-4968 - make packsToShip Rnr column to be visible on approval page or on all pages based on the new admin template option
OLMIS-4968 Make packsToShip column to be seen only on Rnr approval screen or on all Rnr screens bases on admin template configuration

  1. … 5 more files in changeset.
OLMIS-5395: enabled max stock quantity and calculated order quantity columns
OLMIS-5395: enabled max stock quantity and calculated order quantity columns
OLMIS-5395: enabled max stock quantity and calc order quantity columns

  1. … 11 more files in changeset.
Great, you're most welcome! https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Great, you're most welcome!

Ah, Yes. It was mostly an endless loading screen or a white screen. loading it on https:// seems to have fixed the issue. Thanks again.

Ah, Yes. It was mostly an endless loading screen or a white screen. loading it on https:// seems to have fixed the issue. Thanks again.

Thanks Nikodem Graczewski
Elias What kind of error were you encountering by the way? If it was and endless loading perhaps you're using http protocol instead of https when connecting to the Fisheye?

Elias What kind of error were you encountering by the way? If it was and endless loading perhaps you're using http protocol instead of https when connecting to the Fisheye?

I've added the related commits so we have everything in the same place https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

I've added the related commits so we have everything in the same place

LGFM

LGFM

Done. Added changelog entries on both requisition and requisition UI repositories. https://github.com/OpenLMIS/openlmis-requisition-ui/commit/fa908e94f991a18da22c1ec916b38ff5cfe47ca0 https://githu...
Looks good but I don't see entries in changelogs

Looks good but I don't see entries in changelogs

Thanks for pointing me to the message filter. I have removed the translateLabel method and used the "message" filter as recommended. Adding a change set to the review has been giving me an error. T...

Thanks for pointing me to the message filter. I have removed the translateLabel method and used the "message" filter as recommended.
Adding a change set to the review has been giving me an error. The change that I committed for resolving these issues is here.
https://github.com/OpenLMIS/openlmis-requisition-ui/commit/4d7d0fd3770a1cb528524b2cc6f637b771d2ea36

done. https://github.com/OpenLMIS/openlmis-requisition-ui/commit/4d7d0fd3770a1cb528524b2cc6f637b771d2ea36
OLMIS-4792: use the existing message filter, remove translateLabel method.

  1. … 1 more file in changeset.
Thanks for the feedback Lukasz. is there any example in the requisition UI for using the "| message" filter within ng-options?

Thanks for the feedback Lukasz. is there any example in the requisition UI for using the "| message" filter within ng-options?

Yeah, it should use the message filter here.

Yeah, it should use the message filter here.

On the UI we could use the optionName column like: <p>{{ 'requisitionConstants.' + column.option.optionName | message}}</p>

On the UI we could use the optionName column like:

<p>{{ 'requisitionConstants.' + column.option.optionName | message}}</p>
same here

same here

Nikodem Graczewski please, let me know if my code is incorrect <div \[...\]>{{column.option.optionLabel | message}}</div>

Nikodem Graczewski please, let me know if my code is incorrect

<div \[...\]>{{column.option.optionLabel | message}}</div>
I think this method is not needed

I think this method is not needed

I am not sure if those changes are required. Also maybe we could remove the optionLabel column (cc: Chongsun Ahn) because from the service perspective the column is redundant. Even if we decide to ...

I am not sure if those changes are required. Also maybe we could remove the optionLabel column (cc: Chongsun Ahn) because from the service perspective the column is redundant. Even if we decide to do this it should be done in separate ticket

OLMIS-4792: Make dropdown in additional options column of requisition template translatable.
OLMIS-4792: Make dropdown in additional options column of requisition template translatable.