openlmis-requisition

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
All right. Did something in that manner. Thanks https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

All right. Did something in that manner. Thanks

OLMIS-6671: Introduced an additional method for better readibility

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that https://review...

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one...

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one thing I think). Could not extract it all into a separate method as Sonar wasn't allowing this.

OLMIS-6671: Refactored the method in attempt to fix Sonar errors

OLMIS-6671: Refactored methods

To improve readability we could: 1. merge this with an already existing if-statement 2. Extract this check to a separate private method

To improve readability we could:
1. merge this with an already existing if-statement
2. Extract this check to a separate private method

OLMIS-6671: Refactoring for string literals to be on the left side of string comparisions
OLMIS-6671: Refactoring for string literals to be on the left side of string comparisions
OLMIS-6671: Refactoring for string literals to be on the left side of string comparisions

OLMIS-6671: Changed method to fix batch approval error when a template column is hidden

OLMIS-6118: Turned off three not passing tests scenarios for batch approval
OLMIS-6118: Turned off three not passing tests scenarios for batch approval
OLMIS-6118: Turned off three not passing tests scenarios for batch approval

    • -210
    • +210
    /performance/tests/requisitionBatchApproval.yml
6118: Turned off batch requisition performance tests in a step towards fixing them

    • -213
    • +213
    /performance/tests/requisitionBatchApproval.yml
Revert "OLMIS-6118: Restoring data in an attempt to fix performance tests"

This reverts commit 74ab45900f997db6768ce71a1565eff1c3a1473e.

OLMIS-6118: Restoring data in an attempt to fix performance tests

OLMIS-6118: Fixed typos

    • -1
    • +1
    /performance/tests/requisitionBatchApproval.yml
Bumped version to 8.2.1-SNAPSHOT

Relase 8.2.0

Changed requisition service version back to SNAPSHOT

OLMIS-6623: Release requisition service 8.2.0-RC2

OLMIS-6620: Set lazy flag for available_products (#51)

OLMIS-6620: Set lazy flag for available_products

OLMIS-6609 Added missing profiler and updated changelog

This loop could use its own profiler, especially that it removes from a collection

This loop could use its own profiler, especially that it removes from a collection

OLMIS-6609 Removed redundant calls to database and simplified getting periods

1. This is making calls to the database in a loop. 2. This still seems to be over-complicated. There are only 2 steps required for regular requisitions - a) take all periods b) remove periods that ...

1. This is making calls to the database in a loop.
2. This still seems to be over-complicated.
There are only 2 steps required for regular requisitions - a) take all periods b) remove periods that have authorized+ requisition
Whatever is left after removing requisitions from step b) is our resulting list