openlmis-report-ui

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5500: Removed redundant style

    • -1
    • +0
    /src/reporting-test/reporting-test.scss
Remove this.

Remove this.

OLMIS-5500: Made iframe flex up to the full screen
OLMIS-5500: Made iframe flex up to the full screen
OLMIS-5500: Made iframe flex up to the full screen

    • -4
    • +1
    /src/reporting-test/reporting-test.html
    • -7
    • +3
    /src/reporting-test/reporting-test.scss
I didn't get a decision on it yet.

I didn't get a decision on it yet.

Update yarn.lock

OLMIS-5500: Moved Superset iFrame source to a constant

    • -0
    • +52
    /src/reporting-test/reporting-test.controller.spec.js
    • -1
    • +1
    /src/reporting-test/reporting-test.html
    • -0
    • +36
    /src/reporting-test/superset-iframe-source.constant.js
I was thinking you were going to use feature flag here?

I was thinking you were going to use feature flag here?

I think this src value should be taken from some variable in controller or from some service or maybe constant?

I think this src value should be taken from some variable in controller or from some service or maybe constant?

What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. T...

What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. The change we're introducing here is locking dev-ui dependencies, which are no longer fetched to the node_modules in the root directory, but instead, are fetched into node_modules/dev-ui/node_modules. What we're doing is moving them to the node_modules directory so they are available to the module that is relying on dev-ui, lack of them there would break the build process because of missing dependencies. For yarn.lock we're basically copying the one generated in the .tmp directory, which is where we're firing yarn up during the build process. If you have any concern, please let me know.

Added Reporting (Test) page
Added Reporting (Test) page
These changes are virtually impossible to review in-depth.

These changes are virtually impossible to review in-depth.

Added Reporting (Test) page

    • -0
    • +3
    /src/reporting-test/messages_en.json
    • -0
    • +5
    /src/reporting-test/reporting-test.html
    • -0
    • +32
    /src/reporting-test/reporting-test.module.js
    • -0
    • +38
    /src/reporting-test/reporting-test.routes.js
    • -0
    • +8
    /src/reporting-test/reporting-test.scss
https://review.openlmis.org/cru/#FEOLMIS-3344CFR-46204

https://review.openlmis.org/cru/#FEOLMIS-3344CFR-46204

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46198

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46198

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46195

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46195

We don't have a changelog in the reference-ui.

We don't have a changelog in the reference-ui.

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46193

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46193

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46201

https://review.openlmis.org/cru/#FEOLMIS-3341CFR-46201

It is.

It is.

I've just moved it, it was already reviewed.

I've just moved it, it was already reviewed.

is this changed in changelog?

is this changed in changelog?