openlmis-referencedata

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-1242 FEOLMIS-496 Update calculation logic in OrderableProduct

OLMIS-1162 Enforce required parameters to be not null in constructors

Constructors in RequisitionGroup, RequisitionGroupProgramSchedule and ProcessingSchedule should check parameters are not null. Disable integration tests that fail when these checks are enabled (bug ticket needs to be opened to fix code for those tests).

OLMIS-1162 Rename test methods in UserControllerIntegrationTest

Make them more clear on what they are testing.

Use ResultDto<Integer> instead of IntegerResultDto

Avoid anti-pattern of having a result DTO for each JSON value.

OLMIS-1244 API for configuring Price Per Pack (T), fix serializer and demo-data

    • -12
    • +11
    /demo-data/referencedata.program_products.json
OLMIS-869 Added missing extend clauses

OLMIS-1265: Removed invalid setting from application.properties

OLMIS-1199 Change schema to use draft-04 in RAML

OLMIS-1239 FEOLMIS-474 FEOLMIS-474 Changes after review

OLMIS-1162 Fix bugs from code review

User not found should return 404 Not Found since the resource to look forward is specified, but right and program not found should return 400 Bad Request, since they are part of the request that cannot be processed.

Relevant discussion:

http://stackoverflow.com/questions/4781187/http-400-bad-request-for-logical-error-not-malformed-request-syntax

    • -0
    • +6
    /src/main/resources/api-definition.yaml
OLMIS-1162 Move some domain logic to more accurate parts of domain

Some logic in SupervisoryNode should be owned by RequistionGroup and some logic in User should be owned by SupervisionRoleAssignment. Update tests.

OLMIS-1162 Generify BooleanResultDto

This class will lead to an anti-pattern of DTOs for each primitive result we want to put in the response. Instead, we should parameterize it using generics. IntegerResultDto should also be removed and use this new ResultDto class.

OLMIS-1162 Have role assignment subclasses call own base constructor

Call own base constructor instead of superclass constructor. Base constructor calls superclass constructor anyways.

OLMIS-1198 Included schema for error response in RAML

    • -0
    • +1
    /src/main/resources/api-definition.yaml
OLMIS-1239 FEOLMIS-447 Add dispensing unit/unit to OrderableProduct

OLMIS-976: Make processResources finalized by ramlToSwagger

Per the review comments, I'm making the processResources task

tied to the ramlToSwagger task, not the jar task.

OLMIS-1198 Processing Schedule search endpoint adjustments

    • -14
    • +8
    /src/main/resources/api-definition.yaml
    • -0
    • +31
    /src/main/resources/schemas/processingSchedule.json
OLMIS-1265: Configured hibernate connection

Fixed problem with relation between roles and rights in demo data

    • -0
    • +6
    /demo-data/referencedata.role_assignments.json
    • -0
    • +34
    /demo-data/referencedata.role_rights.json
    • -17
    • +7
    /demo-data/referencedata.roles.json
OLMIS-1206: Added requisition rights

    • -0
    • +25
    /demo-data/referencedata.rights.json
OLMIS-1162 Fix build errors

OLMIS-1162 Update get supervised facilities endpoint to get by right and program

A user is mapped to supervised facilities by right and program.

Add a new validateId helper method to validate UUIDs. Add unit tests in the user object. Remove unit tests in the controller, because there is no real logic in the controller. Add new integration test for controller to handle bad request path.

    • -2
    • +16
    /src/main/resources/api-definition.yaml
OLMIS-1162 Refactor supervisory node to get supervisions by program

Check for getting supervised facilities and if a node supervises a facility is by program. Also change hasRight in SupervisionRoleAssignment to check by program.

OLMIS-1138 Changing service url var name

OLMIS-1197 Refactor RequisitionGroupProgramSchedule

This commit removes controller for RGPS, making it impossible

to edit the instances of this entity directly. Instead, they

should be created/removed via RequisitionGroups. A new endpoint

has been added to the processing schedule controller that allows

to retrieve schedules based on program and facility. Moreover a

small adjustment to RequisitionGroup controller was made to

allow saving/removing RGPS through it. RAML has been modified

accordingly.

    • -116
    • +31
    /src/main/resources/api-definition.yaml
OLMIS-1138 Fixing redirect on openlmis-blue

OLMIS-1104 Calculation login to determine number of months in period is incorrect

Returns correct value when period is longer than year

OLMIS-1104

Will return 1 month when less than 14 days

Fixed demo data rights

OLMIS-976: Swagger spec file is no longer generated under /src

* the jar gradle task now depends on the ramlToSwagger task - this is

necessary since we want the generated file to be part of the jar

* removed the generated dir and its traces

* removed redundant entries from .gitignore

    • -1
    • +0
    /src/main/resources/static/generated/.gitignore