openlmis-referencedata-ui

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
We want to make sure that both boolean true and String 'true' pass this.

We want to make sure that both boolean true and String 'true' pass this.

Revert "OLMIS-5415: Reverted changes to the facility edit screen"

This reverts commit b57c3be15a394f275b030b78528a6c00c76faeb3.

    • -0
    • +16
    /src/referencedata-facility/facility.js
Nice, can we have a simple test to verify it was fixed?

Nice, can we have a simple test to verify it was fixed?

OLMIS-5415: Reverted changes to the facility edit screen

    • -16
    • +0
    /src/referencedata-facility/facility.js
Yes it fixes the problem. Angular's $filter('filter') searches a subset of string instead of the whole string. for $filter('filter') if our search string is 'Ju' , both ''Ju' 'June' will be return...

Yes it fixes the problem. Angular's $filter('filter') searches a subset of string instead of the whole string.

for $filter('filter') if our search string is 'Ju' , both ''Ju' 'June' will be returned

But with the latest update Array.prototype.filter, only 'Ju' will be returned. The former implementation was considering 'MANAGE_ORDERABLE' and other right having 'MANAGE_ORDERABLE' as a subset as a same right.

OLMIS-4403: apply review comments

    • -2
    • +2
    /src/admin-role-form/role-form.routes.js
and why this is not a new String()?

and why this is not a new String()?

OLMIS-5415: Fixed broken JSDoc

    • -2
    • +2
    /src/referencedata-facility/facility.js
Why do we map boolean to String?

Why do we map boolean to String?

OLMIS-5415: Added JSDoc for the isManagedExternally method

    • -0
    • +10
    /src/referencedata-facility/facility.js
We're not adding JSDocs for them. They wouldn't really give us much.

We're not adding JSDocs for them. They wouldn't really give us much.

If it fixes something we should have test to cover that if possible.

If it fixes something we should have test to cover that if possible.

Is this fixing anything? I see that functionality should not change after your changes.

Is this fixing anything? I see that functionality should not change after your changes.

Should this constructor have doc?

Should this constructor have doc?

Please, use build-in array.filter instead.

Please, use build-in array.filter instead.

how about some doc?

how about some doc?

OLMIS-4403: Fix rights under role edit form to appropriatly show status
OLMIS-4403: Fix rights under role edit form to appropriatly show status
OLMIS-4403: Fix rights under role edit form to appropriatly show status

    • -2
    • +2
    /src/admin-role-form/role-form.routes.js
OLMIS-5415: Disabled edit of some fields for externally managed facilities
OLMIS-5415: Disabled edit of some fields for externally managed facilities
OLMIS-5415: Disabled edit of some fields for externally managed facilities

    • -0
    • +6
    /src/referencedata-facility/facility.js
    • -0
    • +84
    /src/referencedata-facility/facility.spec.js
What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. T...

What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. The change we're introducing here is locking dev-ui dependencies, which are no longer fetched to the node_modules in the root directory, but instead, are fetched into node_modules/dev-ui/node_modules. What we're doing is moving them to the node_modules directory so they are available to the module that is relying on dev-ui, lack of them there would break the build process because of missing dependencies. For yarn.lock we're basically copying the one generated in the .tmp directory, which is where we're firing yarn up during the build process. If you have any concern, please let me know.

These changes are virtually impossible to review in-depth.

These changes are virtually impossible to review in-depth.

https://review.openlmis.org/cru/#FEOLMIS-3344CFR-46204

https://review.openlmis.org/cru/#FEOLMIS-3344CFR-46204