openlmis-referencedata-ui

Clone Tools

Stats

Commits this week: 7
Total Committers: 34
Last Commit:
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 Oct
1:44 pm

Nikodem Graczewski

1:00 pm

Łukasz Lewczyński , Mateusz Kwiatkowski and Klaudia Pałkowska

12:48 pm

Nikodem Graczewski

We want to make sure that both boolean true and String 'true' pass this.

We want to make sure that both boolean true and String 'true' pass this.

12:31 pm

Nikodem Graczewski

Revert "OLMIS-5415: Reverted changes to the facility edit screen"

This reverts commit b57c3be15a394f275b030b78528a6c00c76faeb3.

Options
    • -0
    • +1
    /CHANGELOG.md
    • -2
    • +2
    /src/admin-facility-view/admin-facility-view.routes.js
    • -5
    • +5
    /src/admin-facility-view/facility-information.html
    • -0
    • +1
    /src/admin-facility-view/facility-view.controller.js
    • -0
    • +8
    /src/admin-facility-view/facility-view.controller.spec.js
    • -0
    • +17
    /src/referencedata-facility/facility-data-builder.spec.js
    • -0
    • +55
    /src/referencedata-facility/facility-repository.js
    • -0
    • +59
    /src/referencedata-facility/facility-repository.spec.js
    • -0
    • +44
    /src/referencedata-facility/facility-resource.js
    • -0
    • +39
    /src/referencedata-facility/facility-resource.spec.js
    • -0
    • +16
    /src/referencedata-facility/facility.js
    • -0
    • +84
    /src/referencedata-facility/facility.spec.js
10:52 am

Mateusz Kwiatkowski and Nikodem Graczewski

10:52 am

Mateusz Kwiatkowski

Nice, can we have a simple test to verify it was fixed?

Nice, can we have a simple test to verify it was fixed?

10:17 am

Nikodem Graczewski

OLMIS-5415: Reverted changes to the facility edit screen

Options
    • -1
    • +0
    /CHANGELOG.md
    • -2
    • +2
    /src/admin-facility-view/admin-facility-view.routes.js
    • -5
    • +5
    /src/admin-facility-view/facility-information.html
    • -1
    • +0
    /src/admin-facility-view/facility-view.controller.js
    • -8
    • +0
    /src/admin-facility-view/facility-view.controller.spec.js
    • -17
    • +0
    /src/referencedata-facility/facility-data-builder.spec.js
    • -55
    • +0
    /src/referencedata-facility/facility-repository.js
    • -59
    • +0
    /src/referencedata-facility/facility-repository.spec.js
    • -44
    • +0
    /src/referencedata-facility/facility-resource.js
    • -39
    • +0
    /src/referencedata-facility/facility-resource.spec.js
    • -16
    • +0
    /src/referencedata-facility/facility.js
    • -84
    • +0
    /src/referencedata-facility/facility.spec.js
10:03 am

Adugna Worku

Yes it fixes the problem. Angular's $filter('filter') searches a subset of string instead of the whole string. for $filter('filter') if our search string is 'Ju' , both ''Ju' 'June' will be return...

Yes it fixes the problem. Angular's $filter('filter') searches a subset of string instead of the whole string.

for $filter('filter') if our search string is 'Ju' , both ''Ju' 'June' will be returned

But with the latest update Array.prototype.filter, only 'Ju' will be returned. The former implementation was considering 'MANAGE_ORDERABLE' and other right having 'MANAGE_ORDERABLE' as a subset as a same right.

9:57 am

Adugna Worku

OLMIS-4403: apply review comments

Options
    • -2
    • +2
    /src/admin-role-form/role-form.routes.js
9:25 am

Mateusz Kwiatkowski

and why this is not a new String()?

and why this is not a new String()?

9:19 am

Nikodem Graczewski

OLMIS-5415: Fixed broken JSDoc

Options
    • -2
    • +2
    /src/referencedata-facility/facility.js
    • -0
    • +206
    /yarn.lock
8:36 am

Klaudia Pałkowska

Why do we map boolean to String?

Why do we map boolean to String?

Tuesday 09 Oct
1:20 pm

Nikodem Graczewski

OLMIS-5415: Added JSDoc for the isManagedExternally method

Options
    • -0
    • +10
    /src/referencedata-facility/facility.js
1:18 pm

Nikodem Graczewski

We're not adding JSDocs for them. They wouldn't really give us much.

We're not adding JSDocs for them. They wouldn't really give us much.

12:49 pm

Mateusz Kwiatkowski

If it fixes something we should have test to cover that if possible.

If it fixes something we should have test to cover that if possible.

12:48 pm

Mateusz Kwiatkowski

Is this fixing anything? I see that functionality should not change after your changes.

Is this fixing anything? I see that functionality should not change after your changes.

12:45 pm

Mateusz Kwiatkowski

Should this constructor have doc?

Should this constructor have doc?

12:42 pm

Nikodem Graczewski

Please, use build-in array.filter instead.

Please, use build-in array.filter instead.

12:40 pm

Mateusz Kwiatkowski

how about some doc?

how about some doc?

10:38 am

Adugna Worku

OLMIS-4403: Fix rights under role edit form to appropriatly show status
OLMIS-4403: Fix rights under role edit form to appropriatly show status
10:31 am

Adugna Worku

OLMIS-4403: Fix rights under role edit form to appropriatly show status

Options
    • -0
    • +3
    /CHANGELOG.md
    • -2
    • +2
    /src/admin-role-form/role-form.routes.js
9:40 am

Nikodem Graczewski

OLMIS-5415: Disabled edit of some fields for externally managed facilities
OLMIS-5415: Disabled edit of some fields for externally managed facilities
9:39 am

Nikodem Graczewski

OLMIS-5415: Disabled edit of some fields for externally managed facilities

Options
    • -0
    • +1
    /CHANGELOG.md
    • -2
    • +2
    /src/admin-facility-view/admin-facility-view.routes.js
    • -5
    • +5
    /src/admin-facility-view/facility-information.html
    • -0
    • +1
    /src/admin-facility-view/facility-view.controller.js
    • -0
    • +8
    /src/admin-facility-view/facility-view.controller.spec.js
    • -0
    • +17
    /src/referencedata-facility/facility-data-builder.spec.js
    • -0
    • +55
    /src/referencedata-facility/facility-repository.js
    • -0
    • +59
    /src/referencedata-facility/facility-repository.spec.js
    • -0
    • +44
    /src/referencedata-facility/facility-resource.js
    • -0
    • +39
    /src/referencedata-facility/facility-resource.spec.js
    • -0
    • +6
    /src/referencedata-facility/facility.js
    • -0
    • +84
    /src/referencedata-facility/facility.spec.js
Friday 05 Oct
12:53 pm

Nikodem Graczewski

Wednesday 03 Oct
5:25 am

Nikodem Graczewski

What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. T...

What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. The change we're introducing here is locking dev-ui dependencies, which are no longer fetched to the node_modules in the root directory, but instead, are fetched into node_modules/dev-ui/node_modules. What we're doing is moving them to the node_modules directory so they are available to the module that is relying on dev-ui, lack of them there would break the build process because of missing dependencies. For yarn.lock we're basically copying the one generated in the .tmp directory, which is where we're firing yarn up during the build process. If you have any concern, please let me know.

Tuesday 02 Oct
10:44 pm

Chongsun Ahn

10:44 pm

Chongsun Ahn

These changes are virtually impossible to review in-depth.

These changes are virtually impossible to review in-depth.

12:24 pm

Nikodem Graczewski

8:49 am

Mateusz Kwiatkowski and Łukasz Lewczyński

5:26 am

Nikodem Graczewski

https://review.openlmis.org/cru/#FEOLMIS-3344CFR-46204

https://review.openlmis.org/cru/#FEOLMIS-3344CFR-46204