openlmis-referencedata-ui

Clone Tools

Stats

Commits this week: 8
Total Committers: 36
Last Commit:
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Apr
3:45 pm

Nikodem Graczewski

Do we need this inject?

Do we need this inject?

3:44 pm

Nikodem Graczewski

Please add a method to the FunctionDecorator that wraps the method with the confirmation (similar as with the notificationService).

Please add a method to the FunctionDecorator that wraps the method with the confirmation (similar as with the notificationService).

3:42 pm

Nikodem Graczewski

Remove this if we're injecting the actual service.

Remove this if we're injecting the actual service.

3:40 pm

Nikodem Graczewski

This should be added as a dependency to the admin-product-view module.

This should be added as a dependency to the admin-product-view module.

1:11 pm

Łukasz Lewczyński , Mateusz Kwiatkowski and Nikodem Graczewski

11:55 am

Nikodem Graczewski

Bumped version to 5.5.1-SNAPSHOT

Options
    • -4
    • +4
    /docker-compose.yml
    • -1
    • +1
    /project.properties
9:24 am

Nikodem Graczewski

5.5.1-RC1 release

Options
    • -4
    • +4
    /docker-compose.yml
    • -1
    • +1
    /project.properties
8:51 am

Adugna Worku

Revert "Improved a test spec for product view"

This reverts commit db49249f7fccfc48f71e925bdbdbe862d6973778.

Options
    • -2
    • +1
    /src/admin-product-view/admin-product-view.module.js
    • -43
    • +34
    /src/admin-product-view/admin-product-view.routes.spec.js
    • -2
    • +2
    /src/admin-product-view/messages_en.json
    • -10
    • +10
    /src/admin-product-view/product-view.controller.js
    • -6
    • +8
    /src/admin-product-view/product-view.controller.spec.js
    • -3
    • +3
    /src/admin-product-view/product-view.html
8:23 am

Adugna Worku

Improved a test spec for product view

Options
    • -1
    • +2
    /src/admin-product-view/admin-product-view.module.js
    • -34
    • +43
    /src/admin-product-view/admin-product-view.routes.spec.js
    • -2
    • +2
    /src/admin-product-view/messages_en.json
    • -10
    • +10
    /src/admin-product-view/product-view.controller.js
    • -8
    • +6
    /src/admin-product-view/product-view.controller.spec.js
    • -3
    • +3
    /src/admin-product-view/product-view.html
Friday 12 Apr
2:35 pm

hassan

2:34 pm

hassan

Thank you Nikodem Graczewski

Thank you Nikodem Graczewski

2:30 pm

Nikodem Graczewski and Adugna Worku

1:54 pm

hassan

OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

Options
    • -0
    • +6
    /src/referencedata-orderable/orderable-data-builder.spec.js
    • -4
    • +3
    /src/select-products-modal/select-products-modal.controller.spec.js
1:12 pm

Adugna Worku

What do i update in reference-ui to be precise?

What do i update in reference-ui to be precise?

11:26 am

Nikodem Graczewski

What you need here is a:             new OrderableDataBuilder()                 .withFullProductName('Same Product to displayed')                 .withoutProductCode() //this method needs to be add...

What you need here is a:

            new OrderableDataBuilder()
                .withFullProductName('Same Product to displayed')
                .withoutProductCode() //this method needs to be added to the OrderableDataBuilder
                .build()
11:24 am

Nikodem Graczewski

I don't think this line is valid. Why would a product have a 'withProductCode' field? It is a method from a builder.

I don't think this line is valid. Why would a product have a 'withProductCode' field? It is a method from a builder.

10:57 am

hassan

OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

Options
    • -1
    • +9
    /src/select-products-modal/select-products-modal.controller.spec.js
10:00 am

hassan

Done! Please check

Done! Please check

9:58 am

hassan

OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

Options
    • -1
    • +14
    /src/select-products-modal/select-products-modal.controller.spec.js
8:49 am

Nikodem Graczewski

This will fail for the following: Product code: CD1 Product name: Some Product Search text: pro

This will fail for the following:
Product code: CD1
Product name: Some Product
Search text: pro

8:41 am

Nikodem Graczewski

I've resolved the comment, but please add the missing tests.

I've resolved the comment, but please add the missing tests.

8:39 am

Nikodem Graczewski

This name is invalid. We're expecting an empty list.

This name is invalid. We're expecting an empty list.

1:04 am

hassan

Updated , Please check

Updated , Please check

1:00 am

hassan

OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

Options
    • -2
    • +5
    /src/select-products-modal/select-products-modal.controller.js
    • -0
    • +30
    /src/select-products-modal/select-products-modal.controller.spec.js
Thursday 11 Apr
7:39 am

Nikodem Graczewski

Also, please add unit tests for those two cases mentioned in the comments.

Also, please add unit tests for those two cases mentioned in the comments.

Wednesday 10 Apr
6:56 pm

hassan

I have added the code , Please help to review

I have added the code , Please help to review

6:55 pm

Klaudia Pałkowska

6:40 pm

hassan

OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

Options
    • -3
    • +7
    /src/select-products-modal/select-products-modal.controller.js
    • -3
    • +15
    /src/select-products-modal/select-products-modal.controller.spec.js
12:56 pm

Nikodem Graczewski

OLMIS-6178: Added validation for channel on the notification settings screen

Options
    • -1
    • +2
    /src/openlmis-user/messages_en.json
    • -0
    • +23
    /src/openlmis-user/user-profile-notification-settings.controller.js
    • -0
    • +35
    /src/openlmis-user/user-profile-notification-settings.controller.spec.js
    • -5
    • +14
    /src/openlmis-user/user-profile-notification-settings.html
12:21 pm

hassan

Noted Nikodem Graczewski, Let me work on this. Thank you

Noted Nikodem Graczewski, Let me work on this.

Thank you