openlmis-referencedata-ui

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Do we need this inject?

Do we need this inject?

Please add a method to the FunctionDecorator that wraps the method with the confirmation (similar as with the notificationService).

Please add a method to the FunctionDecorator that wraps the method with the confirmation (similar as with the notificationService).

Remove this if we're injecting the actual service.

Remove this if we're injecting the actual service.

This should be added as a dependency to the admin-product-view module.

This should be added as a dependency to the admin-product-view module.

Bumped version to 5.5.1-SNAPSHOT

5.5.1-RC1 release

Revert "Improved a test spec for product view"

This reverts commit db49249f7fccfc48f71e925bdbdbe862d6973778.

    • -2
    • +2
    /src/admin-product-view/messages_en.json
    • -3
    • +3
    /src/admin-product-view/product-view.html
Improved a test spec for product view

    • -2
    • +2
    /src/admin-product-view/messages_en.json
    • -3
    • +3
    /src/admin-product-view/product-view.html
Thank you Nikodem Graczewski
OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

What do i update in reference-ui to be precise?

What do i update in reference-ui to be precise?

What you need here is a:             new OrderableDataBuilder()                 .withFullProductName('Same Product to displayed')                 .withoutProductCode() //this method needs to be add...

What you need here is a:

            new OrderableDataBuilder()
                .withFullProductName('Same Product to displayed')
                .withoutProductCode() //this method needs to be added to the OrderableDataBuilder
                .build()
I don't think this line is valid. Why would a product have a 'withProductCode' field? It is a method from a builder.

I don't think this line is valid. Why would a product have a 'withProductCode' field? It is a method from a builder.

OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

Done! Please check

Done! Please check

OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

This will fail for the following: Product code: CD1 Product name: Some Product Search text: pro

This will fail for the following:
Product code: CD1
Product name: Some Product
Search text: pro

I've resolved the comment, but please add the missing tests.

I've resolved the comment, but please add the missing tests.

This name is invalid. We're expecting an empty list.

This name is invalid. We're expecting an empty list.

Updated , Please check

Updated , Please check

OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

Also, please add unit tests for those two cases mentioned in the comments.

Also, please add unit tests for those two cases mentioned in the comments.

I have added the code , Please help to review

I have added the code , Please help to review

OLMIS-6167: Fixed UI issue of misplaced button after searching for products on the orderable details screen

OLMIS-6178: Added validation for channel on the notification settings screen

    • -0
    • +23
    /src/openlmis-user/user-profile-notification-settings.controller.js
    • -0
    • +35
    /src/openlmis-user/user-profile-notification-settings.controller.spec.js
Noted Nikodem Graczewski, Let me work on this. Thank you

Noted Nikodem Graczewski, Let me work on this.

Thank you