openlmis-referencedata

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Perhaps we could use the "associations" term? It was mentioned in one of the comments to the mockups.

Perhaps we could use the "associations" term? It was mentioned in one of the comments to the mockups.

OLMIS-5493, add togglz junit support and show test's for both feature states

OLMIS-5493, add VersionController test for feature enabled

Thanks for doing this. However, I don't think it's necessary to do class diagrams for all of our "infrastructure" classes (importers, DTOs, repositories, etc.). The important ones are the domain cl...

Thanks for doing this. However, I don't think it's necessary to do class diagrams for all of our "infrastructure" classes (importers, DTOs, repositories, etc.). The important ones are the domain classes (SupplyPartner and SupplyPartnerEntry) and how they relate to our existing reference data domain classes (program, supervisory node, etc.).

I didn't want to use the term "subscription" because I didn't want us to do it the way eLMIS does; duplicating a program and copying values over. They don't really seem like subscriptions to me. If...

I didn't want to use the term "subscription" because I didn't want us to do it the way eLMIS does; duplicating a program and copying values over. They don't really seem like subscriptions to me. If you feel entry is too generic, I am open to other suggestions. Perhaps mapping? But that seems about the same to me.

Ah yes, you're correct.

Ah yes, you're correct.

Agreed.

Agreed.

OLMIS-5493, add togglz testing and set max parallel forks to be core oritented.

Revert "Revert "OLMIS-5493, add missing link""

This reverts commit 005ca5a109a23e14270f05f4acb1d8701451614e.

Revert "Revert "OLMIS-5493, add redis to builder""

This reverts commit 13ed609e68680a02c87ee2ddbc87f452dffeeb35.

Revert "Revert "OLMIS-5493, update dev image to latest""

This reverts commit ebd17e82f99710544c7a34437519500d0c89d648.

Revert "Revert "OLMIS-5493, add Togglz and example version feature.""

This reverts commit fb06f5eaea09d5d8125610fa124c2978df971f3f.

    • -0
    • +29
    /src/main/java/org/openlmis/referencedata/AvailableFeatures.java
added

added

backend will handle null value for entries but I think it would be better to simply send an empty list instead of null

backend will handle null value for entries but I think it would be better to simply send an empty list instead of null

OLMIS-5137: made entries field as required in supply partner json schema

added

added

changed

changed

changed

changed

changed

changed

changed

changed

changed

changed

changed

changed

changed

changed

changed

changed

OLMIS-5137: update raml

    • -12
    • +17
    /src/main/resources/api-definition.yaml
I thought that for PUT if a resource does not exist, a new one should be created with the given id

I thought that for PUT if a resource does not exist, a new one should be created with the given id

both fields make sense for me

both fields make sense for me

I think there was a reason why we decided to call this property as entries but I don't remember. I am okay with changing it to subscriptions but I would wait for Chongsun Ahn response

I think there was a reason why we decided to call this property as entries but I don't remember. I am okay with changing it to subscriptions but I would wait for Chongsun Ahn response

I would say if a request has null or it is not set then backend should treat it as an empty list.

I would say if a request has null or it is not set then backend should treat it as an empty list.