referencedata-pending-offline-events-indicator

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-7207: Refreshed offline events indicator after sync error
OLMIS-7207: Refreshed offline events indicator after sync error
OLMIS-7207: Updated offline events service decorator

    • -64
    • +0
    ./pending-offline-events.service.decorator.js
    • -78
    • +0
    ./pending-offline-events.service.decorator.spec.js
    • -30
    • +0
    ./referencedata-pending-offline-events-indicator.module.js
  1. … 7 more files in changeset.
OLMIS-7205: Updated the event service method to return only events that have not been synchronized...
OLMIS-7205: Updated the event service method to return only events that have not been synchronized...
OLMIS-7205: Updated the event service method to return only events that have not been synchronized before

    • -1
    • +1
    ./pending-offline-events.service.decorator.js
    • -3
    • +3
    ./pending-offline-events.service.decorator.spec.js
  1. … 3 more files in changeset.
Oh, I see https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

Oh, I see

Updated

Updated

I have managed to extract some parts of code

I have managed to extract some parts of code

OLMIS-7198: Updated function used by pendingOfflineEventsService decorator

    • -1
    • +1
    ./pending-offline-events.service.decorator.js
    • -3
    • +3
    ./pending-offline-events.service.decorator.spec.js
Yes, but pending-offline-events.service.decorator should use getUserEventsFromStorage because we don't need there all the information that the getOfflineEvents returns

Yes, but pending-offline-events.service.decorator should use getUserEventsFromStorage because we don't need there all the information that the getOfflineEvents returns

Hmm.. but from what I see, in the pending-offline-events.service.decorator we use only the getOfflineEvents function

Hmm.. but from what I see, in the pending-offline-events.service.decorator we use only the getOfflineEvents function

Do you think you can extract something from the functions getOfflineEvents or combineResponses to make them a little smaller?

Do you think you can extract something from the functions getOfflineEvents or combineResponses to make them a little smaller?

The description of this function and the getUserEventsFromStorage are the same. However, this function returns more information

The description of this function and the getUserEventsFromStorage are the same. However, this function returns more information

This function is only used by getOfflineEvents but should also be used by pending-offline-events.service.decorator

This function is only used by getOfflineEvents but should also be used by pending-offline-events.service.decorator

OLMIS-7198: Added tests for event searching
OLMIS-7198: Added tests for event searching
OLMIS-7209: Corrected documentation of of the pending offline event service decorator
OLMIS-7209: Corrected documentation of of the pending offline event service decorator
OLMIS-7209: Added tests for pending offline events service decorator

    • -0
    • +78
    ./pending-offline-events.service.decorator.spec.js
  1. … 1 more file in changeset.
OLMIS-7209: Corrected documentation of of the pending offline event service decorator

    • -1
    • +1
    ./pending-offline-events.service.decorator.js
OLMIS-7209: Added decorator for pendingOfflineEventsService and eventsService which retrieves pending offline events for the current user

    • -0
    • +64
    ./pending-offline-events.service.decorator.js
    • -0
    • +30
    ./referencedata-pending-offline-events-indicator.module.js
  1. … 3 more files in changeset.