offline-events.html

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Oh, I see https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

Oh, I see

Updated

Updated

I have managed to extract some parts of code

I have managed to extract some parts of code

Yes, but pending-offline-events.service.decorator should use getUserEventsFromStorage because we don't need there all the information that the getOfflineEvents returns

Yes, but pending-offline-events.service.decorator should use getUserEventsFromStorage because we don't need there all the information that the getOfflineEvents returns

Hmm.. but from what I see, in the pending-offline-events.service.decorator we use only the getOfflineEvents function

Hmm.. but from what I see, in the pending-offline-events.service.decorator we use only the getOfflineEvents function

Do you think you can extract something from the functions getOfflineEvents or combineResponses to make them a little smaller?

Do you think you can extract something from the functions getOfflineEvents or combineResponses to make them a little smaller?

The description of this function and the getUserEventsFromStorage are the same. However, this function returns more information

The description of this function and the getUserEventsFromStorage are the same. However, this function returns more information

This function is only used by getOfflineEvents but should also be used by pending-offline-events.service.decorator

This function is only used by getOfflineEvents but should also be used by pending-offline-events.service.decorator

OLMIS-7198: Added tests for event searching
OLMIS-7198: Added tests for event searching
OLMIS-7198: Fixed behaviour of getOfflineEvents function

  1. … 6 more files in changeset.
OLMIS-7198: Add pending operation table on the Pending Offline events screen

    • -0
    • +61
    ./offline-events.html
  1. … 7 more files in changeset.