20171026101430373__create_index_on_proof_of_deliveries_fk.sql

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LGTM, thanks.

LGTM, thanks.

Looks like we've removed it for now. Marked as resolved.

Looks like we've removed it for now. Marked as resolved.

I think Łukasz Lewczyński is confusnig the orderid with orderlineitemid. I also don't we need this index - Paweł Albecki I suggest we drop it, unless you know of where it can be used.

I think Łukasz Lewczyński is confusnig the orderid with orderlineitemid. I also don't we need this index - Paweł Albecki I suggest we drop it, unless you know of where it can be used.

Łukasz Lewczyński and Paweł Albecki: I lost this one for a bit as it wasn't put back into review after I marked it complete with unresolved comments the first pass. Please make sure you re-open it ...

Łukasz Lewczyński and Paweł Albecki: I lost this one for a bit as it wasn't put back into review after I marked it complete with unresolved comments the first pass. Please make sure you re-open it for review to ensure it shows up on my review dashboard. Thanks.

Not yet, do we have a github link for where we think this might be used? It seems really odd that we'd find pod line items through a search on them using order line item ids.

Not yet, do we have a github link for where we think this might be used? It seems really odd that we'd find pod line items through a search on them using order line item ids.

Josh Zamor Łukasz is out, does it answer your question?

Josh Zamor Łukasz is out, does it answer your question?

I think it could be used when POD is created. Currently we retrieve POD dto contains related order

I think it could be used when POD is created. Currently we retrieve POD dto contains related order

This is looking good. Left a comment on one.

This is looking good. Left a comment on one.

This feels like an over-index. What query would search by: select * from proof_of_delivery_line_items where orderlineitemid = X?

This feels like an over-index. What query would search by:

select * from proof_of_delivery_line_items where orderlineitemid = X?

OLMIS-3453: Added index in order_line_items fk
OLMIS-3453: Added index in order_line_items fk
OLMIS-3453: Added index in proof_of_deliveries fk

    • -0
    • +1
    ./20171026101430373__create_index_on_proof_of_deliveries_fk.sql