docker-compose.yml

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
looks ok

looks ok

added

added

Lacks contract tests and deployment.

Lacks contract tests and deployment.

OLMIS-1972: Bump Postgres to 9.6
OLMIS-1972: Bump Postgres to 9.6
OLMIS-1972: Bump Postgres to 9.6

  1. … 3 more files in changeset.
It's to make everything a tedious workflow. No, it's so that we can go back in time, and build 3.0, when we're working on 3.5 with JDK 9, and there is a dev image and all the other crap out there ...

It's to make everything a tedious workflow.

No, it's so that we can go back in time, and build 3.0, when we're working on 3.5 with JDK 9, and there is a dev image and all the other crap out there that's published to docker hub with JDK8 (and all the other tools)

LGTM

Looks okay to me. I don't understand all of the implications for versioning, but Josh should grok it all.

Looks okay to me. I don't understand all of the implications for versioning, but Josh should grok it all.

OLMIS-1933 Change infrastructure/dev images from latest to version number
OLMIS-1933 Change infrastructure/dev images from latest to version number
OLMIS-1933 Change infrastructure/dev images from latest to 1

Moving away from latest to versioned image.

  1. … 4 more files in changeset.
OLMIS-1933 Change postgres image from latest to 9.4

Moving away from latest to versioned image.

  1. … 2 more files in changeset.
I will fix those issues in the next review

I will fix those issues in the next review

Łukasz Lewczyński You may want to take a look at the Sonar for these files to see if there are any major issues in the code.

Łukasz Lewczyński You may want to take a look at the Sonar for these files to see if there are any major issues in the code.

LGTM

LGTM

If it's not file based the idea was that it would still provide a file for FTP - it could create a temp one. But this is minor, we can think about this more later.

If it's not file based the idea was that it would still provide a file for FTP - it could create a temp one. But this is minor, we can think about this more later.

I think yes if your storage is not related with files this method should return unsupported operation

I think yes if your storage is not related with files this method should return unsupported operation

Is this a valid usage though? Why wouldn't I implement this - ftp won't work if I don't.

Is this a valid usage though? Why wouldn't I implement this - ftp won't work if I don't.

This is a new feature to Java 8. So if you implement interface you don't have to implement this method.

This is a new feature to Java 8. So if you implement interface you don't have to implement this method.

That being said - hope it's obvious to people that they have to implement this

That being said - hope it's obvious to people that they have to implement this

An interface with an implementation? What heresy. But I guess we are using Java 8, so fine

An interface with an implementation? What heresy. But I guess we are using Java 8, so fine

what does default do?

what does default do?

changed

changed

added

added

added

added

method added with default implementation

method added with default implementation