cce.cce_alerts.json

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-4876: Applied new demo data loading approach
OLMIS-4876: Applied new demo data loading approach
OLMIS-4876: Applied new demo data loading approach

  1. … 33 more files in changeset.
Probably; it's probably habit from the old Hibernate generated schema days.

Probably; it's probably habit from the old Hibernate generated schema days.

Left a curiosity question. LGTM, thanks!

Left a curiosity question. LGTM, thanks!

I'm having a brainfart. Why do we declare this type here? Isn't this duplicative since the schema is defined in flyway?

I'm having a brainfart. Why do we declare this type here? Isn't this duplicative since the schema is defined in flyway?

lgtm.

lgtm.

Too true.

Too true.

OLMIS-4197 Change schema from dismissed to dismissTimestamp
OLMIS-4197 Change schema from dismissed to dismissTimestamp
I found a way to avoid changing "en-US" to "en_US".

I found a way to avoid changing "en-US" to "en_US".

I did ask the question in the Slack #ui channel, but got no response. I also scoured the Internetz for any answers. I didn't ask anyone specifically though.

I did ask the question in the Slack #ui channel, but got no response. I also scoured the Internetz for any answers. I didn't ask anyone specifically though.

I believe that is handled in the not matching FHIR regex test.

I believe that is handled in the not matching FHIR regex test.

This looks good, left one comment. Could we send the UI review question to Team Parrot where they might know how it works in Angular?

This looks good, left one comment. Could we send the UI review question to Team Parrot where they might know how it works in Angular?

What do we do if the length is longer than 64 characters?

What do we do if the length is longer than 64 characters?

OLMIS-4197 Change schema from dismissed to dismissTimestamp

Will need the timestamp to show when the alert was dismissed, but we do not need both values.

  1. … 6 more files in changeset.
OLMIS-4105 Support alert_id in DTO to be a non-UUID string
OLMIS-4105 Support alert_id in DTO to be a non-UUID string
OLMIS-4105 Support alert_id in DTO to be a non-UUID string

This is done by adding a new field called externalId which is what is mapped to alert_id. Validation added to make sure it matches FHID id datatype regex. New repository methods and make sure JPA knows to update based on externalId, not id.

  1. … 12 more files in changeset.
lgtm!

lgtm!

The architect role summed up in one line https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/biggrin.gif

The architect role summed up in one line

I may regret this, but I changed it.

I may regret this, but I changed it.

OLMIS-4129 Add active field to Alert to simply queries

To make the queries more readable, add an active field to Alert, which is determined by the other fields. Save this to database, so the queries can read from it.

  1. … 4 more files in changeset.
OLMIS-4125 Add demo data for CCE alerts

Add inactive alerts to CCE inventory at Cuamba, Cuamba, for testing.

  1. … 1 more file in changeset.
It looks good and I believe I covered all of your bullet points for review. I did leave one comment around the complexity and location of the logic of "active".

It looks good and I believe I covered all of your bullet points for review. I did leave one comment around the complexity and location of the logic of "active".