facility-cce-status

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
We should be adding new update in changelog after the last entry, so please change this

We should be adding new update in changelog after the last entry, so please change this

OLMIS-6484: Fixed 'The page size is not specified' error for /inventoryItems endpoints
OLMIS-6484: Fixed 'The page size is not specified' error for /inventoryItems endpoints
OLMIS-6484: Fixed 'The page size is not specified' error for /inventoryItems endpoints

    • -2
    • +7
    ./cce-inventory-item.service.decorator.js
    • -5
    • +5
    ./cce-inventory-item.service.decorator.spec.js
  1. … 1 more file in changeset.
Revert "OLMIS-6484 - Fixed 'The page size is not specified' error for /inventoryItems endpoints"

This reverts commit 53572604df91f38d1bae062acfe72b7914698550.

    • -7
    • +2
    ./cce-inventory-item.service.decorator.js
    • -10
    • +5
    ./cce-inventory-item.service.decorator.spec.js
  1. … 1 more file in changeset.
OLMIS-6484 - Fixed 'The page size is not specified' error for /inventoryItems endpoints

    • -2
    • +7
    ./cce-inventory-item.service.decorator.js
    • -5
    • +10
    ./cce-inventory-item.service.decorator.spec.js
  1. … 1 more file in changeset.
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts

    • -0
    • +1
    ./cce-inventory-item.service.decorator.spec.js
    • -0
    • +2
    ./facility-cce-status.controller.spec.js
  1. … 13 more files in changeset.
Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

aaaand here https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

aaaand here

and here

and here

same here

same here

maybe, just maybe we could put those withModel/withType in a new line?

maybe, just maybe we could put those withModel/withType in a new line?

OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

    • -10
    • +12
    ./cce-inventory-item.service.decorator.spec.js
    • -6
    • +6
    ./facility-cce-status.constant.spec.js
    • -54
    • +66
    ./facility-cce-status.controller.spec.js
  1. … 21 more files in changeset.
Enabled eslint

    • -9
    • +9
    ./cce-inventory-item.service.decorator.js
    • -23
    • +22
    ./facility-cce-status.constant.js
    • -2
    • +2
    ./facility-cce-status.constant.spec.js
    • -25
    • +25
    ./facility-cce-status.controller.js
    • -2
    • +2
    ./facility-cce-status.controller.spec.js
  1. … 31 more files in changeset.
But we use this flag in controller too, we don't want to have business logic both in controller and html. Plus it's tested. Plus it can change in future and it should be easily changeable in one pl...

But we use this flag in controller too, we don't want to have business logic both in controller and html. Plus it's tested. Plus it can change in future and it should be easily changeable in one place.

Chongsun Ahn I'm resolving this comment as I believe the popover issue has been fixed. Please, let us know if you think otherwise! https://review.openlmis.org/static/ql0uca/2static/images/wiki/icon...

Chongsun Ahn I'm resolving this comment as I believe the popover issue has been fixed. Please, let us know if you think otherwise!

Paweł Albecki Do we need this flag? Couldn't we use vm.inventoryItems.length in html?

Paweł Albecki Do we need this flag? Couldn't we use vm.inventoryItems.length in html?

OLMIS-4475: monor improvements in facility cce status component

    • -0
    • +18
    ./facility-cce-status.controller.spec.js
This should be set inside the $onInit method.

This should be set inside the $onInit method.