Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I think that the problem is you don't have any catalog items added so you can add some using csv file.

I think that the problem is you don't have any catalog items added so you can add some using csv file.

Nick Reid all of unresolved comments were corrected in commit for other ticket https://review.openlmis.org/changelog/openlmis-cce-ui?cs=244db1289bf77719e977b8cdfbae38f4de52eb60
I can do that. https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

I can do that.

Overall this looks good — I'd like to figure out how to test it, but am unsure of who to login as

Overall this looks good — I'd like to figure out how to test it, but am unsure of who to login as

This heading structure is upside down.... I'm not 100% sure about having multiple h1s on a page, but I think with how we use "pages" it would be ok <h1 class="modal-title">.....</h1> .... <h2>vm.i...

This heading structure is upside down.... I'm not 100% sure about having multiple h1s on a page, but I think with how we use "pages" it would be ok

<h1 class="modal-title">.....</h1>
....
<h2>vm.inventoryItem.referenceName</h2>
...

make a definition list

make a definition list

Why is this a fieldset? There are no form controls here.... maybe a second definition list?

Why is this a fieldset? There are no form controls here.... maybe a second definition list?

OLMIS-2897: Added Update Status modal
OLMIS-2897: Added Update Status modal
OLMIS-2897: Added Update Status modal

  1. … 20 more files in changeset.
OLMIS-2897: Work in Progress

  1. … 24 more files in changeset.
OLMIS-2897: Work in Progress

  1. … 19 more files in changeset.
Fix indentation.

Fix indentation.

Re-enable tests.

Re-enable tests.

cce -> CCE

cce -> CCE

Looks good to me - if I ignore commented out unit tests

Looks good to me - if I ignore commented out unit tests

Be sure to re-enable test

Be sure to re-enable test

OLMIS-2896: added CCE inventory items screen
OLMIS-2896: added CCE inventory items screen
OLMIS-2896: added CCE inventory items screen

  1. … 11 more files in changeset.
OLMIS-2896: Work in progress

  1. … 7 more files in changeset.