messages_en.json

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Mateusz Kwiatkowski Nikodem Graczewski so it looks like the then/catch part have to be present?

Mateusz Kwiatkowski Nikodem Graczewski so it looks like the then/catch part have to be present?

done

done

done

done

done

done

Dropping the whole then catch part should work.

Dropping the whole then catch part should work.

Consistency. It doesn't really matter if it is right or wrong as long as it is consistent. And we lack a lot of consistency on the UI anyway, no need to add even more.

Consistency. It doesn't really matter if it is right or wrong as long as it is consistent. And we lack a lot of consistency on the UI anyway, no need to add even more.

now sure what should I change here

now sure what should I change here

what is returned by permission service? is promise rejected if user has no right or only if request or smth else failed?

what is returned by permission service? is promise rejected if user has no right or only if request or smth else failed?

do we really need to worry about extra space? Also I think there should be space between function and () but I am not a UI expert https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons...

do we really need to worry about extra space? Also I think there should be space between function and () but I am not a UI expert If you check for example controller spec file, you could see that there is a space between function and () (line 16) that this was not done by me

this is a copy paste from other route and I only make some small changes.

this is a copy paste from other route and I only make some small changes.

Can't we just return the promise? Shouldn't it resolve to true? I would expect rejection to only be raised if something went wrong.

Can't we just return the promise? Shouldn't it resolve to true? I would expect rejection to only be raised if something went wrong.

again, remove the space

again, remove the space

Actually, I don't think we put a space here.

Actually, I don't think we put a space here.

done

done

wrrrr

wrrrr

remove this https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

remove this

done

done

done

done

done

done

The openlmis-facility-program-select directive should contain facilities/program combo to which user has view or edit right, here I only check if user has edit right because I need to display a but...

The openlmis-facility-program-select directive should contain facilities/program combo to which user has view or edit right, here I only check if user has edit right because I need to display a button.

Is this working? User can enter page without edit right?

Is this working? User can enter page without edit right?

do you use user in this controller? if not please remove all user related variables/injects from here and tests

do you use user in this controller? if not please remove all user related variables/injects from here and tests

this assignment should be done in onInit

this assignment should be done in onInit

it should be lowercase string

it should be lowercase string

OLMIS-2895: Extended filter options on CCE Inventory screen
OLMIS-2895: Extended filter options on CCE Inventory screen
OLMIS-2895: Extended filter options on CCE Inventory screen

  1. … 6 more files in changeset.
OLMIS-4127 Changes after code review feedback

* CCE alert data builder

* More tests

* Move messages

  1. … 12 more files in changeset.