Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thank you very much, Chongsun Ahn. I added Mateusz Kwiatkowski to the review just incase we was able to get to it first. I don't think it needs two review, though, and will thus try marking this on...

Thank you very much, Chongsun Ahn. I added Mateusz Kwiatkowski to the review just incase we was able to get to it first. I don't think it needs two review, though, and will thus try marking this one as done.

Looks good to me.

Looks good to me.

OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values
OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values
rtmAlerts.viewHistory was already part of this file.

rtmAlerts.viewHistory was already part of this file.

OLMIS-3174: Remove unnecessary labels.

  1. … 1 more file in changeset.
Update the enum as per the requirements in OLMIS-3174.

Update the enum as per the requirements in OLMIS-3174.

Update the enum as per the requirements in OLMIS-3174.

Update the enum as per the requirements in OLMIS-3174.

LGTM

LGTM

can we have this button in new line?

can we have this button in new line?

OLMIS-4197 Add view alert history to CCE update functionality status
OLMIS-4197 Add view alert history to CCE update functionality status
OLMIS-4197 Add view alert history to CCE update functionality status

This adds a button to show the view alert history PDF.

  1. … 4 more files in changeset.
Ticket created: https://openlmis.atlassian.net/browse/OLMIS-4270

Ticket created: https://openlmis.atlassian.net/browse/OLMIS-4270

I tried it and as you said increasing timeout didn't help, it shows generic alert right away, I would create a bug for it.

I tried it and as you said increasing timeout didn't help, it shows generic alert right away, I would create a bug for it.

I can take a look, it seems that we are doing similar things in many other places, it is strange that it does not work here

I can take a look, it seems that we are doing similar things in many other places, it is strange that it does not work here

There are a number of changes in this review unrelated to the ticket; just focus on the changes related to the unresolved issues.

There are a number of changes in this review unrelated to the ticket; just focus on the changes related to the unresolved issues.

Thanks.

Thanks.

OK, great.

OK, great.

It should work the same

It should work the same

Before saving the alert, I want the dismissed setting to be true, so that the alert is now saved as dismissed.

Before saving the alert, I want the dismissed setting to be true, so that the alert is now saved as dismissed.

You mean if I just have return repository.save(alert), it would work the same?

You mean if I just have return repository.save(alert), it would work the same?

I would consider this a "default" value. The previous value didn't make sense, as end_ts changed format from Unix epoch to ISO8601 date string.

I would consider this a "default" value. The previous value didn't make sense, as end_ts changed format from Unix epoch to ISO8601 date string.