cce-inventory-item-status

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts

    • -1
    • +3
    ./cce-inventory-item-status.routes.spec.js
    • -15
    • +4
    ./status-update-modal.controller.spec.js
  1. … 13 more files in changeset.
Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

aaaand here https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

aaaand here

and here

and here

same here

same here

maybe, just maybe we could put those withModel/withType in a new line?

maybe, just maybe we could put those withModel/withType in a new line?

OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

    • -11
    • +9
    ./status-update-modal.controller.spec.js
  1. … 23 more files in changeset.
Please fix duplicated description.

Please fix duplicated description.

This could use some tests.

This could use some tests.

OLMIS-4535: Added an abstract state for inventory item details and status update modals
OLMIS-4535: Added an abstract state for inventory item details and status update modals
OLMIS-4535: Added an abstract state for inventory item details and status update modals

    • -24
    • +2
    ./cce-inventory-item-status.routes.js
    • -95
    • +30
    ./cce-inventory-item-status.routes.spec.js
  1. … 16 more files in changeset.
Enabled eslint

    • -10
    • +14
    ./status-update-modal.controller.js
  1. … 33 more files in changeset.
Fixed tech debt

  1. … 6 more files in changeset.
Yea, that might be problematic, could we maybe create another one that will have this "font" parameter and take content as param?

Yea, that might be problematic, could we maybe create another one that will have this "font" parameter and take content as param?

The mixin doesn't seem to work in this case. So I mimiced how the invalid icon is set up.

The mixin doesn't seem to work in this case. So I mimiced how the invalid icon is set up.

It won't, from the implementers point of view nothing changes.

It won't, from the implementers point of view nothing changes.

add info about fixing/changing auto-resize directive, or it will not affect elements other than date inputs?

add info about fixing/changing auto-resize directive, or it will not affect elements other than date inputs?

I think that we have a icon style that we can include here?

I think that we have a icon style that we can include here?