edit-inventory-item.scss

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-2619: fixed heading markup in edit inventory item modal

  1. … 3 more files in changeset.
Yea, that looks about right... make the dt width 10em... and test it with a long word, please.

Yea, that looks about right...

make the dt width 10em... and test it with a long word, please.

Yea, I'm ok with it — can we make the title div an h3 Ideally we would get that legend to look right — but legends are a pain in the ass to style, and we got deadlines Mateusz Kwiatkowski

Yea, I'm ok with it — can we make the title div an h3

Ideally we would get that legend to look right — but legends are a pain in the ass to style, and we got deadlines

Mateusz Kwiatkowski

This should be an h2

This should be an h2

Nick Reid I've changed this to sub-heading markup from styleguide because legends just looked weird, are OK with it?

Nick Reid I've changed this to sub-heading markup from styleguide because legends just looked weird, are OK with it?

it is not an adjustments modal

it is not an adjustments modal

Nick Reid I think that this style for dl markup should be wrapped by new class name and moved to ui-components (it is a copy paste from edit-inventory-item.scss). Do you agree?

Nick Reid I think that this style for dl markup should be wrapped by new class name and moved to ui-components (it is a copy paste from edit-inventory-item.scss). Do you agree?

OLMIS-2619: added small fixes to edit inventory item modal

    • -0
    • +18
    ./edit-inventory-item.scss
  1. … 14 more files in changeset.
Nick Reid So I should also remove barcode from Inventory Item entity on the server side? If we are going to use it later it could be just there as it is non-required field

Nick Reid So I should also remove barcode from Inventory Item entity on the server side? If we are going to use it later it could be just there as it is non-required field

Overall this looks good!

Overall this looks good!

Lets change this css class name to `cce-inventory-item-status` – that way its really explicit where the style is coming from. I do like these styles, and I could totally see making this a standard...

Lets change this css class name to `cce-inventory-item-status` – that way its really explicit where the style is coming from.

I do like these styles, and I could totally see making this a standard – but I think we should use it in another place before we do that

PS we decided to remove this field (sorry)

PS we decided to remove this field (sorry)

Yea we took it from some form in stockmanagement

Yea we took it from some form in stockmanagement

Fair enough...

Fair enough...

It's a reflection of this ENUM: https://github.com/OpenLMIS/openlmis-cce/blob/master/src/main/java/org/openlmis/cce/domain/ManualTemperatureGaugeType.java It actually was 'BUILT_IN, but the back-en...

It's a reflection of this ENUM:
https://github.com/OpenLMIS/openlmis-cce/blob/master/src/main/java/org/openlmis/cce/domain/ManualTemperatureGaugeType.java
It actually was 'BUILT_IN, but the back-end whined.

I know, Atom snippet https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/sad.gif Actually... It's a constant, I won't be injecting anything here anyway. I think I can just...

I know, Atom snippet Actually... It's a constant, I won't be injecting anything here anyway. I think I can just update the snippet.

The only downside is that there is a lot of code duplication across them, like prepareView and getElement function(I'm sure I could find more)... Perhaps we could think of a some kind of 'openlmis-...

The only downside is that there is a lot of code duplication across them, like prepareView and getElement function(I'm sure I could find more)... Perhaps we could think of a some kind of 'openlmis-test-utils' module to store those things? It would help a lot and would allow us to add more custom matchers(these things are amazing, they can make the expect statement express exactly what we want from the test!).

Let's hope they will help us catch more regressions! ^^

Let's hope they will help us catch more regressions! ^^

Nope, having trouble finding the right way to format htmls... https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/sad.gif Got any read on t hat? https://review.openlmis.or...

Nope, having trouble finding the right way to format htmls... Got any read on t hat?

It's pretty awesome actually https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/biggrin.gif

It's pretty awesome actually

This is minor – but maybe make this variable to be 'BUILT_IN' ?? just to match the text?

This is minor – but maybe make this variable to be 'BUILT_IN' ?? just to match the text?

you don't need this...

you don't need this...

These types of unit tests are great!

These types of unit tests are great!

wow this is hard to read.... got any thoughts about how to reformat it a little more cleanly?

wow this is hard to read....

got any thoughts about how to reformat it a little more cleanly?

Lets use fieldsets and legends here — we can make the exact style match later

Lets use fieldsets and legends here — we can make the exact style match later

Use a definition list here (and if the display is sidweays, we can deal with that separately)

Use a definition list here (and if the display is sidweays, we can deal with that separately)

whoa! never saw that `form=""` attribute before

whoa! never saw that `form=""` attribute before