cce-add-inventory-item

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts

  1. … 14 more files in changeset.
Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

aaaand here https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

aaaand here

and here

and here

same here

same here

maybe, just maybe we could put those withModel/withType in a new line?

maybe, just maybe we could put those withModel/withType in a new line?

OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

    • -7
    • +10
    ./cce-add-inventory-item.routes.spec.js
  1. … 22 more files in changeset.
Removed, because it wasn't used anywhere.

Removed, because it wasn't used anywhere.

Could we make this isProgramAssigned?

Could we make this isProgramAssigned?

I think we can remove this...

I think we can remove this...

OLMIS-3240: Added missing q in html test

OLMIS-3240: Removed duplication in admin-facility modules
OLMIS-3240: Removed duplication in admin-facility modules
added checks for calling initaite method from requisition service
added checks for calling initaite method from requisition service
mocked unrelated service calls

Great idea!

Great idea!

I think we could change this method. Basically id is given in the withId method so there is no need to do this one more time. It would be better to have withServiceUrl() and withResource().

I think we could change this method. Basically id is given in the withId method so there is no need to do this one more time. It would be better to have withServiceUrl() and withResource().

fix this check

fix this check