config.json

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed in FEOLMIS-3291.

Fixed in FEOLMIS-3291.

Turned on eslint

I would like us to avoid pushing everything into utility classes to be honest. I can't really think of any good name for it and we won't really remember about that class tomorrow so it will become ...

I would like us to avoid pushing everything into utility classes to be honest. I can't really think of any good name for it and we won't really remember about that class tomorrow so it will become just another tech debt.

It will be once all the repositories actually follow this code style. For now I've put it here so we can take advantage of the new task.

It will be once all the repositories actually follow this code style. For now I've put it here so we can take advantage of the new task.

Yep, it has an illegal character "-".

Yep, it has an illegal character "-".

I kind of investigated it and I'm a little bit hesitant to do it. I will create a ticket for that though.

I kind of investigated it and I'm a little bit hesitant to do it. I will create a ticket for that though.

should 'Content-Type' be wrapped in ' '?

should 'Content-Type' be wrapped in ' '?

I feel like this file should be a part of dev-ui

I feel like this file should be a part of dev-ui

feels like this is some kind of utility method, can we move it to some more generic file so other modules can use it?

feels like this is some kind of utility method, can we move it to some more generic file so other modules can use it?

can we refactor this? I think this name is defined on the UI, not backend

can we refactor this? I think this name is defined on the UI, not backend

This file require more "meticulous" touch as I have refactored the hasRight method. Keep in mind that I've removed obsolete checks for warehouses and supervisory nodes as they are no longer part of...

This file require more "meticulous" touch as I have refactored the hasRight method. Keep in mind that I've removed obsolete checks for warehouses and supervisory nodes as they are no longer part of the right object.

Fixed eslint bugs
Fixed eslint bugs
Added test for authorizationServiceHasRights method

  1. … 4 more files in changeset.
Turned of eslint task

Mateusz Kwiatkowski Yes, I think that would work.... let's chat about that outside of this review

Mateusz Kwiatkowski Yes, I think that would work.... let's chat about that outside of this review

Done, good catch!

Done, good catch!

We could move sonar.sh file to dev-ui too

We could move sonar.sh file to dev-ui too

You forgot to remove build.sh from ui-components, ui-layout and requisition-ui

You forgot to remove build.sh from ui-components, ui-layout and requisition-ui

LGTM

LGTM

OLMIS-3108: Changes to build process across UI projects
OLMIS-3108: Changes to build process across UI projects
OLMIS-3108: Removed unused configuration

OLMIS-3108: Update transifex configuration

  1. … 2 more files in changeset.
I changed my mind because I felt like I was over engineering — there is no reason to maintain a feature if there is no current use of it

I changed my mind because I felt like I was over engineering — there is no reason to maintain a feature if there is no current use of it