Dashboard

Bump locutus from 2.0.10 to 2.0.14

Bumps [locutus](https://github.com/locutusjs/locutus) from 2.0.10 to 2.0.14.

- [Release notes](https://github.com/locutusjs/locutus/releases)

- [Changelog](https://github.com/locutusjs/locutus/blob/master/CHANGELOG.md)

- [Commits](https://github.com/locutusjs/locutus/compare/v2.0.10...v2.0.14)

Signed-off-by: dependabot[bot] <support@github.com>

This doesn't look right to me. This method simply creates a line item domain object based on a DTO, so why would it care about a requisition status? If you want to deal with a skipped field, you sh...

This doesn't look right to me. This method simply creates a line item domain object based on a DTO, so why would it care about a requisition status? If you want to deal with a skipped field, you should do it somewhere else.

This should be pluralized, equipment_types

This should be pluralized, equipment_types

I have added this ; (!requisition.isApproved()) { if (requisitionLineItem.getSkipped() != null){ this.skipped = requisitionLineItem.getSkipped(); } else{ this.skipped = false; } } in Requisition...

I have added this ;
(!requisition.isApproved()) {
if (requisitionLineItem.getSkipped() != null)

Unknown macro: { this.skipped = requisitionLineItem.getSkipped(); }

else

Unknown macro: { this.skipped = false; }

}

in RequisitionLineItem class to only allow unskipping before approval status, that works for authorized status.

I have corrected this, the shouldNotSetSkippedIfRequisitionStatusIsApproved mehtod is now working as expected.

I have corrected this, the shouldNotSetSkippedIfRequisitionStatusIsApproved mehtod is now working as expected.

making updating requsition line items dependant on requisition status

This makes sense

This makes sense

TZUP-77 : Update equipment_type table

persisting unskipped lineitems when approving

Bump merge from 1.2.0 to 1.2.1

Bumps [merge](https://github.com/yeikos/js.merge) from 1.2.0 to 1.2.1.

- [Release notes](https://github.com/yeikos/js.merge/releases)

- [Commits](https://github.com/yeikos/js.merge/compare/v1.2.0...v1.2.1)

Signed-off-by: dependabot[bot] <support@github.com>

I am also wondering where the logic is to allow something can be unskipped if status is authorized?

I am also wondering where the logic is to allow something can be unskipped if status is authorized?

Then why does the RequisitionBuilderTest seems to set skipped when status is approved?

Then why does the RequisitionBuilderTest seems to set skipped when status is approved?

adding approver unskipped items report

Only when AUTHORIZED, once approved there can never be changes.

Only when AUTHORIZED, once approved there can never be changes.

TZUP-136:- Fix csv budget upload error

Bump apache-superset from 0.36.0 to 0.37.2 in /reporting/superset

Bumps [apache-superset](https://github.com/apache/superset) from 0.36.0 to 0.37.2.

- [Release notes](https://github.com/apache/superset/releases)

- [Changelog](https://github.com/apache/superset/blob/master/CHANGELOG.md)

- [Commits](https://github.com/apache/superset/compare/0.36.0...0.37.2)

Signed-off-by: dependabot[bot] <support@github.com>

OLMIS-7246: Fix missing pagination in Stock on Hand table
OLMIS-7246: Fix missing pagination in Stock on Hand table
OLMIS-7246: Fix missing pagination in Stock on Hand table

OLMIS-7246: Fix missing pagination in Stock on Hand table

Generally looks good. See my other comment.

Generally looks good. See my other comment.

This doesn't match the requirements in the JSON schema. The API requires name and code, and there is logic in the controller to enforce that, but name is not required here. The API does not require...

This doesn't match the requirements in the JSON schema. The API requires name and code, and there is logic in the controller to enforce that, but name is not required here. The API does not require isbiochemistry, iscoldchain and active, but if it is not specified the database will give an error, as I don't see where the logic gives defaults.

This doesn't seem to match the logic in the backend.

This doesn't seem to match the logic in the backend.

This is a default setting, but I believe it is set in the docker compose file.

This is a default setting, but I believe it is set in the docker compose file.