Dashboard

Probably create a new resource, like /requisitionSettings or something like that.

Probably create a new resource, like /requisitionSettings or something like that.

There are three object involved when updating a requisition, two requition domain objects and one requisition dto. The newRequisitionLineItem method in RequisitionLineItem class is building a new d...

There are three object involved when updating a requisition, two requition domain objects and one requisition dto. The newRequisitionLineItem method in RequisitionLineItem class is building a new domain object then populating it with values from the DTO. The design uses the newly created object to update an existing requisition retrieved from the db. There is one challenge though, creating a new requisition defaults the skipped value to false in newRequisitionLineItem method and if I don't check the status here before passing the dto value then it means an existing requisition can always be unskipped even after approval.

Can you give an overview of the changes here? There is a lot of code to review and the objectives don't explain it well.

Can you give an overview of the changes here? There is a lot of code to review and the objectives don't explain it well.

TZUP-163 Creation of the Health Commodities Quantification Exports
TZUP-163 Creation of the Health Commodities Quantification Exports
OLMIS-7259: Added/refactored some tests
OLMIS-7259: Added/refactored some tests
where do you suggest I put this?

where do you suggest I put this?

This doesn't look right to me. This method simply creates a line item domain object based on a DTO, so why would it care about a requisition status? If you want to deal with a skipped field, you sh...

This doesn't look right to me. This method simply creates a line item domain object based on a DTO, so why would it care about a requisition status? If you want to deal with a skipped field, you should do it somewhere else.

This should be pluralized, equipment_types

This should be pluralized, equipment_types

I have added this ; (!requisition.isApproved()) { if (requisitionLineItem.getSkipped() != null){ this.skipped = requisitionLineItem.getSkipped(); } else{ this.skipped = false; } } in Requisition...

I have added this ;
(!requisition.isApproved()) {
if (requisitionLineItem.getSkipped() != null)

Unknown macro: { this.skipped = requisitionLineItem.getSkipped(); }

else

Unknown macro: { this.skipped = false; }

}

in RequisitionLineItem class to only allow unskipping before approval status, that works for authorized status.

I have corrected this, the shouldNotSetSkippedIfRequisitionStatusIsApproved mehtod is now working as expected.

I have corrected this, the shouldNotSetSkippedIfRequisitionStatusIsApproved mehtod is now working as expected.

This makes sense

This makes sense

I am also wondering where the logic is to allow something can be unskipped if status is authorized?

I am also wondering where the logic is to allow something can be unskipped if status is authorized?

Then why does the RequisitionBuilderTest seems to set skipped when status is approved?

Then why does the RequisitionBuilderTest seems to set skipped when status is approved?

Only when AUTHORIZED, once approved there can never be changes.

Only when AUTHORIZED, once approved there can never be changes.

OLMIS-7246: Fix missing pagination in Stock on Hand table
OLMIS-7246: Fix missing pagination in Stock on Hand table