Dashboard

lgtm

lgtm

OLMIS-2038: Enhance UI select elements (WIP)

OLMIS-2195: minor fixes in RequisitionTemplateValidator and RequisitionTemplateValidatorTest

We can use never() instead. Applies to all usages.

We can use never() instead. Applies to all usages.

Move to MessageKeys

Move to MessageKeys

Move to MessageKeys

Move to MessageKeys

OLMIS-2195: Fix backend validations for Total Stockout Days and Adjusted Consumption
OLMIS-2195: Fix backend validations for Total Stockout Days and Adjusted Consumption
looks fine

looks fine

OLMIS-2195: Fix backend validations for Total Stockout Days and Adjusted Consumption

If Adjusted Consumption (Column N) is not displayed, then Total Stockout Days (Column X) is not required.

If Adjusted Consumption (N) is displayed, then Total Stockout Days (X) is Required

If Average Consumption (P) is displayed, Adjusted Consumption (N) is Required

OLMIS-1694: Remove ignored tests related to notifications and password reset, fix and unignore tests for saving users

lgtm

lgtm

OLMIS-1694: Refactor invalid/expired token message keys

we are using spring 1.3.3 in auth service which doesn't support bean mocking, i'll try bumping it

we are using spring 1.3.3 in auth service which doesn't support bean mocking, i'll try bumping it

OLMIS-1694: Minor review fixes

Maybe we could refractor those message keys to: auth.error.token.invalid auth.error.token.expired

Maybe we could refractor those message keys to:
auth.error.token.invalid
auth.error.token.expired

could not be sent

could not be sent

Why isn't this in exception package?

Why isn't this in exception package?

Why objective boolean?

Why objective boolean?

Following our convention, this method should be called import, updateFrom usually takes domain object as an agrument.

Following our convention, this method should be called import, updateFrom usually takes domain object as an agrument.

corrected

corrected

OLMIS-2143: Fixed documentation of search users endpoint

    • -2
    • +2
    /src/main/resources/api-definition.yaml