Dashboard

Welcome Message

Welcome to Atlassian Crucible with FishEye .

To report a bug or suggest a feature please raise an issue in our public JIRA.

Customize this welcome note.

Support

You are running Crucible 4.2.1 with FishEye 4.2.1 (20161109135523 2016-11-09)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Friday 22 Jun
10:48 pm

Chongsun Ahn

I would like to rename this to NotificationChannel, to indicate that it's not simply a type of message, but represents the channel through which the message is sent.

I would like to rename this to NotificationChannel, to indicate that it's not simply a type of message, but represents the channel through which the message is sent.

7:34 pm

Chongsun Ahn

Looks good to me. Will there be a review for the cross-service migration?

Looks good to me. Will there be a review for the cross-service migration?

7:33 pm

Chongsun Ahn

7:32 pm

Chongsun Ahn

Do we think it's a good idea to have random phone numbers, especially once we implement SMS notification?

Do we think it's a good idea to have random phone numbers, especially once we implement SMS notification?

5:31 pm

Chongsun Ahn and Mateusz Kwiatkowski

5:22 pm

Elias

5:21 pm

Chongsun Ahn

Is isTrue necessary? Isn't emailVerified a boolean?

Is isTrue necessary? Isn't emailVerified a boolean?

5:20 pm

Chongsun Ahn

Does this schema allow each message to have a key like "email" or "sms"?

Does this schema allow each message to have a key like "email" or "sms"?

5:16 pm

Chongsun Ahn

5:14 pm

Chongsun Ahn and Mateusz Kwiatkowski

5:14 pm

Chongsun Ahn

There are a lot of things happening here, but it's still not clear. Can this be refactored, either by putting some in descriptive helper functions, or encapsulating some of the condition checking i...

There are a lot of things happening here, but it's still not clear. Can this be refactored, either by putting some in descriptive helper functions, or encapsulating some of the condition checking in more readable terms?

5:07 pm

Chongsun Ahn

I mean why plain text vs JSON?

I mean why plain text vs JSON?

5:06 pm

Chongsun Ahn

I mean ref distro uses a Postgres 9.6 db image.

I mean ref distro uses a Postgres 9.6 db image.

5:05 pm

Elias

agreed. I have updated the tests.

agreed. I have updated the tests.

5:03 pm

Elias

OLMIS-4867: address code review feedbacks

renamed test cases for better clarity.

Options
    • -2
    • +2
    /src/order-view/order-view.controller.spec.js
5:01 pm

Chongsun Ahn

Seems like this error message doesn't quite seem to describe correctly when this constraint is violated, so it seems like we should have a separate message.

Seems like this error message doesn't quite seem to describe correctly when this constraint is violated, so it seems like we should have a separate message.

4:49 pm

Chongsun Ahn

4:45 pm

Chongsun Ahn

We might just want to say it's "request is invalid" here. We might require service-level tokens now, but that could potentially change in the future.

We might just want to say it's "request is invalid" here. We might require service-level tokens now, but that could potentially change in the future.

4:45 pm

Elias

4:44 pm

Chongsun Ahn

I thought it returns a 401 if a token is not provided.

I thought it returns a 401 if a token is not provided.

4:43 pm

Chongsun Ahn

We should make this more generic, "with provided messages."

We should make this more generic, "with provided messages."

4:40 pm

Chongsun Ahn

4:40 pm

Chongsun Ahn

So perhaps we should describe the test cases as "should show error message when server responded with OK but transfer was not complete" and "should show error message when server responded with err...

So perhaps we should describe the test cases as "should show error message when server responded with OK but transfer was not complete" and "should show error message when server responded with error message". I like these test cases to be clear because sometimes they are the best way to understand what the code is supposed to do.

4:02 pm

Jakub Kondrat

OLMIS-4963: Add a Jenkinsfile

Options
    • -0
    • +126
    /Jenkinsfile
4:01 pm

Jakub Kondrat

OLMIS-4963: Add a Jenkinsfile

Options
    • -0
    • +126
    /Jenkinsfile
4:01 pm

Jakub Kondrat

OLMIS-4963: Add a Jenkinsfile

Options
    • -0
    • +126
    /Jenkinsfile
3:59 pm

Jakub Kondrat

OLMIS-4963: Add a Jenkinsfile

Options
    • -79
    • +75
    /Jenkinsfile
3:58 pm

Jakub Kondrat

OLMIS-4963: Add a Jenkinsfile

Options
    • -0
    • +76
    /Jenkinsfile
3:58 pm

Jakub Kondrat

OLMIS-4963: Add a Jenkinsfile

Options
    • -0
    • +126
    /Jenkinsfile
3:57 pm

Jakub Kondrat

OLMIS-4963: Add a Jenkinsfile

Options
    • -0
    • +126
    /Jenkinsfile