Dashboard

handled by unique index on the database layer

handled by unique index on the database layer

handled by trigger

handled by trigger

OLMIS-6358: Adjusted create endpoint
OLMIS-6358: Adjusted create endpoint
removed

removed

OLMIS-6358: Adjusted create endpoint

    • -9
    • +18
    /src/main/resources/api-definition.yaml
OLMIS-6358: Removed setting lastUpdated in constructor (FEOLMIS-3854)

Yes. The table can contain a lot of data so adding columns and set default values could drop performance

Yes. The table can contain a lot of data so adding columns and set default values could drop performance

Is it because dropping and recreating is faster?

Is it because dropping and recreating is faster?

I wanted to separate loading csv files from services (as from demo-data directory in each service) from those which are in the demo-data repository. Just for the sake of clarity.

I wanted to separate loading csv files from services (as from demo-data directory in each service) from those which are in the demo-data repository. Just for the sake of clarity.

I don't think we should be settings this in the constructor. I might want to use this constructor in retrieval endpoints, for example Isn't doing this in PrePersist/Update annotated method enough?

I don't think we should be settings this in the constructor. I might want to use this constructor in retrieval endpoints, for example

Isn't doing this in PrePersist/Update annotated method enough?

OLMIS-6399: Fixed button label at filter component on system notifications screen
OLMIS-6399: Fixed button label at filter component on system notifications screen
OLMIS-6399: Fixed button label at filter component on system notifications screen

OLMIS-6359: Fixed unit tests for AdminSystemNotificationEditController

OLMIS-6358: Added versioning to Facility Type Approved Product resource
OLMIS-6358: Added versioning to Facility Type Approved Product resource
Why do we need to keep it in a separate file? (as opposed to eg. load_data.sql)

Why do we need to keep it in a separate file? (as opposed to eg. load_data.sql)

In the following review, I only added a new field to the FTAP resource. I will adjust endpoints in next commits and reviews. Stay tuned.

In the following review, I only added a new field to the FTAP resource. I will adjust endpoints in next commits and reviews. Stay tuned.

OLMIS-6358: Fixed NPE issue

OLMIS-6358: Fixed sonar issue

OLMIS-6358: Adjusted script to new FTAP demo data

OLMIS-6358: Added versioning to Facility Type Approved Product resource

  1. … 7 more files in changeset.
OLMIS-6399: Adjusted UI after renaming openlmis.administration.systemNotification state to...
OLMIS-6399: Adjusted UI after renaming openlmis.administration.systemNotification state to...
OLMIS-6388: Adjusted UI after renaming openlmis.administration.systemNotification state to openlmis.administration.systemNotifications