Dashboard

Welcome Message

Welcome to Atlassian Crucible with FishEye .

To report a bug or suggest a feature please raise an issue in our public JIRA.

Customize this welcome note.

Support

You are running Crucible 4.2.1 with FishEye 4.2.1 (20161109135523 2016-11-09)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Today
2 hrs ago

Klaudia Pałkowska

OLMIS-6005: Removed all tests except one

Options
    • -138
    • +0
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
2 hrs ago

Łukasz Lewczyński

OLMIS-6029: Added CONSOLIDATE_NOTIFICATIONS feature flag

Options
    • -1
    • +5
    /src/main/java/org/openlmis/referencedata/AvailableFeatures.java
3 hrs ago

Klaudia Pałkowska

OLMIS-6005: Added next test

Options
    • -0
    • +146
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
3 hrs ago

Klaudia Pałkowska

OLMIS-6005: Added next tests

Options
    • -1
    • +113
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
3 hrs ago

Klaudia Pałkowska

OLMIS-6005: Added first two tests

Options
    • -1
    • +27
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
4 hrs ago

Klaudia Pałkowska

OLMIS-6005: Temporarily removed tests

Options
    • -635
    • +1
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
4 hrs ago

Klaudia Pałkowska

OLMIS-6005: Temporarily removed the last two tests

Options
    • -61
    • +88
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
5 hrs ago

Klaudia Pałkowska

OLMIS-6005: Removed tests and re-added another one

Options
    • -73
    • +302
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
5 hrs ago

Klaudia Pałkowska

OLMIS-6005: Removed the test to investigate the issue

Options
    • -34
    • +0
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
7 hrs ago

Łukasz Lewczyński

7 hrs ago

Klaudia Pałkowska

OLMIS-6005: Removed some tests

Options
    • -271
    • +24
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
7 hrs ago

Mateusz Kwiatkowski

OLMIS-6031: added performance tests for supply lines
OLMIS-6031: added performance tests for supply lines
7 hrs ago

Mateusz Kwiatkowski

OLMIS-6031: added performance tests for supply lines

Options
    • -0
    • +82
    /performance/tests/supplyLines.yml
7 hrs ago

Klaudia Pałkowska

OLMIS-6005: Re-added one of the removed tests

Options
    • -0
    • +147
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
7 hrs ago

Klaudia Pałkowska

OLMIS-6005: Merge

Options
7 hrs ago

Klaudia Pałkowska

OLMIS-6005: Reverted removing first two tests and removed next two

Options
    • -228
    • +0
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
8 hrs ago

Klaudia Pałkowska

OLMIS-6005: Removed first two tests

Options
    • -58
    • +0
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RegularRequisitionTests.feature
8 hrs ago

Łukasz Lewczyński

1. The review is quite big because for all new classes I had to add tests to avoid sonar issues. But the main changes are in the service package when a bunch of new classes has been created based o...

1. The review is quite big because for all new classes I had to add tests to avoid sonar issues. But the main changes are in the service package when a bunch of new classes has been created based on the diagram in the ticket. Also because of comments from the previous versions of the review I had to provide additional changes.
2. Each component of spring integration has two channels: input and output. Only start and end of flow has one channel: output and input, respectively. Everything starts in NotificationToSendRetriever and ends in EmailNotificationChannelHandler. As I said before it is easier to see what happens when you open the diagram from the ticket.

In the end, I am not sure if there is an easy way to remove unnecessary changes. If you still have an issue to understand changes you could try to do this together with the diagram from the ticket.

9 hrs ago

Łukasz Lewczyński

done

done

9 hrs ago

Łukasz Lewczyński

changed

changed

9 hrs ago

Łukasz Lewczyński

changed

changed

9 hrs ago

Paulina Mironiuk and Klaudia Pałkowska

9 hrs ago

Łukasz Lewczyński

OLMIS-5971: fixed broken test

Options
    • -1
    • +1
    /src/test/java/org/openlmis/notification/web/notification/NotificationDtoValidatorTest.java
9 hrs ago

Łukasz Lewczyński

OLMIS-5971: Update test for NotificationTransformer (FEOLMIS-3638)

Options
    • -1
    • +1
    /src/main/java/org/openlmis/notification/service/NotificationChannel.java
    • -1
    • +2
    /src/test/java/org/openlmis/notification/service/NotificationTransformerTest.java
9 hrs ago

Łukasz Lewczyński

OLMIS-5971: Updated log level and message (FEOLMIS-3638)

Options
    • -1
    • +1
    /src/main/java/org/openlmis/notification/service/NotificationChannelRouter.java
    • -1
    • +1
    /src/main/java/org/openlmis/notification/service/NotificationTransformer.java
9 hrs ago

Łukasz Lewczyński

Yes, currently this class does nothing but we change that in OLMIS-6029

Yes, currently this class does nothing but we change that in OLMIS-6029

9 hrs ago

Łukasz Lewczyński and Mateusz Kwiatkowski

Tuesday 19 Feb
10:41 pm

Josh Zamor

Łukasz Lewczyński, thanks for sending this. I have two main comments: 1. The size of this review is too large and unfocused. It's difficult to grasp what is supposed to be evident and what's a WI...

Łukasz Lewczyński, thanks for sending this.

I have two main comments:

1. The size of this review is too large and unfocused. It's difficult to grasp what is supposed to be evident and what's a WIP. Next time try much smaller reviews chained together that build upon one another. Less than a dozen files, no more than 1k LOC.

2. It's not really clear what's happening in the service layer with regards to what should be a filter, what's a router, and where we'd see an aggregator. This is likely a continuation of the above.

Could you clean this up?

10:37 pm

Josh Zamor

Is this class a placeholder and a WIP? I'm confused how this filter supports a digest operation? Wouldn't we want an aggregator over a filter anyhow?

Is this class a placeholder and a WIP? I'm confused how this filter supports a digest operation? Wouldn't we want an aggregator over a filter anyhow?

8:09 pm

Chongsun Ahn

I am curious about the decision for some log statements to be errors? Some of them seem like warnings to me. Like in NotificationTransformer or NotificationChannelRouter.

I am curious about the decision for some log statements to be errors? Some of them seem like warnings to me. Like in NotificationTransformer or NotificationChannelRouter.