Dashboard

Welcome Message

Welcome to Atlassian Crucible with FishEye .

To report a bug or suggest a feature please raise an issue in our public JIRA.

Customize this welcome note.

Support

You are running Crucible 4.2.1 with FishEye 4.2.1 (20161109135523 2016-11-09)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Thursday 14 Nov
2:48 pm

Klaudia Pałkowska

Added new property for long scenario duration in performance tests

Options
    • -0
    • +1
    /performance/config.yml
    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
    • -1
    • +1
    /performance/tests/orderables.yml
1:44 pm

Paweł Pinker

OLMIS-6118: Added requisition line items data for testing purposes

Options
    • -2
    • +2
    /data/requisition.requisition_line_items.csv
10:05 am

Klaudia Pałkowska

10:04 am

Paweł Pinker , Sebastian Brudziński and Paulina Buzderewicz

10:02 am

Paweł Pinker

9:33 am

Klaudia Pałkowska

OLMIS-6566: Updated changelog

Options
    • -0
    • +1
    /CHANGELOG.md
9:25 am

Klaudia Pałkowska

OLMIS-6566: Updated test duration for getting 9000 FTAPs and searching orderables by version identities

Options
    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
    • -1
    • +1
    /performance/tests/orderables.yml
8:57 am

Sebastian Brudziński

Modified thresholds for performance tests

* FTAPs and Orderables are more restrictive now

* All Supply Lines with Expand is a little less restrictive

Options
    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
    • -2
    • +2
    /performance/tests/orderables.yml
    • -1
    • +1
    /performance/tests/supplyLines.yml
Wednesday 13 Nov
3:02 pm

Paweł Pinker

2:54 pm

Paulina Buzderewicz and Klaudia Pałkowska

2:45 pm

Paweł Pinker

All right. Did something in that manner. Thanks https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

All right. Did something in that manner. Thanks

1:34 pm

Paweł Pinker

OLMIS-6671: Introduced an additional method for better readibility

Options
    • -3
    • +7
    /src/main/java/org/openlmis/requisition/web/BatchRequisitionController.java
1:13 pm

Paulina Buzderewicz and Klaudia Pałkowska

12:38 pm

Klaudia Pałkowska

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that https://review...

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that

12:28 pm

Paulina Buzderewicz

12:18 pm

Paweł Pinker

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

12:16 pm

Paweł Pinker

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one...

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one thing I think). Could not extract it all into a separate method as Sonar wasn't allowing this.

11:37 am

Paweł Pinker

OLMIS-6671: Refactored the method in attempt to fix Sonar errors

Options
    • -3
    • +2
    /src/main/java/org/openlmis/requisition/web/BatchRequisitionController.java
11:15 am

Paweł Pinker

OLMIS-6611: Removed unnecessary method

Options
    • -10
    • +3
    /src/main/java/org/openlmis/referencedata/web/OrderableController.java
10:22 am

Sebastian Brudziński

Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?

10:13 am

Paweł Pinker

True. The method was refactored.

True. The method was refactored.

10:09 am

Paweł Pinker

OLMIS-6671: Refactored methods

Options
    • -6
    • +9
    /src/main/java/org/openlmis/requisition/web/BatchRequisitionController.java
Tuesday 12 Nov
4:19 pm

Paweł Pinker

OLMIS-6611: Refactored a method

Options
    • -7
    • +1
    /src/main/java/org/openlmis/referencedata/web/OrderableController.java
3:37 pm

Sebastian Brudziński

To improve readability we could: 1. merge this with an already existing if-statement 2. Extract this check to a separate private method

To improve readability we could:
1. merge this with an already existing if-statement
2. Extract this check to a separate private method

3:29 pm

Paweł Pinker , Klaudia Pałkowska and Sebastian Brudziński

3:25 pm

Sebastian Brudziński

Why do we need this step if we are returning null anyways?

Why do we need this step if we are returning null anyways?

3:24 pm

Paweł Pinker

3:24 pm

Paweł Pinker

OLMIS-6671: Refactoring for string literals to be on the left side of string comparisions
OLMIS-6671: Refactoring for string literals to be on the left side of string comparisions
2:41 pm

Klaudia Pałkowska

OLMIS-6566: Removed unnecessary method from OrderableRepositoryImpl

Options
    • -92
    • +0
    /src/integration-test/java/org/openlmis/referencedata/repository/OrderableRepositoryIntegrationTest.java
    • -17
    • +0
    /src/integration-test/java/org/openlmis/referencedata/web/OrderableControllerIntegrationTest.java
    • -4
    • +0
    /src/main/java/org/openlmis/referencedata/repository/custom/OrderableRepositoryCustom.java
    • -43
    • +4
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/OrderableRepositoryImpl.java
2:20 pm

Klaudia Pałkowska

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.