Dashboard

Welcome Message

Welcome to Atlassian Crucible with FishEye .

To report a bug or suggest a feature please raise an issue in our public JIRA.

Customize this welcome note.

Support

You are running Crucible 4.2.1 with FishEye 4.2.1 (20161109135523 2016-11-09)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Saturday 25 Jan
6:12 pm

Paulina Buzderewicz

I think that the reason for having this value greater than or equal was to avoid saving the Stock on hand value to the database for the same occurred date. If there was no Stock on hand value for g...

I think that the reason for having this value greater than or equal was to avoid saving the Stock on hand value to the database for the same occurred date. If there was no Stock on hand value for given occurred date it was saved to database before calculations, and then saved again after being recalculated. If there was already such a value it was only updated.
Now we are deleting these stock on hand values, so there are no two records saved for the same occurred date, just the current one.

6:12 pm

Sebastian Brudziński , Klaudia Pałkowska and Paweł Pinker

6:10 pm

Paulina Buzderewicz

OLMIS-6728 Refactored code, added changelog and tests

Options
    • -0
    • +1
    /CHANGELOG.md
    • -11
    • +53
    /src/integration-test/java/org/openlmis/stockmanagement/service/CalculatedStockOnHandServiceIntegrationTest.java
    • -20
    • +12
    /src/main/java/org/openlmis/stockmanagement/service/CalculatedStockOnHandService.java
Friday 24 Jan
6:45 pm

Paulina Buzderewicz and Paweł Pinker

4:02 pm

Klaudia Pałkowska

toDate function from dateUtils transforms dates from array/string to Date object, which is passed to the openlmisDate filter then. openlmisDate filter prepares date to be displayed in the proper fo...

toDate function from dateUtils transforms dates from array/string to Date object, which is passed to the openlmisDate filter then. openlmisDate filter prepares date to be displayed in the proper format and it's still used in the HTML (also for occurredDate or expirationDate).

3:56 pm

Paweł Pinker

So, in general, will openlmisDate filter be of any use now and in the future?

So, in general, will openlmisDate filter be of any use now and in the future?

3:53 pm

Klaudia Pałkowska

3:38 pm

Klaudia Pałkowska

OLMIS-6511: Fixed displaying lot expiration date and stock card occurred date on stockmanagement...
OLMIS-6511: Fixed displaying lot expiration date and stock card occurred date on stockmanagement...
3:36 pm

Klaudia Pałkowska

OLMIS-6511: Added missed test for stockCardService

Options
    • -1
    • +9
    /src/stock-card/stock-card-data-builder.spec.js
    • -0
    • +71
    /src/stock-card/stock-card.service.spec.js
2:47 pm

Klaudia Pałkowska

OLMIS-6511: Fixed displaying lot expiration date and stock card occurred date on stockmanagement screens

Options
    • -0
    • +3
    /CHANGELOG.md
    • -4
    • +9
    /src/stock-card-summary/stock-card-summary-repository-impl.js
    • -2
    • +3
    /src/stock-card-summary/stock-card-summary-repository-impl.spec.js
    • -1
    • +3
    /src/stock-card/stock-card-line-item-data-builder.spec.js
    • -2
    • +3
    /src/stock-card/stock-card.js
    • -3
    • +15
    /src/stock-card/stock-card.service.js
    • -0
    • +3
    /src/stock-card/stock-card.spec.js
    • -2
    • +6
    /src/stock-orderable-group/orderable-group.service.js
    • -57
    • +57
    /src/stock-orderable-group/orderable-group.service.spec.js
1:08 pm

saleksandra <soltys.ola@gmail.com>

OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

Options
    • -20
    • +20
    /src/main/java/org/openlmis/referencedata/domain/Orderable.java
    • -20
    • +18
    /src/main/java/org/openlmis/referencedata/dto/OrderableDto.java
    • -24
    • +24
    /src/main/java/org/openlmis/referencedata/util/messagekeys/OrderableMessageKeys.java
    • -39
    • +39
    /src/main/java/org/openlmis/referencedata/validate/OrderableValidator.java
    • -0
    • +15
    /src/main/resources/db/migration/20200124111526354__renamed_temperature_columns_in_orderables_table.sql
    • -7
    • +7
    /src/main/resources/messages_en.properties
    • -12
    • +12
    /src/test/java/org/openlmis/referencedata/testbuilder/OrderableDataBuilder.java
    • -24
    • +24
    /src/test/java/org/openlmis/referencedata/validate/OrderableValidatorTest.java
12:48 pm

Klaudia Pałkowska

Revert "Updated memory limits for referencedata service on perftest"

This reverts commit a0e0596107ca51d623bc37f8462a5778476769f0.

Options
    • -1
    • +1
    /deployment/perftest_env/docker-compose.yml
9:16 am

Klaudia Pałkowska

Updated memory limits for referencedata service on perftest

Options
    • -1
    • +1
    /deployment/perftest_env/docker-compose.yml
8:56 am

Klaudia Pałkowska

Revert "Reduced scenario duration to 60s for orderables search and non full supply products search"

This reverts commit 223418818159cde48306b088b7426afc06208452.

Options
    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
    • -1
    • +1
    /performance/tests/orderables.yml
Thursday 23 Jan
4:42 pm

Sebastian Brudziński

In the context of this method, those seem to be just stock on hands

In the context of this method, those seem to be just stock on hands

4:39 pm

Sebastian Brudziński

setStockOnHand can set negative value, and we should prevent this.

setStockOnHand can set negative value, and we should prevent this.

4:38 pm

Sebastian Brudziński

Can this ever be negative?

Can this ever be negative?

4:36 pm

Sebastian Brudziński

It's very inefficient that we make a call to the database with each iteration. We could somehow preserve those previous stock on hands so we don't have to retrieve them each time.

It's very inefficient that we make a call to the database with each iteration. We could somehow preserve those previous stock on hands so we don't have to retrieve them each time.

4:32 pm

Sebastian Brudziński

Why do we need to clear this list?

Why do we need to clear this list?

4:32 pm

Sebastian Brudziński

Just name it deleteStockOnHands - this method doesn't do any logic - it just deletes what it receives.

Just name it deleteStockOnHands - this method doesn't do any logic - it just deletes what it receives.

4:30 pm

Sebastian Brudziński

You don't need this if

You don't need this if

4:28 pm

Sebastian Brudziński

Why do we only use line items that are after the given occured date here, while for calculated SoHs we use both after the date and AT the given date. Won't we lose data in that case?

Why do we only use line items that are after the given occured date here, while for calculated SoHs we use both after the date and AT the given date. Won't we lose data in that case?

4:11 pm

Paulina Buzderewicz

Changelog reminder

Changelog reminder

4:11 pm

Paulina Buzderewicz

OLMIS-6728 Fixed incorrect calculation of Stock On Hand
OLMIS-6728 Fixed incorrect calculation of Stock On Hand
4:08 pm

Paulina Buzderewicz

OLMIS-6728 Fixed incorrect calculation of Stock On Hand

Options
    • -1
    • +153
    /src/integration-test/java/org/openlmis/stockmanagement/service/CalculatedStockOnHandServiceIntegrationTest.java
    • -26
    • +48
    /src/main/java/org/openlmis/stockmanagement/service/CalculatedStockOnHandService.java
Wednesday 22 Jan
3:02 pm

Mateusz Kwiatkowski

3:02 pm

Mateusz Kwiatkowski

I see that if a statement is located in StockCardSummariesService so it should be tested in this class as it should be done while writing unit tests. If you are testing it below it should be moved ...

I see that if a statement is located in StockCardSummariesService so it should be tested in this class as it should be done while writing unit tests. If you are testing it below it should be moved to another test method.

2:58 pm

Mateusz Kwiatkowski

I think it should have tests in the repository test class where you would test this method with different data and parameters. I don't see such tests. Sonar only says if code line is used while exe...

I think it should have tests in the repository test class where you would test this method with different data and parameters. I don't see such tests. Sonar only says if code line is used while executing tests, not if it is tested properly.

2:14 pm

Paweł Pinker

In StockCardRangeSummaryParamsTest.java class there are separate tests to verify if null is assigned to startDate / endDate if they're absent from parameters. Additionally I added unit tests to che...

In StockCardRangeSummaryParamsTest.java class there are separate tests to verify if null is assigned to startDate / endDate if they're absent from parameters. Additionally I added unit tests to check if a proper exception is thrown if startDate / endDate is empty.

2:13 pm

Paweł Pinker

The method is tested in StockCardSummariesServiceTest (lines 351 and below, not usued anywhere else), analogical to similar findByStockCardIdAndOccurredDateBetween. Also sonar marks this as code co...

The method is tested in StockCardSummariesServiceTest (lines 351 and below, not usued anywhere else), analogical to similar findByStockCardIdAndOccurredDateBetween. Also sonar marks this as code covered by tests. Could you give me a hint if there is more that could / should be done here?