Dashboard

Welcome Message

Welcome to Atlassian Crucible with FishEye .

To report a bug or suggest a feature please raise an issue in our public JIRA.

Customize this welcome note.

Support

You are running Crucible 4.2.1 with FishEye 4.2.1 (20161109135523 2016-11-09)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Today
29 mins ago

Paweł Albecki

sonar always shows as critical vulnerability when to field that has "password" in name is assigned some static text

sonar always shows as critical vulnerability when to field that has "password" in name is assigned some static text

31 mins ago

Paweł Albecki

fix sonar issues
fix sonar issues
40 mins ago

Paweł Albecki

add unused imports to pmd ruleset and fix some trivial sonar issues

Options
    • -0
    • +1
    /config/pmd/ruleset.xml
    • -4
    • +3
    /src/main/java/org/openlmis/auth/Application.java
    • -1
    • +1
    /src/main/java/org/openlmis/auth/domain/ClientDetails.java
    • -2
    • +0
    /src/main/java/org/openlmis/auth/domain/User.java
    • -1
    • +1
    /src/main/java/org/openlmis/auth/service/BaseCommunicationService.java
    • -4
    • +0
    /src/main/java/org/openlmis/auth/service/notification/NotificationService.java
    • -2
    • +0
    /src/main/java/org/openlmis/auth/service/referencedata/UserReferenceDataService.java
    • -2
    • +4
    /src/main/java/org/openlmis/auth/util/RequestHelper.java
    • -2
    • +4
    /src/main/java/org/openlmis/auth/web/CustomApprovalEndpoint.java
    • -1
    • +1
    /src/main/java/org/openlmis/auth/web/SpelView.java
    • -5
    • +5
    /src/main/java/org/openlmis/auth/web/UserController.java
    • -2
    • +0
    /src/test/java/org/openlmis/auth/service/ConfigurationSettingServiceTest.java
1 hr ago

Paweł Albecki

sonar issue

Options
    • -7
    • +5
    /src/main/java/org/openlmis/auth/web/UserController.java
Wednesday 20 Sep
11:48 pm

Paweł Albecki

sonar issue

Options
    • -3
    • +3
    /src/main/java/org/openlmis/notification/Application.java
11:36 pm

Paweł Albecki

no need to throw exception, empty block would work. sonar shows it as "not covered by tests".. Maybe this would be better https://projectlombok.org/api/lombok/NoArgsConstructor.html#access-- with p...

no need to throw exception, empty block would work. sonar shows it as "not covered by tests"..
Maybe this would be better https://projectlombok.org/api/lombok/NoArgsConstructor.html#access-- with private access

11:30 pm

Paweł Albecki

change & to &&

change & to &&

11:26 pm

Paweł Albecki

sonar issue

Options
    • -2
    • +1
    /src/main/java/org/openlmis/fulfillment/web/validator/FtpTransferPropertiesValidator.java
11:14 pm

Paweł Albecki

why it's better?

why it's better?

9:54 pm

Paweł Albecki

9:53 pm

Paweł Albecki

same as above

same as above

9:49 pm

Paweł Albecki

Sorry, had to reopen this. I didn't reviewed this enough before. Add your recent changes to review too.

Sorry, had to reopen this. I didn't reviewed this enough before. Add your recent changes to review too.

9:48 pm

Paweł Albecki

the description should be more clear that we search by conjunction

the description should be more clear that we search by conjunction

9:47 pm

Paweł Albecki

we should check if it's called with proper params. Tests are wrong, that's why some bug was discovered by QA, not before

we should check if it's called with proper params. Tests are wrong, that's why some bug was discovered by QA, not before

9:45 pm

Paweł Albecki

OLMIS-3179: made search catalog items restful
OLMIS-3179: made search catalog items restful
7:45 pm

brandon and Mateusz Kwiatkowski

7:45 pm

brandon

Okay, the new stuff for that all looks good.

Okay, the new stuff for that all looks good.

6:41 pm

Chongsun Ahn

I added new changes; the main thing is adding Pageable in the RequisitionRepositoryImpl. This is so we do paging in the database, and only return results specified by the client.

I added new changes; the main thing is adding Pageable in the RequisitionRepositoryImpl. This is so we do paging in the database, and only return results specified by the client.

6:22 pm

Paweł Albecki

pass params before reload state for performance

Options
    • -0
    • +9
    /src/stock-physical-inventory-draft/physical-inventory-draft.controller.js
    • -3
    • +3
    /src/stock-physical-inventory-draft/physical-inventory-draft.controller.spec.js
6:22 pm

Chongsun Ahn <cahn922@yahoo.com>

OLMIS-3187 Update repository method to do db paging

Do paging in the database, so that we do not return all results and then page at the end. This should be slightly more performant, depending on the number of results returned.

Options
    • -9
    • +10
    /src/integration-test/java/org/openlmis/requisition/repository/RequisitionRepositoryIntegrationTest.java
    • -2
    • +6
    /src/integration-test/java/org/openlmis/requisition/web/RequisitionControllerIntegrationTest.java
    • -2
    • +2
    /src/main/java/org/openlmis/requisition/repository/custom/RequisitionRepositoryCustom.java
    • -20
    • +44
    /src/main/java/org/openlmis/requisition/repository/custom/impl/RequisitionRepositoryImpl.java
    • -4
    • +6
    /src/main/java/org/openlmis/requisition/service/RequisitionService.java
    • -3
    • +3
    /src/main/java/org/openlmis/requisition/web/RequisitionController.java
    • -35
    • +33
    /src/test/java/org/openlmis/requisition/service/RequisitionServiceTest.java
5:12 pm

Chongsun Ahn

It is sort of on purpose, but now that I think about it again, I think it's worth it to do all paging in the database, instead of just paging the results returned from the database.

It is sort of on purpose, but now that I think about it again, I think it's worth it to do all paging in the database, instead of just paging the results returned from the database.

5:11 pm

Chongsun Ahn

I think I might actually make this method paginated; it seems like it's worth it for the work.

I think I might actually make this method paginated; it seems like it's worth it for the work.

4:44 pm

brandon

Okay, thanks!

Okay, thanks!

4:44 pm

Mateusz Kwiatkowski

4:34 pm

Nikodem Graczewski

Nick Reid I would say that a specific test is better than none (they have a chance to catch some bugs, and those test aren't really that specific), but I'm OK with dropping HTML tests, as we don't ...

Nick Reid I would say that a specific test is better than none (they have a chance to catch some bugs, and those test aren't really that specific), but I'm OK with dropping HTML tests, as we don't have any pattern for them. I was hoping we could keep HTML test as some kind of integration tests, but I guess we don't really want them at the moment.

4:21 pm

Nick Reid

4:20 pm

Nick Reid

Add Facility "button" ??

Add Facility "button" ??

4:20 pm

Mateusz Kwiatkowski

Hmm yea, this 'environment' looks cool, not sure how it could be implemented. Nikodem Graczewski So for now just move message declaration before confirm modal call.

Hmm yea, this 'environment' looks cool, not sure how it could be implemented.
Nikodem Graczewski So for now just move message declaration before confirm modal call.

4:18 pm

Nick Reid

These unit tests still scare the hell out of me – they feel like they are overly specific and defensive (if thats a thing) – where as good unit tests are supposed to maintain a contract and ignore ...

These unit tests still scare the hell out of me – they feel like they are overly specific and defensive (if thats a thing) – where as good unit tests are supposed to maintain a contract and ignore the inner workings of the implementation as much as possible

Are you sure this is a good practice?

4:17 pm

Mateusz Kwiatkowski

LGTM

LGTM