Dashboard

Added new property for long scenario duration in performance tests

    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
OLMIS-6118: Added requisition line items data for testing purposes

    • -2
    • +2
    /data/requisition.requisition_line_items.csv
OLMIS-6566: Updated changelog

OLMIS-6566: Updated test duration for getting 9000 FTAPs and searching orderables by version identities

    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
Modified thresholds for performance tests

* FTAPs and Orderables are more restrictive now

* All Supply Lines with Expand is a little less restrictive

    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
All right. Did something in that manner. Thanks https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

All right. Did something in that manner. Thanks

OLMIS-6671: Introduced an additional method for better readibility

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that https://review...

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one...

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one thing I think). Could not extract it all into a separate method as Sonar wasn't allowing this.

OLMIS-6671: Refactored the method in attempt to fix Sonar errors

OLMIS-6611: Removed unnecessary method

Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?

True. The method was refactored.

True. The method was refactored.

OLMIS-6671: Refactored methods

OLMIS-6611: Refactored a method

To improve readability we could: 1. merge this with an already existing if-statement 2. Extract this check to a separate private method

To improve readability we could:
1. merge this with an already existing if-statement
2. Extract this check to a separate private method

Why do we need this step if we are returning null anyways?

Why do we need this step if we are returning null anyways?

OLMIS-6671: Refactoring for string literals to be on the left side of string comparisions
OLMIS-6671: Refactoring for string literals to be on the left side of string comparisions
OLMIS-6566: Removed unnecessary method from OrderableRepositoryImpl

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.