Sebastian Brudziński

OLMIS-5445 Move version assignment further up in database migration
OLMIS-5445 Move version assignment further up in database migration
OLMIS-5445 Move version assignment further up in database migration

OLMIS-5445 Modify order of statements in Orderables migration
OLMIS-5445 Modify order of statements in Orderables migration
OLMIS-5445 Modify order of statements in Orderables migration

OLMIS-5445 Modify order of statements in Orderables migration

What about database migrations? I thought that editing jrxml files is not enough to have the report updated.

What about database migrations? I thought that editing jrxml files is not enough to have the report updated.

Still doesn't seem correct or I'm missing something. Where are we setting the value for avg consumption column? I only see setting value for total consumed quantity. Only the returned value seems t...

Still doesn't seem correct or I'm missing something. Where are we setting the value for avg consumption column? I only see setting value for total consumed quantity. Only the returned value seems to be the average consumption. Let me know if I'm wrong.

There should be other tests that invoke the constructor when testing the actual logic. We should not test constructors ourselves - this makes no sense and doesn't test anything.

There should be other tests that invoke the constructor when testing the actual logic. We should not test constructors ourselves - this makes no sense and doesn't test anything.

Why are we testing a constructor..?

Why are we testing a constructor..?

probably makes sense to mark them final

probably makes sense to mark them final

doesn't seem correct

doesn't seem correct

Do we know what is the Javers behaviour when snapshot already exists? If not, let's verify, so we can make appropriate decision. Also, I agree that exception is probably not the way to go.

Do we know what is the Javers behaviour when snapshot already exists? If not, let's verify, so we can make appropriate decision. Also, I agree that exception is probably not the way to go.

Even it works, it would be good to know what happens if we execute this anyways. Is the new entry overwriting the previous one? Is the new entry ignored?

Even it works, it would be good to know what happens if we execute this anyways. Is the new entry overwriting the previous one? Is the new entry ignored?

btw. if the bean annotated as javers audtiable does not implement the auditable interface, we may log a warn to let developers know they should make the repository implement the find snapshots meth...

btw. if the bean annotated as javers audtiable does not implement the auditable interface, we may log a warn to let developers know they should make the repository implement the find snapshots method. I guess the expectation is that all auditable repositories will implement this interface now, right?

+1, otherwise we will fail on casting

+1, otherwise we will fail on casting

Let's add a javadoc explaining what is the expactation from this method

Let's add a javadoc explaining what is the expactation from this method

Maybe some short javadoc explaining when to use this interface and why we need it would be in place?

Maybe some short javadoc explaining when to use this interface and why we need it would be in place?

Let's not assign the result of the "generateRequisition" to any variable then

Let's not assign the result of the "generateRequisition" to any variable then

This is suspicious.. should we be getting null instead of an empty page?

This is suspicious.. should we be getting null instead of an empty page?

Useless check - we create requisition object ourselves here

Useless check - we create requisition object ourselves here

Move 3.3.1 release notes to release branch

    • -0
    • +172
    /docs/source/releases/openlmis-ref-distro-v3.3.1.rst
Fix rst underlines in release notes for 3.3.1

Bump requisition and UI versions to RC2 for UAT deployments