Sebastian Brudziński

About
  • First commit 14 June 2016
  • Latest commit 13 October 2020
Last Week All Time
Commits: 0 760

Reviews

2 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sebastian Brudziński is mapped to 46 committers over 37 repositories
Username sbrudzinski is mapped to:
Wednesday 17 Feb
11:26 am

Sebastian Brudziński

Tuesday 16 Feb
4:39 pm

Sebastian Brudziński

Monday 23 Nov 2020
9:51 am

Sebastian Brudziński

Wednesday 18 Nov 2020
2:43 pm

Sebastian Brudziński

Correct, I think this should achieve what we want (edit: maybe it's worth verifying this with one repo only for starters, and then replicating to others if all works as expected)

Correct, I think this should achieve what we want (edit: maybe it's worth verifying this with one repo only for starters, and then replicating to others if all works as expected)

2:10 pm

Sebastian Brudziński

I think we don't want to run this step during releases, but we still want to have it for developer branches (i.e. run it for branches other than master). Thoughts Klaudia Pałkowska Paulina Buzderew...

I think we don't want to run this step during releases, but we still want to have it for developer branches (i.e. run it for branches other than master). Thoughts Klaudia Pałkowska Paulina Buzderewicz?

Tuesday 10 Nov 2020
4:43 pm

Sebastian Brudziński

4:43 pm

Sebastian Brudziński

Looks good to me! I only noticed one typo - left a comment

Looks good to me! I only noticed one typo - left a comment

4:37 pm

Sebastian Brudziński

extensions

extensions

Monday 09 Nov 2020
1:26 pm

Sebastian Brudziński

As in MessageKeys - we should never copy other classes/resources from the main module in the extension. If those ever change in the stockmanagement - we break/hide it here.

As in MessageKeys - we should never copy other classes/resources from the main module in the extension. If those ever change in the stockmanagement - we break/hide it here.

1:25 pm

Sebastian Brudziński

The extension module should have access to the classes from the module it extends - we shouldn't be required to copy the classes we need

The extension module should have access to the classes from the module it extends - we shouldn't be required to copy the classes we need

1:24 pm

Sebastian Brudziński

General thought - looking at those tests, at the validators, and at this examplar in general, it's very difficult to find what's the difference between the original version and the extended version...

General thought - looking at those tests, at the validators, and at this examplar in general, it's very difficult to find what's the difference between the original version and the extended version. We should go ahead and completely change those 3 validators and their names.

Some ideas:
NoneValidator - an extension that demonstrates how to switch off one validator completely (it always passes)
OnlyLoggingValidator - an extension to a validator that only prints warning but doesn't fail validation - perhaps difficult to test
NoKitsValidator - a validator that prevents the use of kits - it always fails when kits are used

In general - avoid subtle changes, but demonstrate that you can completely alter the validator

1:12 pm

Sebastian Brudziński

Why do we need this whole file?

Why do we need this whole file?

1:11 pm

Sebastian Brudziński

Why do we need this whole file?

Why do we need this whole file?

Wednesday 04 Nov 2020
11:27 am

Sebastian Brudziński

Yes - this sounds right

Yes - this sounds right

Wednesday 28 Oct 2020
8:40 am

Sebastian Brudziński

Tuesday 27 Oct 2020
9:49 am

Sebastian Brudziński

So essentially, we don't know but it works

So essentially, we don't know but it works

8:56 am

Sebastian Brudziński

It looks like the test properly covers this problem. Could you explain why this change fixes it though? And why we are using json ignore with json property? Based on javadcos it looks like json ign...

It looks like the test properly covers this problem. Could you explain why this change fixes it though? And why we are using json ignore with json property? Based on javadcos it looks like json ignore has precedence over this - https://fasterxml.github.io/jackson-annotations/javadoc/2.6/com/fasterxml/jackson/annotation/JsonProperty.Access.html

Monday 26 Oct 2020
10:46 am

Sebastian Brudziński

Tuesday 20 Oct 2020
4:35 pm

Sebastian Brudziński

We need an integration test that verifies this problem (this is DoD for each bug)

We need an integration test that verifies this problem (this is DoD for each bug)

4:33 pm

Sebastian Brudziński

4:33 pm

Sebastian Brudziński

Why is it needed?

Why is it needed?

Monday 19 Oct 2020
4:35 pm

Sebastian Brudziński

Friday 16 Oct 2020
1:15 pm

Sebastian Brudziński

None of those changes should be in our original ref-distro (but we can create alternate docker-compose with those changes)

None of those changes should be in our original ref-distro (but we can create alternate docker-compose with those changes)

1:14 pm

Sebastian Brudziński

This needs to be removed

This needs to be removed

1:14 pm

Sebastian Brudziński

Best if it wasn't referencing a specific file, but since we want to drop example-extension soon, maybe it doesn't matter

Best if it wasn't referencing a specific file, but since we want to drop example-extension soon, maybe it doesn't matter

1:12 pm

Sebastian Brudziński

This needs to be removed

This needs to be removed

Tuesday 13 Oct 2020
9:23 am

Sebastian Brudziński

OLMIS-6911 Update to SpringBoot2

Options
    • -26
    • +26
    /build.gradle
    • -1
    • +1
    /docker-compose.override.yml
    • -1
    • +1
    /docker-compose.yml
    • -1
    • +1
    /src/main/java/org/openlmis/stockmanagement/validators/TestValidator.java
9:23 am

Sebastian Brudziński

OLMIS-6911 Update to SpringBoot2

Options
    • -26
    • +26
    /build.gradle
    • -1
    • +1
    /docker-compose.override.yml
    • -1
    • +1
    /docker-compose.yml
    • -1
    • +1
    /src/main/java/org/openlmis/stockmanagement/validators/TestValidator.java
Wednesday 30 Sep 2020
9:54 am

Sebastian Brudziński

Monday 28 Sep 2020
6:28 pm

Sebastian Brudziński