Sebastian Brudziński

We should also have an annotation on the right assignment class to mark this unique constraint and to have hibernate validate it with the database

We should also have an annotation on the right assignment class to mark this unique constraint and to have hibernate validate it with the database

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

This should not be changed.

This should not be changed.

We will also need: *unique constraint on RightAssignment *migration to remove dupes

We will also need:

  • unique constraint on RightAssignment
  • migration to remove dupes
As discussed, set must be used across this class to properly prevent duplicates.

As discussed, set must be used across this class to properly prevent duplicates.

We will need to add supervisoryNodeId to the equals method of the RightAssignmentDto, or we will miss assignments for the same program but different SNs after this change to set.

We will need to add supervisoryNodeId to the equals method of the RightAssignmentDto, or we will miss assignments for the same program but different SNs after this change to set.

Paulina Mironiuk Anything else you need in this review? Can it be closed?

Paulina Mironiuk Anything else you need in this review? Can it be closed?

LGTM

LGTM

I didn't mean renaming. There's a section in this document called "UI Testing" (at the top). I was asking if we can move it there and make it a subsection of that section.

I didn't mean renaming. There's a section in this document called "UI Testing" (at the top). I was asking if we can move it there and make it a subsection of that section.

Let's make it clear here then, thanks!

Let's make it clear here then, thanks!

Let's not mention requisitions here, but auto-save in general.

Let's not mention requisitions here, but auto-save in general.

Let's not mention a specific screen, we plan to have toggles in more places.

Let's not mention a specific screen, we plan to have toggles in more places.

Is this just about dropdowns or we shouldn't be testing placement in general?

Is this just about dropdowns or we shouldn't be testing placement in general?

Maybe we could move this and make it a subsection of the "UI Testing"?

Maybe we could move this and make it a subsection of the "UI Testing"?

LGTM

LGTM

I'd also add their main purpose: checking contract between services

I'd also add their main purpose: checking contract between services

Same goes here, just disabling/enabling columns isn't really an edge case

Same goes here, just disabling/enabling columns isn't really an edge case

While I understand where are the edge cases here, it won't be obvious for everyone. Could you extend this example with something like: "changing order of the columns should not affect existing requ...

While I understand where are the edge cases here, it won't be obvious for everyone. Could you extend this example with something like: "changing order of the columns should not affect existing requisitions"

Added test case tip on verifying notifications
Added test case tip on verifying notifications
Added test case tip on verifying notifications

Added recommendation to not ask for a specific message match in expected results for OpenLMIS notifications to test cases best practices.

Maybe since our example says FTAPs, let's use FTAPs here as well.

Maybe since our example says FTAPs, let's use FTAPs here as well.

"features should be like adding reasons in reason adding test". Honestly, I'd still have no idea how to name the test.

"features should be like adding reasons in reason adding test". Honestly, I'd still have no idea how to name the test.

Since we have a separate category for contract and e2e tests, let's add this information to both of them. Moreover, add at least one example of a properly named test for contract test and for e2e t...

Since we have a separate category for contract and e2e tests, let's add this information to both of them. Moreover, add at least one example of a properly named test for contract test and for e2e test,