Sebastian Brudziński

Since you have added profiler - let's add measurements for each important step - validate, build orderable, save,

Since you have added profiler - let's add measurements for each important step - validate, build orderable, save,

This block is repeated 3 times. Extract it to a private method.

This block is repeated 3 times. Extract it to a private method.

This likely has the potential to fail randomly. Please debug this test to verify.

This likely has the potential to fail randomly. Please debug this test to verify.

OLMIS-6475 Add support for If-Modified-Since to Get Orderable by ID
OLMIS-6475 Add support for If-Modified-Since to Get Orderable by ID
OLMIS-6475 Add support for If-Modified-Since to Get Orderable by ID

The orderable endpoint that retrieves by ID now supports If-Modified-Since header as per RFC 7232.

Last-Modified header is also included with the response.

    • -0
    • +2
    /src/main/resources/api-definition.yaml
Revert "AO-365 Add support for lots and trade items. (#2)"

This reverts commit 292a249d5405d74df997fd108e9ceb729cc94e79.

Revert "AO-365 Add support for lots and trade items. (#2)"

This reverts commit 292a249d5405d74df997fd108e9ceb729cc94e79.

Or both - because someone may have renamed the reason, but the ID remained the same

Or both - because someone may have renamed the reason, but the ID remained the same

OLMIS-6434 Fix indentation and drop function after use

OLMIS-6434 Fix indentation and drop function after use

OLMIS-6434 Migrate calculated stocks on hand values

    • -0
    • +44
    /src/main/resources/db/migration/20190708140932101__populate_calculated_stocks_on_hand_table.sql
OLMIS-6434 Migrate calculated stocks on hand values

    • -0
    • +44
    /src/main/resources/db/migration/20190708140932101__populate_calculated_stocks_on_hand_table.sql
LGTM. Feel free to apply to other services

LGTM. Feel free to apply to other services

It looks to me like this single line should be enough to not trigger the reference-ui build. Aka. whenever the "when" expression returns false, the stage is not executed. Maybe there's a problem wi...

It looks to me like this single line should be enough to not trigger the reference-ui build. Aka. whenever the "when" expression returns false, the stage is not executed. Maybe there's a problem with this single line only? Looks like we may be referencing the env variable incorrectly.

Ok, thanks

Ok, thanks

Is it because dropping and recreating is faster?

Is it because dropping and recreating is faster?