Sebastian Brudziński

About
  • First commit 14 June 2016
  • Latest commit 18 February 2020
Last Week All Time
Commits: 0 688

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sebastian Brudziński is mapped to 42 committers over 30 repositories
Username sbrudzinski is mapped to:
Friday 21 Feb
9:21 am

Sebastian Brudziński

Thursday 20 Feb
2:43 pm

Sebastian Brudziński

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

2:37 pm

Sebastian Brudziński

Flyway is already mentioned in the first bullet point

Flyway is already mentioned in the first bullet point

2:36 pm

Sebastian Brudziński

have

have

2:28 pm

Sebastian Brudziński

Where do we use that? And can't we simply use max int constant from the Integer class?

Where do we use that? And can't we simply use max int constant from the Integer class?

Tuesday 18 Feb
1:50 pm

Sebastian Brudziński

1:34 pm

Sebastian Brudziński

OLMIS-6749 Fixed link in changelog

Options
    • -1
    • +1
    /CHANGELOG.md
1:31 pm

Sebastian Brudziński

OLMIS-6749 Added missing changelog

Options
    • -0
    • +1
    /CHANGELOG.md
1:29 pm

Sebastian Brudziński

OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes
OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes
12:29 pm

Sebastian Brudziński

OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes

Updating a resource should never introduce any changes in another resource other than

relationships between them. Requisition Groups update allowed changes to supervisory nodes,

morever those changes were only partial (child nodes were always cut off). This was fixed

and the RG update only allows switching the SN to another one now.

Options
    • -0
    • +6
    /src/integration-test/java/org/openlmis/referencedata/web/RequisitionGroupControllerIntegrationTest.java
    • -12
    • +3
    /src/main/java/org/openlmis/referencedata/web/RequisitionGroupController.java
Friday 07 Feb
8:09 am

Sebastian Brudziński

Thursday 06 Feb
3:40 pm

Sebastian Brudziński

Instead of retrieving the stock card summaries once for trade items/CT, and then stock card summaries again with some weird filtering, couldn't we refactor this to a single fetch that retrieves all...

Instead of retrieving the stock card summaries once for trade items/CT, and then stock card summaries again with some weird filtering, couldn't we refactor this to a single fetch that retrieves all needed stock cards?

3:34 pm

Sebastian Brudziński

What differences? What was changed? The UI or the report?

What differences? What was changed? The UI or the report?

Tuesday 04 Feb
9:07 am

Sebastian Brudziński

OLMIS-6006 Increase max heap space for reference data

Options
    • -1
    • +1
    /deployment/perftest_env/docker-compose.yml
Thursday 30 Jan
5:20 pm

Sebastian Brudziński

Restore TLS verify

Options
    • -1
    • +1
    /deployment/functional_test_env/deploy_to_env.sh
5:17 pm

Sebastian Brudziński

Disable TLS verify temporarily for functional test

Options
    • -1
    • +1
    /deployment/functional_test_env/deploy_to_env.sh
10:39 am

Sebastian Brudziński

OLMIS-6006 Give reference data more memory

Options
    • -1
    • +1
    /deployment/perftest_env/docker-compose.yml
10:20 am

Sebastian Brudziński

OLMIS-6006 Remove diagnostics from performance test server

There's often too little memory on the perf test server during automated tests - this service seems the least crucial to keep

Options
    • -12
    • +0
    /deployment/perftest_env/docker-compose.yml
Wednesday 29 Jan
8:28 am

Sebastian Brudziński

8:28 am

Sebastian Brudziński

Looks good to me!

Looks good to me!

Tuesday 28 Jan
8:35 pm

Sebastian Brudziński

We already calculate this value in saveCalculatedStockOnHand - maybe we can refactor so we don't have to calculate this again? One way would be to make "saveCalculatedStockOnHand" method return the...

We already calculate this value in saveCalculatedStockOnHand - maybe we can refactor so we don't have to calculate this again? One way would be to make "saveCalculatedStockOnHand" method return the calculated value, but perhaps you have a better idea.

8:30 pm

Sebastian Brudziński

Instead of introducing a new variable, we can simply re-use lineItemsPreviousSOH

Instead of introducing a new variable, we can simply re-use lineItemsPreviousSOH

8:28 pm

Sebastian Brudziński

Can't this whole orElseGet be replaced with just "return 0"?

Can't this whole orElseGet be replaced with just "return 0"?

8:25 pm

Sebastian Brudziński

Worth checking: Does Spring JPA repository offers a method to delete all passed entities (either list of objects or list of ids). If it did, we could run a single delete query instead of multiple f...

Worth checking: Does Spring JPA repository offers a method to delete all passed entities (either list of objects or list of ids). If it did, we could run a single delete query instead of multiple for better performance.

4:05 pm

Sebastian Brudziński

Add info on activating released version on ReadTheDocs to docs

Options
    • -0
    • +1
    /docs/source/conventions/versioningReleasing.md
10:27 am

Sebastian Brudziński

It would be also good to have a similar test that verifies what happens if there are records with the same occured date + if stock on hand would be calculated to a negative value (if we don't have ...

It would be also good to have a similar test that verifies what happens if there are records with the same occured date + if stock on hand would be calculated to a negative value (if we don't have such tests already)

10:14 am

Sebastian Brudziński

I must have missed it, but why do we call it "set" if we don't set anything?

I must have missed it, but why do we call it "set" if we don't set anything?

9:11 am

Sebastian Brudziński

Give auth service bigger memory allocation pool

Perhaps this will help with invalid tokens from services during perf tests

Options
    • -1
    • +1
    /deployment/perftest_env/docker-compose.yml
Thursday 23 Jan
4:42 pm

Sebastian Brudziński

In the context of this method, those seem to be just stock on hands

In the context of this method, those seem to be just stock on hands

4:39 pm

Sebastian Brudziński

setStockOnHand can set negative value, and we should prevent this.

setStockOnHand can set negative value, and we should prevent this.