Sebastian Brudziński

Since this needs to be repeated eight times and it looks exactly the same for each step, is there any way to extract what happens at the failure and define it in one place in the jenkinsfile?

12:21 pm

Sebastian Brudziński

More
FEOLMIS-3207
finished reviewing

1:43 pm

Sebastian Brudziński

More
d22def1
changed 1 file
master in openlmis-contract-tests

OLMIS-4930 Trying upping mem limit for some containers

- -2
- +2
/docker-compose.requisition.yml
- History
- Source
- Diff
/docker-compose.requisition.yml

6:11 pm

Sebastian Brudziński

More
69ea646
changed 1 file
master in openlmis-requisition FEOLMIS-3193

OLMIS-4768 Added CHANGELOG

- -0
- +1
/CHANGELOG.md
- History
- Source
- Diff
/CHANGELOG.md

9:13 am

Sebastian Brudziński

More
FEOLMIS-3193
started review

OLMIS-4768 Modified unique status changes check

2:58 pm

Sebastian Brudziński

More
FEOLMIS-3191
resumed reviewing

2:51 pm

Sebastian Brudziński

More
c3a7f05
changed 2 files
master in openlmis-requisition FEOLMIS-3193

OLMIS-4768 Modified unique status changes check

The previous implementation could raise false positives

in case two status changes had the same createdDate timestamp.

- -2
- +5
/src/integration-test/java/org/openlmis/requisition/repository/RequisitionRepositoryTransactionalIntegrationTest.java
- History
- Source
- Diff
/src/.../RequisitionRepositoryTransactionalIntegrationTest.java
- -0
- +20
/src/main/resources/db/migration/20180723143819484__modify_unique_status_changes.sql
- History
- Source
/src/.../20180723143819484__modify_unique_status_changes.sql

7:36 am

Sebastian Brudziński

More
FEOLMIS-3165
finished reviewing

1:11 pm

Sebastian Brudziński

More
Re: FEOLMIS-3112
replied to Josh Zamor

Using Spring's built-in Redis caching could be cool. Worth researching further and potentially replacing when we start using Redis more.

1:08 pm

Sebastian Brudziński

More
Re: FEOLMIS-3112
replied to Chongsun Ahn

I know this is a late answer~ Actually I tried starting with Spring Data Redis. 2.x couldn't be used due to lack of compatibility with Spring Boot 1.X however and I had some problem that I no longe...

I know this is a late answer~
Actually I tried starting with Spring Data Redis. 2.x couldn't be used due to lack of compatibility with Spring Boot 1.X however and I had some problem that I no longer remember with latest 1.x of Spring Data Redis...

8:39 am

Sebastian Brudziński

More
FEOLMIS-3158
finished reviewing

8:32 am

Sebastian Brudziński

More
603cc52
changed 1 file
master, nifi-registry-deployment in openlmis-deployment

Revert "OLMIS-5037: changed versions on perttest for 3.3.1 release testing"

This reverts commit ed8f87a948986edd8c6c59b972c595f0d10db3ae.

- -10
- +10
/deployment/perftest_env/.env
- History
- Source
- Diff
/deployment/perftest_env/.env

8:32 am

Sebastian Brudziński

More
3a40236
changed 1 file
master, nifi-registry-deployment in openlmis-deployment

Revert "changed reference-ui and requisition versions to patch release 3.3.1 on demo server"

This reverts commit e20687aebabbb8daccdbcc963b9c1abeb81293fd.

- -2
- +2
/deployment/demo_env/.env
- History
- Source
- Diff
/deployment/demo_env/.env

1:15 pm

Sebastian Brudziński

Simple Contract test would be awesome.

7:25 am

Sebastian Brudziński

And which test is supposed to catch this scenario (using DTOs)? I just wonder why none of the existing tests caught this and I don't really see any new one that would fail if we started using DTOs ...

And which test is supposed to catch this scenario (using DTOs)? I just wonder why none of the existing tests caught this and I don't really see any new one that would fail if we started using DTOs again.

7:01 am