Sebastian Brudziński

About
  • First commit 14 June 2016
  • Latest commit 14 November 2019
Last Week All Time
Commits: 1 669

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sebastian Brudziński is mapped to 38 committers over 30 repositories
Username sbrudzinski is mapped to:
Thursday 14 Nov
9:58 am

Sebastian Brudziński

8:57 am

Sebastian Brudziński

Modified thresholds for performance tests

* FTAPs and Orderables are more restrictive now

* All Supply Lines with Expand is a little less restrictive

Options
    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
    • -2
    • +2
    /performance/tests/orderables.yml
    • -1
    • +1
    /performance/tests/supplyLines.yml
Wednesday 13 Nov
10:22 am

Sebastian Brudziński

Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?

Tuesday 12 Nov
3:37 pm

Sebastian Brudziński

To improve readability we could: 1. merge this with an already existing if-statement 2. Extract this check to a separate private method

To improve readability we could:
1. merge this with an already existing if-statement
2. Extract this check to a separate private method

3:25 pm

Sebastian Brudziński

Why do we need this step if we are returning null anyways?

Why do we need this step if we are returning null anyways?

1:31 pm

Sebastian Brudziński

Is that still necessary?

Is that still necessary?

1:29 pm

Sebastian Brudziński

We should be using constants for all of the literals

We should be using constants for all of the literals

1:28 pm

Sebastian Brudziński

12:46 pm

Sebastian Brudziński

Can't we use the constant from the abstract class?

Can't we use the constant from the abstract class?

12:39 pm

Sebastian Brudziński

We should extract all of those literals as constants

We should extract all of those literals as constants

12:35 pm

Sebastian Brudziński

Also, +1 for splitting the common code to a separate class. Good job!

Also, +1 for splitting the common code to a separate class. Good job!

12:33 pm

Sebastian Brudziński

Instead of this essay can just say "Active flag of ProgramOrderables does no longer impact FTAP endpoints"

Instead of this essay can just say "Active flag of ProgramOrderables does no longer impact FTAP endpoints"

12:31 pm

Sebastian Brudziński

Don't mention requisitions in referencedata

Don't mention requisitions in referencedata

12:31 pm

Sebastian Brudziński

Drop "or not"

Drop "or not"

12:31 pm

Sebastian Brudziński

Can't we request a specific version?

Can't we request a specific version?

12:30 pm

Sebastian Brudziński

drop "or not"

drop "or not"

12:28 pm

Sebastian Brudziński

Why keep it here if we have that in the abstract class already?

Why keep it here if we have that in the abstract class already?

12:27 pm

Sebastian Brudziński

Let's not call this a util class if it's abstract. I'd go with IdentitiesSearchableRepository perhaps?

Let's not call this a util class if it's abstract. I'd go with IdentitiesSearchableRepository perhaps?

12:22 pm

Sebastian Brudziński

Doesn't criteria builder offer equals with ignore case? That would make the code a little easier to read

Doesn't criteria builder offer equals with ignore case? That would make the code a little easier to read

Wednesday 06 Nov
10:28 am

Sebastian Brudziński

That is not correct. Last-Modified and If-Modified-Since headers should always use GMT: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/d...

That is not correct. Last-Modified and If-Modified-Since headers should always use GMT:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since

10:27 am

Sebastian Brudziński

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT: "HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/...

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT:
"HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since

10:26 am

Sebastian Brudziński

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT: "HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/...

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT:
"HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since

Monday 04 Nov
3:56 pm

Sebastian Brudziński

In case of single field selection this is a smaller issue, but if possible yes - let's avoid native query

In case of single field selection this is a smaller issue, but if possible yes - let's avoid native query

3:55 pm

Sebastian Brudziński

Swallowing exceptions is an anti-pattern. At the very least, we should log them. In this case, it seems that we don't need to catch those exceptions at all - why are we doing this?

Swallowing exceptions is an anti-pattern. At the very least, we should log them. In this case, it seems that we don't need to catch those exceptions at all - why are we doing this?

3:54 pm

Sebastian Brudziński

Wednesday 23 Oct
9:20 am

Sebastian Brudziński

Friday 18 Oct
12:35 pm

Sebastian Brudziński

100 or 1k?

100 or 1k?

12:34 pm

Sebastian Brudziński

900 or 9k?

900 or 9k?

12:34 pm

Sebastian Brudziński

1k or 10k?

1k or 10k?

12:34 pm

Sebastian Brudziński

This will generate 9k UUIDs that do not exist in the database and ultimately we won't retrieve anything

This will generate 9k UUIDs that do not exist in the database and ultimately we won't retrieve anything