Sebastian Brudziński

Is it because dropping and recreating is faster?

Is it because dropping and recreating is faster?

I don't think we should be settings this in the constructor. I might want to use this constructor in retrieval endpoints, for example Isn't doing this in PrePersist/Update annotated method enough?

I don't think we should be settings this in the constructor. I might want to use this constructor in retrieval endpoints, for example

Isn't doing this in PrePersist/Update annotated method enough?

Why do we need to keep it in a separate file? (as opposed to eg. load_data.sql)

Why do we need to keep it in a separate file? (as opposed to eg. load_data.sql)

Hello Ian. The lack of requisitions can be caused by this bug - OLMIS-6374. Maybe this is something you can look into? If not, it will be scheduled into our next sprint.

Hello Ian. The lack of requisitions can be caused by this bug - OLMIS-6374. Maybe this is something you can look into? If not, it will be scheduled into our next sprint.

I think there are at least a few facilities removed that are used in manual tests - maybe it's worth getting feedback from Joannas on this.

I think there are at least a few facilities removed that are used in manual tests - maybe it's worth getting feedback from Joannas on this.

The prepareRequisitions part may not be required, but if you look at the save and approve endpoints, they use an additional request parameter that completely changes the behavior of this endpoint -...

The prepareRequisitions part may not be required, but if you look at the save and approve endpoints, they use an additional request parameter that completely changes the behavior of this endpoint - enables batch saving and approving. This part is not covered in regular requisition tests.

Why were half of those tests removed?

Why were half of those tests removed?

Do you know why do we even need the period name in those tests? Can't we just proceed the requisition with the only available period there?

Do you know why do we even need the period name in those tests? Can't we just proceed the requisition with the only available period there?

OLMIS-6199: Update Reason Categories to include Aggregation
OLMIS-6199: Update Reason Categories to include Aggregation
Josh Zamor The intention is to have Gradle 5 eventually, however, none of our services currently work with Gradle 5. We have reverted this back to Gradle 4 in order to be able to roll a patch relea...

Josh Zamor The intention is to have Gradle 5 eventually, however, none of our services currently work with Gradle 5. We have reverted this back to Gradle 4 in order to be able to roll a patch release that fixes translations, since there was a change in docker-dev as well.

Are those all of the changes? I only see one line changed in requisiton.yml.

Are those all of the changes? I only see one line changed in requisiton.yml.