Sebastian Brudziński

About
  • First commit 14 June 2016
  • Latest commit 18 February 2020
Last Week All Time
Commits: 0 688

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sebastian Brudziński is mapped to 36 committers over 30 repositories
Username sbrudzinski is mapped to:
Wednesday 13 May
8:19 am

Sebastian Brudziński

8:18 am

Sebastian Brudziński

Tuesday 21 Apr
2:08 pm

Sebastian Brudziński

2:01 pm

Sebastian Brudziński

Wednesday 15 Apr
7:51 am

Sebastian Brudziński

7:38 am

Sebastian Brudziński

I'd even change it to WARN

I'd even change it to WARN

7:18 am

Sebastian Brudziński

Ultimately we need covid-ui here, but I understand the image is not ready yet

Ultimately we need covid-ui here, but I understand the image is not ready yet

7:17 am

Sebastian Brudziński

Remove the ftp container

Remove the ftp container

7:15 am

Sebastian Brudziński

We should be using the stable versions

We should be using the stable versions

7:14 am

Sebastian Brudziński

Do we need that heavy logging in all of the services?

Do we need that heavy logging in all of the services?

Tuesday 31 Mar
11:01 am

Sebastian Brudziński

9:46 am

Sebastian Brudziński

8:27 am

Sebastian Brudziński

Looks good, but the CHANGELOG is missing. This changes the logic of populating the modified date so it should be explained there

Looks good, but the CHANGELOG is missing. This changes the logic of populating the modified date so it should be explained there

Monday 09 Mar
7:32 pm

Sebastian Brudziński

Thursday 05 Mar
4:40 pm

Sebastian Brudziński

Why? We explicitly created calculated stock on hands to avoid this

Why? We explicitly created calculated stock on hands to avoid this

4:13 pm

Sebastian Brudziński

4:13 pm

Sebastian Brudziński

Unnecessary implementation detail, but we can keep it

Unnecessary implementation detail, but we can keep it

4:11 pm

Sebastian Brudziński

4:10 pm

Sebastian Brudziński

Why do we still need manual recalculations?

Why do we still need manual recalculations?

4:10 pm

Sebastian Brudziński

Why aren't we using the calculated stocks on hand for this?

Why aren't we using the calculated stocks on hand for this?

4:04 pm

Sebastian Brudziński

small h

small h

Wednesday 04 Mar
3:00 pm

Sebastian Brudziński

9:23 am

Sebastian Brudziński

We shouldn't be recalculating this - the current SoH should be calculated at this point since we use calculated SoHs. Also recalculating SoHs should be long gone from the Stock Mgmt module by now.

We shouldn't be recalculating this - the current SoH should be calculated at this point since we use calculated SoHs. Also recalculating SoHs should be long gone from the Stock Mgmt module by now.

Thursday 27 Feb
2:25 pm

Sebastian Brudziński

Wednesday 26 Feb
8:45 am

Sebastian Brudziński

We could use constants from MediaType for some of the above

We could use constants from MediaType for some of the above

Friday 21 Feb
9:21 am

Sebastian Brudziński

Thursday 20 Feb
2:43 pm

Sebastian Brudziński

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

2:37 pm

Sebastian Brudziński

Flyway is already mentioned in the first bullet point

Flyway is already mentioned in the first bullet point

2:36 pm

Sebastian Brudziński

have

have

2:28 pm

Sebastian Brudziński

Where do we use that? And can't we simply use max int constant from the Integer class?

Where do we use that? And can't we simply use max int constant from the Integer class?