Sebastian Brudziński

About
  • First commit 14 June 2016
  • Latest commit 06 November 2018
Last Week All Time
Commits: 0 547

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sebastian Brudziński is mapped to 32 committers over 27 repositories
Username sbrudzinski is mapped to:
Wednesday 05 Dec
9:19 am

Sebastian Brudziński

Wednesday 21 Nov
8:09 pm

Sebastian Brudziński

Tuesday 20 Nov
4:24 pm

Sebastian Brudziński

We should also have an annotation on the right assignment class to mark this unique constraint and to have hibernate validate it with the database

We should also have an annotation on the right assignment class to mark this unique constraint and to have hibernate validate it with the database

3:47 pm

Sebastian Brudziński

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

Thanks for moving the script, but it also needs to be executed, to actually impact anything. See how openlmis-demo uses it in the compose file.

3:46 pm

Sebastian Brudziński

This should not be changed.

This should not be changed.

3:25 pm

Sebastian Brudziński

We will also need: *unique constraint on RightAssignment *migration to remove dupes

We will also need:

  • unique constraint on RightAssignment
  • migration to remove dupes
3:18 pm

Sebastian Brudziński

As discussed, set must be used across this class to properly prevent duplicates.

As discussed, set must be used across this class to properly prevent duplicates.

3:17 pm

Sebastian Brudziński

We will need to add supervisoryNodeId to the equals method of the RightAssignmentDto, or we will miss assignments for the same program but different SNs after this change to set.

We will need to add supervisoryNodeId to the equals method of the RightAssignmentDto, or we will miss assignments for the same program but different SNs after this change to set.

12:54 pm

Sebastian Brudziński

Paulina Mironiuk Anything else you need in this review? Can it be closed?

Paulina Mironiuk Anything else you need in this review? Can it be closed?

Friday 16 Nov
10:30 am

Sebastian Brudziński

LGTM

LGTM

10:24 am

Sebastian Brudziński

9:44 am

Sebastian Brudziński

I didn't mean renaming. There's a section in this document called "UI Testing" (at the top). I was asking if we can move it there and make it a subsection of that section.

I didn't mean renaming. There's a section in this document called "UI Testing" (at the top). I was asking if we can move it there and make it a subsection of that section.

9:29 am

Sebastian Brudziński

Let's make it clear here then, thanks!

Let's make it clear here then, thanks!

9:29 am

Sebastian Brudziński

Let's not mention requisitions here, but auto-save in general.

Let's not mention requisitions here, but auto-save in general.

9:28 am

Sebastian Brudziński

Let's not mention a specific screen, we plan to have toggles in more places.

Let's not mention a specific screen, we plan to have toggles in more places.

9:27 am

Sebastian Brudziński

Is this just about dropdowns or we shouldn't be testing placement in general?

Is this just about dropdowns or we shouldn't be testing placement in general?

9:26 am

Sebastian Brudziński

Maybe we could move this and make it a subsection of the "UI Testing"?

Maybe we could move this and make it a subsection of the "UI Testing"?

Wednesday 14 Nov
4:30 pm

Sebastian Brudziński

LGTM

LGTM

4:29 pm

Sebastian Brudziński

1:57 pm

Sebastian Brudziński

I'd also add their main purpose: checking contract between services

I'd also add their main purpose: checking contract between services

1:57 pm

Sebastian Brudziński

Same goes here, just disabling/enabling columns isn't really an edge case

Same goes here, just disabling/enabling columns isn't really an edge case

1:56 pm

Sebastian Brudziński

While I understand where are the edge cases here, it won't be obvious for everyone. Could you extend this example with something like: "changing order of the columns should not affect existing requ...

While I understand where are the edge cases here, it won't be obvious for everyone. Could you extend this example with something like: "changing order of the columns should not affect existing requisitions"

Wednesday 07 Nov
12:21 pm

Sebastian Brudziński

Tuesday 06 Nov
3:56 pm

Sebastian Brudziński

3:54 pm

Sebastian Brudziński

Added test case tip on verifying notifications
Added test case tip on verifying notifications
3:50 pm

Sebastian Brudziński

Added test case tip on verifying notifications

Added recommendation to not ask for a specific message match in expected results for OpenLMIS notifications to test cases best practices.

Options
    • -0
    • +2
    /TESTING.md
12:55 pm

Sebastian Brudziński

Maybe since our example says FTAPs, let's use FTAPs here as well.

Maybe since our example says FTAPs, let's use FTAPs here as well.

9:42 am

Sebastian Brudziński

9:39 am

Sebastian Brudziński

"features should be like adding reasons in reason adding test". Honestly, I'd still have no idea how to name the test.

"features should be like adding reasons in reason adding test". Honestly, I'd still have no idea how to name the test.

9:38 am

Sebastian Brudziński

Since we have a separate category for contract and e2e tests, let's add this information to both of them. Moreover, add at least one example of a properly named test for contract test and for e2e t...

Since we have a separate category for contract and e2e tests, let's add this information to both of them. Moreover, add at least one example of a properly named test for contract test and for e2e test,