Sebastian Brudziński

About
  • First commit 14 June 2016
  • Latest commit 25 September 2018
Last Week All Time
Commits: 0 536

Reviews

2 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sebastian Brudziński is mapped to 30 committers over 27 repositories
Username sbrudzinski is mapped to:
Tuesday 25 Sep
12:53 pm

Sebastian Brudziński

11:48 am

Sebastian Brudziński

OLMIS-5445 Move version assignment further up in database migration
OLMIS-5445 Move version assignment further up in database migration
11:38 am

Sebastian Brudziński

OLMIS-5445 Move version assignment further up in database migration

Options
    • -4
    • +4
    /src/main/resources/db/migration/20180821210354785__add_versions_to_orderables.sql
Monday 24 Sep
5:08 pm

Sebastian Brudziński

2:08 pm

Sebastian Brudziński

OLMIS-5445 Modify order of statements in Orderables migration
OLMIS-5445 Modify order of statements in Orderables migration
1:00 pm

Sebastian Brudziński

OLMIS-5445 Modify order of statements in Orderables migration

Options
    • -6
    • +6
    /src/main/resources/db/migration/20180821210354785__add_versions_to_orderables.sql
1:00 pm

Sebastian Brudziński

OLMIS-5445 Modify order of statements in Orderables migration

Options
    • -6
    • +6
    /src/main/resources/db/migration/20180821210354785__add_versions_to_orderables.sql
Tuesday 11 Sep
1:41 pm

Sebastian Brudziński

What about database migrations? I thought that editing jrxml files is not enough to have the report updated.

What about database migrations? I thought that editing jrxml files is not enough to have the report updated.

1:23 pm

Sebastian Brudziński

9:55 am

Sebastian Brudziński

Still doesn't seem correct or I'm missing something. Where are we setting the value for avg consumption column? I only see setting value for total consumed quantity. Only the returned value seems t...

Still doesn't seem correct or I'm missing something. Where are we setting the value for avg consumption column? I only see setting value for total consumed quantity. Only the returned value seems to be the average consumption. Let me know if I'm wrong.

9:10 am

Sebastian Brudziński

There should be other tests that invoke the constructor when testing the actual logic. We should not test constructors ourselves - this makes no sense and doesn't test anything.

There should be other tests that invoke the constructor when testing the actual logic. We should not test constructors ourselves - this makes no sense and doesn't test anything.

9:04 am

Sebastian Brudziński

Why are we testing a constructor..?

Why are we testing a constructor..?

8:49 am

Sebastian Brudziński

8:42 am

Sebastian Brudziński

probably makes sense to mark them final

probably makes sense to mark them final

8:40 am

Sebastian Brudziński

doesn't seem correct

doesn't seem correct

Wednesday 29 Aug
12:28 pm

Sebastian Brudziński

Monday 27 Aug
2:06 pm

Sebastian Brudziński

Do we know what is the Javers behaviour when snapshot already exists? If not, let's verify, so we can make appropriate decision. Also, I agree that exception is probably not the way to go.

Do we know what is the Javers behaviour when snapshot already exists? If not, let's verify, so we can make appropriate decision. Also, I agree that exception is probably not the way to go.

8:41 am

Sebastian Brudziński

Even it works, it would be good to know what happens if we execute this anyways. Is the new entry overwriting the previous one? Is the new entry ignored?

Even it works, it would be good to know what happens if we execute this anyways. Is the new entry overwriting the previous one? Is the new entry ignored?

8:38 am

Sebastian Brudziński

btw. if the bean annotated as javers audtiable does not implement the auditable interface, we may log a warn to let developers know they should make the repository implement the find snapshots meth...

btw. if the bean annotated as javers audtiable does not implement the auditable interface, we may log a warn to let developers know they should make the repository implement the find snapshots method. I guess the expectation is that all auditable repositories will implement this interface now, right?

8:36 am

Sebastian Brudziński

+1, otherwise we will fail on casting

+1, otherwise we will fail on casting

8:35 am

Sebastian Brudziński

Let's add a javadoc explaining what is the expactation from this method

Let's add a javadoc explaining what is the expactation from this method

8:34 am

Sebastian Brudziński

Maybe some short javadoc explaining when to use this interface and why we need it would be in place?

Maybe some short javadoc explaining when to use this interface and why we need it would be in place?

7:54 am

Sebastian Brudziński

Let's not assign the result of the "generateRequisition" to any variable then

Let's not assign the result of the "generateRequisition" to any variable then

7:52 am

Sebastian Brudziński

This is suspicious.. should we be getting null instead of an empty page?

This is suspicious.. should we be getting null instead of an empty page?

7:51 am

Sebastian Brudziński

Useless check - we create requisition object ourselves here

Useless check - we create requisition object ourselves here

Monday 13 Aug
8:54 am

Sebastian Brudziński

Friday 10 Aug
8:33 am

Sebastian Brudziński

Move 3.3.1 release notes to release branch

Options
    • -0
    • +1
    /docs/source/releases/index.rst
    • -0
    • +172
    /docs/source/releases/openlmis-ref-distro-v3.3.1.rst
8:29 am

Sebastian Brudziński

Fix rst underlines in release notes for 3.3.1

Options
    • -6
    • +6
    /docs/source/releases/openlmis-ref-distro-v3.3.1.rst
Wednesday 08 Aug
4:28 pm

Sebastian Brudziński

Bump requisition and UI versions to RC2 for UAT deployments

Options
    • -2
    • +2
    /deployment/uat3_env/.env
    • -2
    • +2
    /deployment/uat4_env/.env
    • -2
    • +2
    /deployment/uat_env/.env
Tuesday 31 Jul
9:02 am

Sebastian Brudziński