Sebastian Brudziński

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

Flyway is already mentioned in the first bullet point

Flyway is already mentioned in the first bullet point

have

have

Where do we use that? And can't we simply use max int constant from the Integer class?

Where do we use that? And can't we simply use max int constant from the Integer class?

OLMIS-6749 Fixed link in changelog

OLMIS-6749 Added missing changelog

OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes
OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes
OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes

Updating a resource should never introduce any changes in another resource other than

relationships between them. Requisition Groups update allowed changes to supervisory nodes,

morever those changes were only partial (child nodes were always cut off). This was fixed

and the RG update only allows switching the SN to another one now.

Instead of retrieving the stock card summaries once for trade items/CT, and then stock card summaries again with some weird filtering, couldn't we refactor this to a single fetch that retrieves all...

Instead of retrieving the stock card summaries once for trade items/CT, and then stock card summaries again with some weird filtering, couldn't we refactor this to a single fetch that retrieves all needed stock cards?

What differences? What was changed? The UI or the report?

What differences? What was changed? The UI or the report?

OLMIS-6006 Increase max heap space for reference data

Restore TLS verify

Disable TLS verify temporarily for functional test

OLMIS-6006 Give reference data more memory

OLMIS-6006 Remove diagnostics from performance test server

There's often too little memory on the perf test server during automated tests - this service seems the least crucial to keep

Looks good to me!

Looks good to me!

We already calculate this value in saveCalculatedStockOnHand - maybe we can refactor so we don't have to calculate this again? One way would be to make "saveCalculatedStockOnHand" method return the...

We already calculate this value in saveCalculatedStockOnHand - maybe we can refactor so we don't have to calculate this again? One way would be to make "saveCalculatedStockOnHand" method return the calculated value, but perhaps you have a better idea.

Instead of introducing a new variable, we can simply re-use lineItemsPreviousSOH

Instead of introducing a new variable, we can simply re-use lineItemsPreviousSOH

Can't this whole orElseGet be replaced with just "return 0"?

Can't this whole orElseGet be replaced with just "return 0"?

Worth checking: Does Spring JPA repository offers a method to delete all passed entities (either list of objects or list of ids). If it did, we could run a single delete query instead of multiple f...

Worth checking: Does Spring JPA repository offers a method to delete all passed entities (either list of objects or list of ids). If it did, we could run a single delete query instead of multiple for better performance.

Add info on activating released version on ReadTheDocs to docs

It would be also good to have a similar test that verifies what happens if there are records with the same occured date + if stock on hand would be calculated to a negative value (if we don't have ...

It would be also good to have a similar test that verifies what happens if there are records with the same occured date + if stock on hand would be calculated to a negative value (if we don't have such tests already)

I must have missed it, but why do we call it "set" if we don't set anything?

I must have missed it, but why do we call it "set" if we don't set anything?

Give auth service bigger memory allocation pool

Perhaps this will help with invalid tokens from services during perf tests

In the context of this method, those seem to be just stock on hands

In the context of this method, those seem to be just stock on hands

setStockOnHand can set negative value, and we should prevent this.

setStockOnHand can set negative value, and we should prevent this.