Paweł Nawrocki

looks good

looks good

LGTM

LGTM

Please make those class fields.

Please make those class fields.

Why is this test not in the same package as it's tested class?

Why is this test not in the same package as it's tested class?

Fixed

Fixed

OLMIS-2622: Display error and success messages for upload cce
OLMIS-2622: Display error and success messages for upload cce
Looks good

Looks good

That would not run the validation for all line items matching physical inventory.

That would not run the validation for all line items matching physical inventory.

OLMIS-2711: Fix for stockmanagement PI validations
OLMIS-2711: Fix for stockmanagement PI validations
Well, we can also have "day(s)", which I think is fair enough.

Well, we can also have "day(s)", which I think is fair enough.

Once this is resolved, please commit the same to report service.

Once this is resolved, please commit the same to report service.

Does UI assume this being GET as default? If not, we should make it required, else we'd better document that somewhere (RAML?)

Does UI assume this being GET as default? If not, we should make it required, else we'd better document that somewhere (RAML?)

We could also add $ref

We could also add $ref

"InventoryItemDtoDto" - also could use link

"InventoryItemDtoDto" - also could use link

The "days" part would fit better into the messages_en into email body.

The "days" part would fit better into the messages_en into email body.

:copparrot:

:copparrot:

So, we're taking (SELECT): *each facility - it's code, name, and type *program names: each from active supported programs for the facility *assigned roles: each role having proper right (requisit...

So, we're taking (SELECT):

  • each facility - it's code, name, and type
  • program names: each from active supported programs for the facility
  • assigned roles: each role having proper right (requisition_view, requisition_delete, etc.) and supervisory node for the facility (recursive search for parent nodes) OR assigned user's home facility being the facility itself
  • supervisory nodes: parent nodes for facility (no recursive search)


Conditions (WHERE):

  • program assignment is active
  • count of users having assigned a role with required right for supervisory node containing the facility (also, searching parents and including home facilities) is equal to 0 (no assignments)
OLMIS-2760: Additional tests for service layer, fixed permission service tests

This might be an important part from reviewer's perspective

This might be an important part from reviewer's perspective

OLMIS-2760: Added report to report service, added report service to ui config
OLMIS-2760: Added report to report service, added report service to ui config
Paweł Albecki review updated

Paweł Albecki review updated

Added report service to REPORTING_SERVICES configuration