Nick Reid

um, how so? more detail here would be useful

um, how so? more detail here would be useful

that is no longer in the scope of this ticket.

that is no longer in the scope of this ticket.

OLMIS-4026: Re-added KSS documentation
OLMIS-4026: Re-added KSS documentation
I'd be curious to know why you think we need a method to initialize....

I'd be curious to know why you think we need a method to initialize....

OLMIS-4077: Display fill orderables grouped by ordered orderables
OLMIS-4077: Display fill orderables grouped by ordered orderables
Nikodem Graczewski my worry is really for the demo, and what ever will be shown — adding pagination or virtual scrolling isn't a huge deal — and while slow page loading time might not be noticed......

Nikodem Graczewski my worry is really for the demo, and what ever will be shown — adding pagination or virtual scrolling isn't a huge deal — and while slow page loading time might not be noticed.... slow scrolling will be more obvious

I'm happy to split it out to another ticket — but its something that Josh and Mary Jo need to be aware of, so they can decide what to do

Damn I'm getting back to you about this late (sorry Nikodem Graczewski) I just realized that the config files everywhere else are JSON, so they are not actually run... I guess its not getting any...

Damn I'm getting back to you about this late (sorry Nikodem Graczewski)

I just realized that the config files everywhere else are JSON, so they are not actually run...

I guess its not getting any better than this unless we junk something large

LGTM

LGTM

I know how this page was created is probably old — but.... why do we have so many includes? If we are going to break up this page so much, wouldn't it make sense to break the table into its own sec...

I know how this page was created is probably old — but.... why do we have so many includes? If we are going to break up this page so much, wouldn't it make sense to break the table into its own section (since its so damn complicated)

I'd push us to use a single html file here

Question: I'd assume this page would use the openlmis-table-pane — ie implement virtual scrolling — since there could be a huge number of line items.... Otherwise, we should implement pagination (w...

Question: I'd assume this page would use the openlmis-table-pane — ie implement virtual scrolling — since there could be a huge number of line items.... Otherwise, we should implement pagination (which I've pushed against on these types of pages)

Which direction are we going here? It might be ok to skip this for version 3.3 — but I'd check with Mary Jo first

Josh Zamor Chongsun Ahn - do either of you have thoughts about if we should worry about page performance now or later

Yea.... this worries me too...

Yea.... this worries me too...

note: we should really be using one-way binding here

note: we should really be using one-way binding here

I'm sure we do this other places — but I don't think its super clear to use a translation string as an error string — ideally message strings wouldn't be part of the domain

I'm sure we do this other places — but I don't think its super clear to use a translation string as an error string — ideally message strings wouldn't be part of the domain

Overall this looks fine — I'm not sure how this fits into the ticket that is being worked on — so I feel like I can't comment on the design

Overall this looks fine — I'm not sure how this fits into the ticket that is being worked on — so I feel like I can't comment on the design

I'll admit I like the formatting with the colon inside the link (its actually a best practice for writing links (ie include punctuation in the link) But srsly — this is a super minor point

I'll admit I like the formatting with the colon inside the link (its actually a best practice for writing links (ie include punctuation in the link)

But srsly — this is a super minor point

Question: Is reason type required? if not, please make a secondary test.... Also – update the test name

Question: Is reason type required? if not, please make a secondary test....

Also – update the test name

Since this is late, I'll consider this optional — but since we are adding more arguments to this function, we should probably switch to an object as an argument I'm not sure how widely used this m...

Since this is late, I'll consider this optional — but since we are adding more arguments to this function, we should probably switch to an object as an argument

I'm not sure how widely used this method is, so if the level of effort is high to make the switch... I wouldn't worry about it.

FYI: Nikodem Graczewski Chongsun Ahn

looks good to me....

looks good to me....

We talked about adding this to openlmis-ui-components, right? that feels like a better home that is closer to where it is used....

We talked about adding this to openlmis-ui-components, right?

that feels like a better home that is closer to where it is used....

This is nifty Here is a weird edge case: I get the confirmation update modal click cancel close my browser then open it again.... What has happened to the OpenLMIS-UI? has the cache been cleared?...

This is nifty

Here is a weird edge case:
I get the confirmation update modal
click cancel
close my browser
then open it again....

What has happened to the OpenLMIS-UI? has the cache been cleared? Am I still logged in, but with a different version of the data?

Just curious – this is kinda a weird case, and I'm not sure what hiccups it would cause a user.....

I think there is a bootstrap class called "list-unstyled" – I think it would be more clear to apply that in the HTML, rather than have a little one off class here I really would like to avoid litt...

I think there is a bootstrap class called "list-unstyled" – I think it would be more clear to apply that in the HTML, rather than have a little one off class here

I really would like to avoid little one-off CSS classes, and shoot for greater consistency

I'd also be willing to see what happens if we make all lists unstyled (as I don't think we use that visual styling anywhere)

Thoughts??