Nikodem Graczewski

Could we have a test that would cover the case where we are doing subsequent requests with different flag setting?

Could we have a test that would cover the case where we are doing subsequent requests with different flag setting?

OLMIS-5783: Removed ObjectReferenceDataBuilder reference from production code
OLMIS-5783: Removed ObjectReferenceDataBuilder reference from production code
Could you add some comment that this is a temporary hack?

Could you add some comment that this is a temporary hack?

OLMIS-5795: Fixed a bug with calculated quantity isa being ignored when calculated quantity column is...
OLMIS-5795: Fixed a bug with calculated quantity isa being ignored when calculated quantity column is...
OLMIS-5783: Fixed a problem with facilities popover not being shown on the supply line list view
OLMIS-5783: Fixed a problem with facilities popover not being shown on the supply line list view
OLMIS-5783: Refactored unit tests to not define any desribe-scoped variables
OLMIS-5783: Refactored unit tests to not define any desribe-scoped variables
Don't we have a resource for facilities?

Don't we have a resource for facilities?

This should be changed to be a simple map in resolve.

This should be changed to be a simple map in resolve.

If you move query to the new line it would be formatted better. https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

If you move query to the new line it would be formatted better.

These feel fragile and will fail if we change anything about the column order.

These feel fragile and will fail if we change anything about the column order.

I'm not sure whether this should be changed... Perhaps we should change the And I proceed to requisition for "Kankao Health Facility" facility, "Family Planning" program and "2017Q4" period step in...

I'm not sure whether this should be changed... Perhaps we should change the And I proceed to requisition for "Kankao Health Facility" facility, "Family Planning" program and "2017Q4" period step instead?

OLMIS-5356: Made .note and gap styling more generic
OLMIS-5356: Made .note and gap styling more generic
It is set in $onInit. This is used throughout the screen to mutate it for edit/add features.

It is set in $onInit. This is used throughout the screen to mutate it for edit/add features.

OLMIS-5356: Fixed a bug with dissappearing facilities and products
OLMIS-5356: Fixed a bug with dissappearing facilities and products
OLMIS-5356: Changed the condition for when page should be reloaded when using pagination
OLMIS-5356: Changed the condition for when page should be reloaded when using pagination