Nikodem Graczewski

OLMIS-5241: Fixed broken username update
OLMIS-5241: Fixed broken username update
The title of this test suggest that we wouldn't create a requisition if it is both emergence and report only and yet I can see that we have a requisition, but non-report-only one. As per ticket it ...

The title of this test suggest that we wouldn't create a requisition if it is both emergence and report only and yet I can see that we have a requisition, but non-report-only one. As per ticket it totally makes sense, but the name is a little misleading.

OLMIS-5203: Fixed a bug with incorrect message being shown after fixing incorrect password
OLMIS-5203: Fixed a bug with incorrect message being shown after fixing incorrect password
OLMIS-5163: New requisition template columns will now default to user input whenever possible
OLMIS-5163: New requisition template columns will now default to user input whenever possible
OLMIS-5173: Fixed broken Print button on the View Proof of Delivery
OLMIS-5173: Fixed broken Print button on the View Proof of Delivery
Can't we retrieve this here?

Can't we retrieve this here?

That's correct

That's correct

OLMIS-5148: Fixed broken product grid when there is no Additional Quantity Required column in the...
OLMIS-5148: Fixed broken product grid when there is no Additional Quantity Required column in the...
Changelog?

Changelog?

Added demo data for perf users
Added demo data for perf users
OLMIS-5108: Fixed a bug with broken user edit screen when there is no user contact details
OLMIS-5108: Fixed a bug with broken user edit screen when there is no user contact details
OLMIS-5078: Fixed broken user role management screen
OLMIS-5078: Fixed broken user role management screen
What I mean is something like this private boolean isEmailDuplicated(UserContactDetailsDto dto) { EmailDetailsDto emailDetails = dto.getEmailDetails(); EmailVerificationToken existingToken...

What I mean is something like this

private boolean isEmailDuplicated(UserContactDetailsDto dto) {
    EmailDetailsDto emailDetails = dto.getEmailDetails();
    EmailVerificationToken existingToken = emailVerificationTokenRepository
        .findOneByEmailAddress(emailDetails.getEmail());


    if (null != existingToken && !existingToken.getUserContactDetails().getReferenceDataUserId()
        .equals(dto.getReferenceDataUserId())) {
      return true;
    }

    UserContactDetails existingContactDetails = repository
        .findOneByEmailAddress(emailDetails.getEmail());

    if (null != existingContactDetails
        && !existingContactDetails.getReferenceDataUserId().equals(dto.getReferenceDataUserId())) {
      return true;
    }
    
    return false;
  }
That's correct, but we could extract this logic to a separate method so we only have to call rejectValue with those parameters once.

That's correct, but we could extract this logic to a separate method so we only have to call rejectValue with those parameters once.

Could we merge those somehow?

Could we merge those somehow?

This could use some tests.

This could use some tests.

OLMIS-4535: Added an abstract state for inventory item details and status update modals
OLMIS-4535: Added an abstract state for inventory item details and status update modals
OLMIS-4404: Fixed failing integration test
OLMIS-4404: Fixed failing integration test
@Mock is perfectly fine here. These are unit tests.

@Mock is perfectly fine here. These are unit tests.

OLMIS-5033: New user will no longer be marked as inactive
OLMIS-5033: New user will no longer be marked as inactive
No changelog as this issue has been introduced after 3.3 release and is related to the user model rework.

No changelog as this issue has been introduced after 3.3 release and is related to the user model rework.

OLMIS-5099: Fixed a bug with allowing the update with duplicated email address
OLMIS-5099: Fixed a bug with allowing the update with duplicated email address