Nikodem Graczewski

Cool. The ticket number should be included in the commit title by the way. https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Cool. The ticket number should be included in the commit title by the way.

Unfortunately, I was unable to reduce any code duplication in controllers (and there is not that much duplicated code anyway).

Unfortunately, I was unable to reduce any code duplication in controllers (and there is not that much duplicated code anyway).

OLMIS-4937: Removed some code duplication for facility related templates
OLMIS-4937: Removed some code duplication for facility related templates
Adugna Worku Why are we doing this? Is this related to some ticket?

Adugna Worku Why are we doing this? Is this related to some ticket?

OLMIS-4937: Removed some code duplication for facility related templates

    • -27
    • +2
    /src/admin-facility-add/facility-add.html
    • -14
    • +1
    /src/admin-facility-view/messages_en.json
Chongsun Ahn Does the new name sounds good to you?

Chongsun Ahn Does the new name sounds good to you?

Fixed eslint issue

Restored old version of the should save requisition test

    • -42
    • +3
    /src/requisition/requisition.spec.js
Reduced payload size when synchronizing requisition
Reduced payload size when synchronizing requisition
Added test for reducing requisition size when saving

    • -3
    • +91
    /src/requisition/requisition.spec.js
Yep

Yep

Perhaps we could use the "associations" term? It was mentioned in one of the comments to the mockups.

Perhaps we could use the "associations" term? It was mentioned in one of the comments to the mockups.

This is like adding 3 lines of code at best. Would probably take more time to write the ticket for that than to fix this.

This is like adding 3 lines of code at best. Would probably take more time to write the ticket for that than to fix this.

OLMIS-4251: Updated invalid JSDoc

OLMIS-4251: Reworked unit tests for SelectProductsModalController to not define any describe-scope variables

Then that will be the point when we should make it global.

Then that will be the point when we should make it global.

It is only used in one place at the moment so we don't really need it globally (YAGNI).

It is only used in one place at the moment so we don't really need it globally (YAGNI).

Yep

Yep

That's because the dependencies are lacking some of their dependencies (this doesn't show up on the test server as we're loading those modules anyway and they are visible for every other module). T...

That's because the dependencies are lacking some of their dependencies (this doesn't show up on the test server as we're loading those modules anyway and they are visible for every other module). This is the list of dependencies that should be present:

  • admin-role-form on on admin-role-list
  • admin-role-list on openlmis-admin
  • openlmis-admin on openlmis-main-state


If those are present all we need here is the last module. The test is actually telling us that the module is using stuff that is not available to it.