Nikodem Graczewski

OLMIS-6302: Refactored unit tests to not use any describe-scoper variables
OLMIS-6302: Refactored unit tests to not use any describe-scoper variables
OLMIS-6302: Refactored unit tests to not use any describe-scoper variables

  1. … 103 more files in changeset.
Łukasz Lewczyński Do we have a changelog for this?

Łukasz Lewczyński Do we have a changelog for this?

Could we add a comment under the ticket for QA to test those places when QAing this ticket?

Could we add a comment under the ticket for QA to test those places when QAing this ticket?

What about the other case?

What about the other case?

What about some unit tests?

What about some unit tests?

Won't this change break some other parts of the OpenLMIS?

Won't this change break some other parts of the OpenLMIS?

We don't have a unit test for this.

We don't have a unit test for this.

Removed production flag for debugging purposes

Removed production flag for debugging purposes

OLMIS-6357: Updated accessTokenInterceptor to not override existing authorization token

Revert "OLMIS-6357: Fixed endless loading when trying to log while having access token cached"

This reverts commit ff5abd7160249471b431bc2158fa6b7c3c7571eb.

    • -14
    • +0
    /src/openlmis-login/login.service.spec.js
This shouldn't be exposed.

This shouldn't be exposed.

Why are removing cached data on login?

Why are removing cached data on login?

We can omit this then.

We can omit this then.

Do we have a ticket for that?

Do we have a ticket for that?

Perhaps simply openlmisCreationDetails? I could see it reused in places other than messages.

Perhaps simply openlmisCreationDetails? I could see it reused in places other than messages.

Is this component used by the requisition view?

Is this component used by the requisition view?

Could we make it flexible so that the author always shows fully but the title only occupies as much space as available?

Could we make it flexible so that the author always shows fully but the title only occupies as much space as available?

This should be translateable.

This should be translateable.

This could be a component on its own or a filter at least.

This could be a component on its own or a filter at least.

Why did we change these?

Why did we change these?