Nikodem Graczewski

Fixed eslint errors in unit tests

Added unit tests for addFullSupplyProductModalService

    • -0
    • +77
    /src/requisition-view-tab/add-full-supply-product-modal.service.spec.js
Added unit tests for addProductModalService

OLMIS-3696: Added dependency locking

    • -0
    • +5135
    /npm-shrinkwrap.json
Could we add a test for null and empty set?

Could we add a test for null and empty set?

Could we add a test for null and empty set?

Could we add a test for null and empty set?

What will happen if programIds is null? Will we fetch all the data or nothing?

What will happen if programIds is null? Will we fetch all the data or nothing?

What will happen if periodIds is null? Will we fetch all the data or nothing?

What will happen if periodIds is null? Will we fetch all the data or nothing?

Could we make this method naive? I have a feeling this method is trying to do two things at the same time - build the basic requisition but also fetch the missing data. Making all build methods res...

Could we make this method naive? I have a feeling this method is trying to do two things at the same time - build the basic requisition but also fetch the missing data. Making all build methods responsible for fetching the data would make things more consistent.

To be honest, we already had linter so we didn't add a new feature, we just improved it.

To be honest, we already had linter so we didn't add a new feature, we just improved it.

OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
Fixed issue with requisition being fetched from the local storage instead of the server when not...
Fixed issue with requisition being fetched from the local storage instead of the server when not...
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts