Nikodem Graczewski

Don't we need to start the instance somehow? I can only see stopping and waiting? Is there something missing or does the instance starts automatically?

Don't we need to start the instance somehow? I can only see stopping and waiting? Is there something missing or does the instance starts automatically?

Will this be reused anywhere? If not I guess it would make sense to keep it in the requisition.history.moda.js file. https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/sm...

Will this be reused anywhere? If not I guess it would make sense to keep it in the requisition.history.moda.js file.

Document other methods aswell https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Document other methods aswell

Could this be getTableInputSelector?

Could this be getTableInputSelector?

I mean a private method here in this class, just so it's more concise. https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

I mean a private method here in this class, just so it's more concise.

:blush:

:blush:

splitResult perhaps?

splitResult perhaps?

Shouldn't we also call it for the partner requisitions?

Shouldn't we also call it for the partner requisitions?

Perhaps move it to a isRejectable method?

Perhaps move it to a isRejectable method?

Why are we using a factory here?

Why are we using a factory here?

That's why this is related to the second condition (the one marked). We could create a wrapper just for the sake of this being more expressive.

That's why this is related to the second condition (the one marked). We could create a wrapper just for the sake of this being more expressive.

Perhaps we could call this isOriginalRequisition?

Perhaps we could call this isOriginalRequisition?

I assume we're not fetching the requisitions because of the performance, right?

I assume we're not fetching the requisitions because of the performance, right?