Mateusz Kwiatkowski

OLMIS-5666: added more logging to permission strings endpoint

I would say that ConfimationModal should be used in ViewRequsitionPage, we should just pass messages to this new class. Make confirmation modal as button etc. is done in components directory.

I would say that ConfimationModal should be used in ViewRequsitionPage, we should just pass messages to this new class. Make confirmation modal as button etc. is done in components directory.

OLMIS-5666: changed clearing assignments from assigning new collection to clear method

OLMIS-5666: changed user update method to get old user from db

hmm maybe this should be moved to ViewRequisitionPage? Łukasz Lewczyński Nikodem Graczewski

hmm maybe this should be moved to ViewRequisitionPage?
Łukasz Lewczyński Nikodem Graczewski

OLMIS-5666: fixed missing returning of saved user in user controller it

OLMIS-5666: changed user info returned after update to be from db

added additional logging in user update method

OLMIS-5666: added logging for right assignments after update

please change String type to all lowercase

please change String type to all lowercase

please add jsdocs

please add jsdocs

I think that this need translation

I think that this need translation

how about some jsdocs?

how about some jsdocs?

OLMIS-5666: removed logging from right regeneration task

OLMIS-5666: defined constant for duplicated literals

OLMIS-5666: added profiler and temporarily added logs to right assignment regeneration method

OLMIS-5616: added info about covering contract between services with tests

Is there a reason why those inputs do not have id property?

Is there a reason why those inputs do not have id property?

I would change both, also for consistency reasons as other methods start with 'with' prefix

I would change both, also for consistency reasons as other methods start with 'with' prefix

I was thinking of just adding this css direct to select2 without referencing openlmis-facility-program-select

I was thinking of just adding this css direct to select2 without referencing openlmis-facility-program-select

OLMIS-5616: added description for what should be covered by which type of tests
OLMIS-5616: added description for what should be covered by which type of tests
OLMIS-5616: added description for what should be covered by which type of tests

Still, we should have specific ticket referenced only once, please merge those 2 entries.

Still, we should have specific ticket referenced only once, please merge those 2 entries.

I think this should still be callled 'withPartnerNode'

I think this should still be callled 'withPartnerNode'