Mateusz Kwiatkowski

About
  • First commit 21 November 2016
  • Latest commit 19 November 2018
Last Week All Time
Commits: 11 4,312

Reviews

0 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Mateusz Kwiatkowski is mapped to 54 committers over 30 repositories
Username mkwiatkowski is mapped to:
Today
1 min ago

Mateusz Kwiatkowski

OLMIS-5666: added more logging to permission strings endpoint

Options
    • -0
    • +2
    /src/integration-test/java/org/openlmis/referencedata/web/UserControllerIntegrationTest.java
    • -0
    • +4
    /src/main/java/org/openlmis/referencedata/web/UserController.java
53 mins ago

Mateusz Kwiatkowski

I would say that ConfimationModal should be used in ViewRequsitionPage, we should just pass messages to this new class. Make confirmation modal as button etc. is done in components directory.

I would say that ConfimationModal should be used in ViewRequsitionPage, we should just pass messages to this new class. Make confirmation modal as button etc. is done in components directory.

1 hr ago

Mateusz Kwiatkowski

OLMIS-5666: changed clearing assignments from assigning new collection to clear method

Options
    • -2
    • +2
    /src/main/java/org/openlmis/referencedata/domain/User.java
1 hr ago

Mateusz Kwiatkowski

OLMIS-5666: changed user update method to get old user from db

Options
    • -10
    • +27
    /src/main/java/org/openlmis/referencedata/domain/User.java
    • -12
    • +17
    /src/main/java/org/openlmis/referencedata/web/UserController.java
    • -0
    • +17
    /src/test/java/org/openlmis/referencedata/domain/UserTest.java
2 hrs ago

Mateusz Kwiatkowski

hmm maybe this should be moved to ViewRequisitionPage? Łukasz Lewczyński Nikodem Graczewski

hmm maybe this should be moved to ViewRequisitionPage?
Łukasz Lewczyński Nikodem Graczewski

Friday 16 Nov
5:03 pm

Mateusz Kwiatkowski

OLMIS-5666: fixed missing returning of saved user in user controller it

Options
    • -0
    • +6
    /src/integration-test/java/org/openlmis/referencedata/web/UserControllerIntegrationTest.java
4:36 pm

Mateusz Kwiatkowski

OLMIS-5666: changed user info returned after update to be from db

added additional logging in user update method

Options
    • -6
    • +0
    /src/main/java/org/openlmis/referencedata/repository/UserRepository.java
    • -2
    • +5
    /src/main/java/org/openlmis/referencedata/web/UserController.java
    • -1
    • +3
    /src/test/java/org/openlmis/referencedata/web/UserControllerTest.java
2:11 pm

Mateusz Kwiatkowski

OLMIS-5666: added logging for right assignments after update

Options
    • -2
    • +1
    /src/main/java/org/openlmis/referencedata/domain/User.java
    • -0
    • +3
    /src/main/java/org/openlmis/referencedata/web/UserController.java
12:49 pm

Mateusz Kwiatkowski

please change String type to all lowercase

please change String type to all lowercase

Thursday 15 Nov
4:12 pm

Mateusz Kwiatkowski

please add jsdocs

please add jsdocs

4:10 pm

Mateusz Kwiatkowski

I think that this need translation

I think that this need translation

4:08 pm

Mateusz Kwiatkowski

how about some jsdocs?

how about some jsdocs?

1:27 pm

Mateusz Kwiatkowski

OLMIS-5666: removed logging from right regeneration task

Options
    • -14
    • +0
    /src/main/java/org/openlmis/referencedata/service/RightAssignmentService.java
1:15 pm

Mateusz Kwiatkowski

10:47 am

Mateusz Kwiatkowski

OLMIS-5666: defined constant for duplicated literals

Options
    • -6
    • +8
    /src/main/java/org/openlmis/referencedata/service/RightAssignmentService.java
10:40 am

Mateusz Kwiatkowski

10:38 am

Mateusz Kwiatkowski

9:59 am

Mateusz Kwiatkowski

OLMIS-5666: added profiler and temporarily added logs to right assignment regeneration method

Options
    • -2
    • +22
    /src/main/java/org/openlmis/referencedata/service/RightAssignmentService.java
Wednesday 14 Nov
4:32 pm

Mateusz Kwiatkowski

3:39 pm

Mateusz Kwiatkowski

OLMIS-5616: added info about covering contract between services with tests

Options
    • -2
    • +7
    /TESTING.md
12:56 pm

Mateusz Kwiatkowski

Is there a reason why those inputs do not have id property?

Is there a reason why those inputs do not have id property?

12:54 pm

Mateusz Kwiatkowski

I would change both, also for consistency reasons as other methods start with 'with' prefix

I would change both, also for consistency reasons as other methods start with 'with' prefix

12:17 pm

Mateusz Kwiatkowski

10:38 am

Mateusz Kwiatkowski

10:25 am

Mateusz Kwiatkowski

I was thinking of just adding this css direct to select2 without referencing openlmis-facility-program-select

I was thinking of just adding this css direct to select2 without referencing openlmis-facility-program-select

10:23 am

Mateusz Kwiatkowski

9:51 am

Mateusz Kwiatkowski

OLMIS-5616: added description for what should be covered by which type of tests
OLMIS-5616: added description for what should be covered by which type of tests
Tuesday 13 Nov
11:44 pm

Mateusz Kwiatkowski

OLMIS-5616: added description for what should be covered by which type of tests

Options
    • -2
    • +51
    /TESTING.md
4:13 pm

Mateusz Kwiatkowski

Still, we should have specific ticket referenced only once, please merge those 2 entries.

Still, we should have specific ticket referenced only once, please merge those 2 entries.

2:34 pm

Mateusz Kwiatkowski

I think this should still be callled 'withPartnerNode'

I think this should still be callled 'withPartnerNode'