Mateusz Kwiatkowski

Added info about upgrading Stock Management service from 4.0.1

Merge pull request #3 from OpenLMIS/OLMIS-6328

OLMIS-6328: Removed unnecessary call to /orderableFullfils

OLMIS-6335: added changelog entry

OLMIS-6304: added changelog entry

OLMIS-6332: added changelog entry

OLMIS-6315: added changelog entry

Merge pull request #7 from OpenLMIS/AO-137

OLMIS-6335: Added profiling for StockCardSummariesService

Merge pull request #8 from dserkowski/OLMIS-6304

OLMIS-6304: Fixed full names that were not displayed on the stock-managment reports

OLMIS-6315: moved translating statuses for filter from to html

OLMIS-6315: moved translating statuses for filter from to html

OLMIS-6315: added requisition status filter

    • -0
    • +1
    /src/requisition-search/messages_en.json
OLMIS-6315: added requisition status filter

    • -0
    • +1
    /src/requisition-search/messages_en.json
OLMIS-6193: removed async from email verification notifier

removed contract test and sonar analysis stages

OLMIS-6193: added changelog

removed dependencyCheckAnalyze task

OLMIS-6193: fixed translating stockout notifications
OLMIS-6193: fixed translating stockout notifications
OLMIS-6193: added changelog

OLMIS-6193: added changelog

OLMIS-6193: fixed translating stockout notifications

OLMIS-6193: added passing locale to requisition status processor

this should fix problem with translating email notifications for status changes

  1. … 6 more files in changeset.
OLMIS-6193: added passing locale to requisition status processor

this should fix problem with translating email notifications for status changes

  1. … 5 more files in changeset.
As I mentioned on Slack while doing using a @Async new thread is losing context by default. We are getting locale info from LocaleContextHolder while translating messages so this was causing missin...

As I mentioned on Slack while doing using a @Async new thread is losing context by default. We are getting locale info from LocaleContextHolder while translating messages so this was causing missing translations for email notifications. Here is a GitHub issue regarding this problem: https://github.com/spring-projects/spring-boot/issues/14079
I think we are safe to use "dispatcherServlet.setThreadContextInheritable(true);" but Javadoc says:
/**

  • Set whether to expose the LocaleContext and RequestAttributes as inheritable
  • for child threads (using an
    Unknown macro: {@link java.lang.InheritableThreadLocal}

    ).

  • <p>Default is "false", to avoid side effects on spawned background threads.
  • Switch this to "true" to enable inheritance for custom child threads which
  • are spawned during request processing and only used for this request
  • (that is, ending after their initial task, without reuse of the thread).
  • <p><b>WARNING:</b> Do not use inheritance for child threads if you are
  • accessing a thread pool which is configured to potentially add new threads
  • on demand (e.g. a JDK
    Unknown macro: {@link java.util.concurrent.ThreadPoolExecutor}

    ),

  • since this will expose the inherited context to such a pooled thread.
    */
    Alternatively, we could retrieve locale before starting a new thread and passing it there, but it would require more work.
    I would be nice if we could agree on a solution quickly as it is blocking release and I still need to include it in patch release for Angola. Also, I would need to include those changes in other services that are sending notifications asynchronously.
OLMIS-6193: added inheriting context to dispatcher servlet
OLMIS-6193: added inheriting context to dispatcher servlet
OLMIS-6193: added inheriting context to dispatcher servlet