Mateusz Kwiatkowski

Revert "OLMIS-6793: added new commodity for Family Planning program"

This reverts commit dda7758528e6c8d30781959b688afc5106c8cfc3.

OLMIS-6793: added new commodity for Family Planning program

with additional ISA for Comfort Health Clinic

Merge pull request #18 from OpenLMIS/OLMIS-6793

OLMIS-6793: removed calculated order quantity ISA validation

OLMIS-6793: added missing changelog

OLMIS-6793: removed validation for calculated order quantity ISA

OLMIS-6793: added missing changelog

OLMIS-6793: removed calculated order quantity ISA validation

OLMIS-6793: removed validation for calculated order quantity ISA

OMIS-6740: added changelog

OLMIS-6740: fixed wrapping text in modal body

OLMIS-6740: fixed wrapping text in modal body

OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

    • -0
    • +15
    /src/main/resources/db/migration/20200124111526354__renamed_temperature_columns_in_orderables_table.sql
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

    • -0
    • +15
    /src/main/resources/db/migration/20200124111526354__renamed_temperature_columns_in_orderables_table.sql
I see that if a statement is located in StockCardSummariesService so it should be tested in this class as it should be done while writing unit tests. If you are testing it below it should be moved ...

I see that if a statement is located in StockCardSummariesService so it should be tested in this class as it should be done while writing unit tests. If you are testing it below it should be moved to another test method.

I think it should have tests in the repository test class where you would test this method with different data and parameters. I don't see such tests. Sonar only says if code line is used while exe...

I think it should have tests in the repository test class where you would test this method with different data and parameters. I don't see such tests. Sonar only says if code line is used while executing tests, not if it is tested properly.

I'm not sure why there is no separate test to verify if empty startDate is handled properly

I'm not sure why there is no separate test to verify if empty startDate is handled properly

This requires some tests

This requires some tests

changed CCE version to new SNAPSHOT

changed CCE service version to new SNAPSHOT

changed CCE service version to new SNAPSHOT

changed version to new patch version SNAPSHOT

released 1.2.0 version of CCE service

changed CCE service version to 1.2.0-SNAPSHOT

OLMIS-6734: changed version to new minor

temporarily switched referencedata version back to previous one

changed referencedata version to new patch