Mikołaj Bas

OLMIS-1599 - Port the Swagger fix from requisitions to other services

OLMIS-1599 - Port the Swagger fix from requisitions to other services

OLMIS-1599 - Port the Swagger fix from requisitions to other services

OLMIS-1599 - Port the Swagger fix from requisitions to other services

OLMIS-1599 - Port the Swagger fix from requisitions to other services

OLMIS-1599 - Port the Swagger fix from requisitions to other services

OLMIS-1599 - Port the Swagger fix from requisitions to other services

Revert "OLMIS-1413 - Change BooleanResultDto in Requisition Service to use generics"

This reverts commit 596d685ed71d8122f1ea0dc708e38f5487f74a8c.

Revert "OLMIS-1413 Add missing Dto class"

This reverts commit f11ff3ad9c39d70ed68cfd7f2b15cbe1148f56d5.

OLMIS-1413 Add missing Dto class
OLMIS-1413 Add missing Dto class
I cannot just write ResultDto<Boolen>.class java generics dont support that, so i choose this workaround

I cannot just write ResultDto<Boolen>.class java generics dont support that, so i choose this workaround

OLMIS-1413 Add missing Dto class

    • -0
    • +12
    /src/main/java/org/openlmis/requisition/dto/ResultDto.java
OLMIS-1413 - Change BooleanResultDto in Requisition Service to use generics

FEOLMIS-759 OLMIS-1456 Remove code repetition in BaseController

No method for building error response with arguments existed so I've added it

No method for building error response with arguments existed so I've added it

OLMIS-1465 Passing message key instead of message content in buildErrorResponse

Will be resolved inFEOLMIS-767

Will be resolved inFEOLMIS-767

FEOLMIS-759 FEOLMIs-759 OLMIS-1465 Change error respone to use ErrorResponse class

    • -2
    • +4
    /src/main/resources/api-definition.yaml
OLMIS-1465 Fix checkstyle

I'm guessing that You want more than creating new method in requistionService with just 2 lines of code. If i would start to move more code from that method to RequsitionService or Requsition Domai...

I'm guessing that You want more than creating new method in requistionService with just 2 lines of code. If i would start to move more code from that method to RequsitionService or Requsition Domain class it will be neccessary to do refactor for other methods in this class (they use same helper methods). It looks like bigger refactor. I can do this as part o this ticket but IMO it would be better if this goes into seperate one. Sebastian Brudziński What do You think?

FEOLMIS-759 OLMIS-1465: Fix typos, add new test asserts

OLMIS-1465 FEOLMIS-759: Improve eror handling, add missing test cases, fix raml.

    • -0
    • +8
    /src/main/resources/api-definition.yaml
I added assertion in RequisitionControllerTest: https://review.openlmis.org/cru/#FEOLMIS-759CFR-16377

I added assertion in RequisitionControllerTest: https://review.openlmis.org/cru/#FEOLMIS-759CFR-16377

OLMIS-1465 Add new endpoint for searching supervisoryNode by requsitionGroup program and facility
OLMIS-1465 Add new endpoint for searching supervisoryNode by requsitionGroup program and facility
changed because of infinite dependency between supervisoryNode and children which cause stackoverflow error

changed because of infinite dependency between supervisoryNode and children which cause stackoverflow error

My point in adding those connectins was that in bussiness scenario supervisory node should be assigned to every facility & program (am I right ?) so I update DD to reflect that.

My point in adding those connectins was that in bussiness scenario supervisory node should be assigned to every facility & program (am I right ?) so I update DD to reflect that.

OLMIS-1465 Newly created requisitions are not associated with a supervisory node

    • -2
    • +0
    /demo-data/requisition.requisitions.json