Łukasz Lewczyński

OLMIS-5467: added logger for flyway migrations

OLMIS-5142: Improve requisition split feature
OLMIS-5142: Improve requisition split feature
OLMIS-5142: Put null values instead of zeros in line items

OLMIS-5142: Added error message for requisition duplication error

OLMIS-5142: Fixed issue with transient value in RequisitionPermissionString

OLMIS-5142: Update functional tests after adding new demo data

so in selector method we check if element is visible, yes?

so in selector method we check if element is visible, yes?

Can we move this out of the definition of the function? If I understand correctly each time when I will use it a new array will be created.

Can we move this out of the definition of the function? If I understand correctly each time when I will use it a new array will be created.

Did I miss something? I mean we create a new object of the given type but we don't execute any method. Also in class constructor I don't see any checks

Did I miss something? I mean we create a new object of the given type but we don't execute any method. Also in class constructor I don't see any checks

Can we use ImmutableList.of instead of the builder (for all cases)?

Can we use ImmutableList.of instead of the builder (for all cases)?

check line 58 in this file https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

check line 58 in this file

done

done

modified

modified