Łukasz Lewczyński

OLMIS-6066: Upgrade gradle to 5.2.1 and spring boot to 2.1.1

OLMIS-6066: Upgrade gradle to 5.2+ version

OLMIS-6066: Upgrade HAPI FHIR to 3.7.0 and use R4 structure

OLMIS-6066: Added database migrations

OLMIS-6066: Resolved compilation issues

OLMIS-6066: Format package.json and add package-lock.json

    • -0
    • +1084
    /package-lock.json
should not we put the SUPPLY_LINES_EXPAND value to some constant field?

should not we put the SUPPLY_LINES_EXPAND value to some constant field?

why we return empty map?

why we return empty map?

Great work but we still should have separate interfaces for each resource (in the same way as we do for regular repositories) even if those interfaces will be empty

Great work but we still should have separate interfaces for each resource (in the same way as we do for regular repositories) even if those interfaces will be empty

Is it possible to move here common tests to verify save, findById or exists method? We did something similar in regular repository integration tests

Is it possible to move here common tests to verify save, findById or exists method? We did something similar in regular repository integration tests

I think methods could be also moved to the parent class. Maybe the parent class should be generic?

I think methods could be also moved to the parent class. Maybe the parent class should be generic?

One more thing. I am not sure if this should be done in this ticket or should we have a new one but I should be able to control cache with the Cache-Control header.

One more thing. I am not sure if this should be done in this ticket or should we have a new one but I should be able to control cache with the Cache-Control header.

should not we remove SN from redis as well?

should not we remove SN from redis as well?

can we use spring repository classes like CrudRepository?

can we use spring repository classes like CrudRepository?

I don't like this one. Why we return a map? why key and value types are Object? what is presented by key and value?

I don't like this one. Why we return a map? why key and value types are Object? what is presented by key and value?

do we really need to inform that data are in cache? why not simply exists?

do we really need to inform that data are in cache? why not simply exists?

Same here.

Same here.

I see a lot of code duplication between this class and SN. Please create a base class to avoid duplication

I see a lot of code duplication between this class and SN. Please create a base class to avoid duplication

I think it would be good to create a base class here so in case if we add more redis repositories we would not need to duplicate code.

I think it would be good to create a base class here so in case if we add more redis repositories we would not need to duplicate code.

please use data builder

please use data builder

OLMIS-6085: Fixed issue with rendering new line in digest notifications

Please add repository integration test to make sure that everything works correctly

Please add repository integration test to make sure that everything works correctly