Łukasz Lewczyński

Elias I still see template in some places like: ResourceServerSecurityConfiguration, VersionController

Elias I still see template in some places like: ResourceServerSecurityConfiguration, VersionController

I removed the field and related classes.

I removed the field and related classes.

I removed the field and related classes.

I removed the field and related classes.

OLMIS-5384: Removed unnecessary FHIR code

For now, we will only support DSTU3 version of FHIR server and we assume

that clients are using our implementation of FHIR server which

is only configured to support DSTU3. Also, mCSD is a profile of DSTU3 and

it is not supported on anything below DSTU3.

  1. … 15 more files in changeset.
OLMIS-5384: Added authorization options for FHIR client
OLMIS-5384: Added authorization options for FHIR client
Same here. I am not sure if we should support other modes than generate a token (aka use tokens from the auth service). If the service should always use our HAPI FHIR server then we probably could ...

Same here. I am not sure if we should support other modes than generate a token (aka use tokens from the auth service). If the service should always use our HAPI FHIR server then we probably could remove other options. Am I right?

I am not sure if we need to handle all versions. If the service should always use our HAPI FHIR server then we probably could remove other options. Am I right?

I am not sure if we need to handle all versions. If the service should always use our HAPI FHIR server then we probably could remove other options. Am I right?

so from now, we don't have to check if field as a value? Same for below fields

so from now, we don't have to check if field as a value? Same for below fields

OLMIS-5384: Added authorization options for FHIR client

OLMIS-5226: Fixed problem with handling sorting by oldest authorized
OLMIS-5226: Fixed problem with handling sorting by oldest authorized
OLMIS-5226: Fixed problem with handling sorting by oldest authorized

I am going to resolve this comment and put that information in the ticket for QA to verify that this case is handled properly.

I am going to resolve this comment and put that information in the ticket for QA to verify that this case is handled properly.

OLMIS-5226: Renamed integration tests

We use this method when we generate a requisition and it always has initiated status but in some tests, we change the status in the requisition but we don't add necessary status changes - probably ...

We use this method when we generate a requisition and it always has initiated status but in some tests, we change the status in the requisition but we don't add necessary status changes - probably because we don't always need them. I created this method so if there is a need to add/update/modify status changes in the given requisition you can simply do that by executing the method.

do we return the same value twice?

do we return the same value twice?

from sonar: Immediately return this expression instead of assigning it to the temporary variable "extraProperties".

from sonar: Immediately return this expression instead of assigning it to the temporary variable "extraProperties".

could you give this explanation in the file as a comment?

could you give this explanation in the file as a comment?

maybe it would be good to leave a comment why we use the given version

maybe it would be good to leave a comment why we use the given version

Do we need to fix something in the auth service? I know it looks for available services and updates data so all services are visible by the auth service

Do we need to fix something in the auth service? I know it looks for available services and updates data so all services are visible by the auth service

please, update the following properties

please, update the following properties

do we need those two entries? I thought they are transitive dependencies for spring library

do we need those two entries? I thought they are transitive dependencies for spring library