Josh Zamor

OLMIS-5603, update uat3 and 4 to latest 3.5 snapshots.

    • -37
    • +24
    /deployment/uat3_env/docker-compose.yml
    • -37
    • +24
    /deployment/uat4_env/docker-compose.yml
OLMIS-5603, fix docker daemon issue.

This is a well known issue so not sure why this worked before in this script, however this time it became a blocker. Our documentation is at: https://openlmis.atlassian.net/wiki/x/8o-hBg

I see that most of the changes have been made aside from the first one: "Given I am logged in as a service-client". Is that one difficult or is it simply a WIP?

I see that most of the changes have been made aside from the first one: "Given I am logged in as a service-client". Is that one difficult or is it simply a WIP?

I think the more-right solution is the first one. The second one likely is okay. The last is not desirable at all.

I think the more-right solution is the first one. The second one likely is okay. The last is not desirable at all.

Looking good Elias, left a couple comments. Thanks.

Looking good Elias, left a couple comments. Thanks.

Ah, got it, thanks.

Ah, got it, thanks.

Is this important? I don't see that bearer token in the steps so I'm confused where that one came from?

Is this important? I don't see that bearer token in the steps so I'm confused where that one came from?

Appears as if this Location UUID could be extracted (used 3 times)

Appears as if this Location UUID could be extracted (used 3 times)

Great to see wiremock in use here. Should the version here follow the format of the other services?

Great to see wiremock in use here.

Should the version here follow the format of the other services?

Great change to make this more BDD!

Great change to make this more BDD!

I understand this is outside the review, however I can see it so I'd recommend we make this more clear: "I am not logged in". This is minor.

I understand this is outside the review, however I can see it so I'd recommend we make this more clear: "I am not logged in".

This is minor.

The Given, When, Then isn't clearly identifiable, and we also see a bit too much technical detail here when we say "I stub a mock server". If possible I'd attempt to make this more focused on BDD'...

The Given, When, Then isn't clearly identifiable, and we also see a bit too much technical detail here when we say "I stub a mock server".

If possible I'd attempt to make this more focused on BDD's Given, When, Then: https://martinfowler.com/bliki/GivenWhenThen.html

Perhaps that'd read as:

  • Given I am logged in as a service client
  • And I have an upstream FHIR server
  • When my upstream FHIR server subscribes to Location updates with the OpenLMIS FHIR Service
    <JSON here>
  • And I update an OpenLMIS Location
  • Then after I pause for 30 seconds
  • And I verify that my Upstream FHIR Server has received a notification of a Location change
    <JSON here>


I think this is easier to read and will result in a more maintainable test over time.

OLMIS-5650, fix missing live docs

This isn't ideal as this appears unnecessary, however this will solve this issue for now.

OLMIS-5650, fix checkApiIsRaml task

OLMIS-5650, add OWASP dependency check in Gradle and Jenkins

OLMIS-5650, add OWASP security check and ben manes version check.

OLMIS-5650, upgrade npm plugin, remove dead gradle.

Removed a number of unused or duplicative declarations. NPM module upgrade lead to a more concise form to call package.json script, and a tidy inprovement to performance.

Received feedback in Slack that message is improved, closing.

Received feedback in Slack that message is improved, closing.

OLMIS-5650, enable test tasks to be run from gradle outside of docker.

Gradle plugin for docker-compose is added so that if test or integrationTest tasks are run when not in the development container, that needed services (redis, log, db) are started and the published ports may be discovered by those tasks.

Except for log's UDP port which at the moment isn't discoverable with the plugin: https://github.com/avast/gradle-docker-compose-plugin/issues/176

OLMIS-5663: Describe what a permission string gives you in API docs
OLMIS-5663: Describe what a permission string gives you in API docs
OLMIS-5663, update permission string's doc with usage information.

    • -1
    • +14
    /src/main/resources/api-definition.yaml
OLMIS-5650, add gradle wrapper

OLMIS-5650, update raml2html and use relative file paths

Merge branch 'OLMIS-5493-togglz'

OLMIS-5492, switch db image to one that supports debezium.

OLMIS-5492, switch postgres base image to debezium's postgres.

Both of these images are based off of the official postgres 9.6 image and both have postgis. The debezium image however is based off of alpine and includes the needed configuration and driver so that the debezium connector may connect to it.

eOLMIS-5492, add Debezium (round 2) for CDC of Programs.

Hope no one sees this, I forgot to push the new files :D

    • -0
    • +8
    /reporting/debezium-console.sh
    • -0
    • +3
    /reporting/debezium-referencedata-start.sh
    • -0
    • +16
    /reporting/debezium-register-referencedata.json
    • -0
    • +19
    /reporting/docker-compose.debezium.yml
    • -0
    • +10
    /reporting/start-debezium.sh
OLMIS-5492, add Debezium for CDC of Programs.

This is a simple proof of concept, hence why we stream Programs.