Josh Zamor

9 hrs ago

Josh Zamor

More
e98ef34
changed 4 files
master in openlmis-deployment

OLMIS-5603, update uat3 and 4 to latest 3.5 snapshots.

- -10
- +13
/deployment/uat3_env/.env
- History
- Source
- Diff
/deployment/uat3_env/.env
- -37
- +24
/deployment/uat3_env/docker-compose.yml
- History
- Source
- Diff
/deployment/uat3_env/docker-compose.yml
- -10
- +13
/deployment/uat4_env/.env
- History
- Source
- Diff
/deployment/uat4_env/.env
- -37
- +24
/deployment/uat4_env/docker-compose.yml
- History
- Source
- Diff
/deployment/uat4_env/docker-compose.yml

9 hrs ago

Josh Zamor

More
3b9ee51
changed 1 file
master in openlmis-deployment

OLMIS-5603, fix docker daemon issue.

This is a well known issue so not sure why this worked before in this script, however this time it became a blocker. Our documentation is at: https://openlmis.atlassian.net/wiki/x/8o-hBg

- -1
- +1
/provision/ansible/roles/docker/templates/etc/systemd/system/docker_systemd_service_name.d/override.conf.j2
- History
- Source
- Diff
/provision/ansible/.../override.conf.j2

5:59 pm

Josh Zamor

More
FEOLMIS-3450
finished reviewing

10:37 pm

Josh Zamor

More
Re: FEOLMIS-3450
replied to Josh Zamor

I see that most of the changes have been made aside from the first one: "Given I am logged in as a service-client". Is that one difficult or is it simply a WIP?

10:36 pm

Josh Zamor

More
Re: FEOLMIS-3450
replied to Elias

I think the more-right solution is the first one. The second one likely is okay. The last is not desirable at all.

3:38 pm

Josh Zamor

More
Re: FEOLMIS-3450
commented on review

Looking good Elias, left a couple comments. Thanks.

3:36 pm

Josh Zamor

More
Re: FEOLMIS-3450
replied to Elias

Ah, got it, thanks.

10:16 pm

Josh Zamor

More
Re: FEOLMIS-3450
commented on review

Is this important? I don't see that bearer token in the steps so I'm confused where that one came from?

10:14 pm

Josh Zamor

More
Re: FEOLMIS-3450
commented on review

Appears as if this Location UUID could be extracted (used 3 times)

10:13 pm

Josh Zamor

More
Re: FEOLMIS-3450
commented on review

Great to see wiremock in use here. Should the version here follow the format of the other services?

Great to see wiremock in use here.

Should the version here follow the format of the other services?

10:11 pm

Josh Zamor

More
Re: FEOLMIS-3450
commented on review

Great change to make this more BDD!

10:11 pm

Josh Zamor

More
Re: FEOLMIS-3450
commented on review

I understand this is outside the review, however I can see it so I'd recommend we make this more clear: "I am not logged in". This is minor.

I understand this is outside the review, however I can see it so I'd recommend we make this more clear: "I am not logged in".

This is minor.

10:09 pm

Josh Zamor

More
Re: FEOLMIS-3450
commented on review

The Given, When, Then isn't clearly identifiable, and we also see a bit too much technical detail here when we say "I stub a mock server". If possible I'd attempt to make this more focused on BDD'...

The Given, When, Then isn't clearly identifiable, and we also see a bit too much technical detail here when we say "I stub a mock server".

If possible I'd attempt to make this more focused on BDD's Given, When, Then: https://martinfowler.com/bliki/GivenWhenThen.html

Perhaps that'd read as:

Given I am logged in as a service client
And I have an upstream FHIR server
When my upstream FHIR server subscribes to Location updates with the OpenLMIS FHIR Service
<JSON here>
And I update an OpenLMIS Location
Then after I pause for 30 seconds
And I verify that my Upstream FHIR Server has received a notification of a Location change
<JSON here>

I think this is easier to read and will result in a more maintainable test over time.

3:30 am

Josh Zamor

More
96e86c2
changed 1 file
master in openlmis-referencedata

OLMIS-5650, fix missing live docs

This isn't ideal as this appears unnecessary, however this will solve this issue for now.

- -0
- +1
/build.gradle
- History
- Source
- Diff
/build.gradle

10:21 pm

Josh Zamor

More
32260ab
changed 1 file
master in openlmis-referencedata

OLMIS-5650, fix checkApiIsRaml task

- -4
- +2
/build.gradle
- History
- Source
- Diff
/build.gradle

12:20 am

Josh Zamor

More
585cab3
changed 2 files
master in openlmis-referencedata

OLMIS-5650, add OWASP dependency check in Gradle and Jenkins

- -1
- +3
/Jenkinsfile
- History
- Source
- Diff
/Jenkinsfile
- -1
- +1
/build.sh
- History
- Source
- Diff
/build.sh

10:14 am

Josh Zamor

More
8be3d1a
changed 1 file
master in openlmis-referencedata

OLMIS-5650, add OWASP security check and ben manes version check.

- -0
- +5
/build.gradle
- History
- Source
- Diff
/build.gradle

9:03 am

Josh Zamor

More
dfbd37d
changed 2 files
master in openlmis-referencedata

OLMIS-5650, upgrade npm plugin, remove dead gradle.

Removed a number of unused or duplicative declarations. NPM module upgrade lead to a more concise form to call package.json script, and a tidy inprovement to performance.

- -31
- +17
/build.gradle
- History
- Source
- Diff
/build.gradle
- -18
- +1
/documentation.gradle
- History
- Source
- Diff
/documentation.gradle

4:28 pm

Josh Zamor

More
FEOLMIS-3442
Closed

4:28 pm

Josh Zamor

More
Re: FEOLMIS-3442
commented on review

Received feedback in Slack that message is improved, closing.

2:50 pm

Josh Zamor

More
97bd6da
changed 6 files
master in openlmis-referencedata

OLMIS-5650, enable test tasks to be run from gradle outside of docker.

Gradle plugin for docker-compose is added so that if test or integrationTest tasks are run when not in the development container, that needed services (redis, log, db) are started and the published ports may be discovered by those tasks.

Except for log's UDP port which at the moment isn't discoverable with the plugin: https://github.com/avast/gradle-docker-compose-plugin/issues/176

- -0
- +24
/README.md
- History
- Source
- Diff
/README.md
- -3
- +72
/build.gradle
- History
- Source
- Diff
/build.gradle
- -0
- +7
/docker-compose.yml
- History
- Source
- Diff
/docker-compose.yml
- -15
- +1
/src/main/java/org/openlmis/referencedata/Application.java
- History
- Source
- Diff
/src/main/.../referencedata/Application.java
- -1
- +0
/src/main/resources/application.properties
- History
- Source
- Diff
/src/main/.../application.properties
- -1
- +2
/src/main/resources/logback.xml
- History
- Source
- Diff
/src/main/resources/logback.xml

7:26 pm

Josh Zamor

More
FEOLMIS-3442
started review

OLMIS-5663: Describe what a permission string gives you in API docs

7:23 pm

Josh Zamor

More
825fcfe
changed 1 file
master in openlmis-referencedata FEOLMIS-3442

OLMIS-5663, update permission string's doc with usage information.

- -1
- +14
/src/main/resources/api-definition.yaml
- History
- Source
- Diff
/src/main/resources/api-definition.yaml

7:46 am

Josh Zamor

More
68af52d
changed 3 files
master in openlmis-referencedata

OLMIS-5650, add gradle wrapper

- -1
- +0
/.gitignore
- History
- Source
- Diff
/.gitignore
- -0
- +172
/gradlew
- History
- Source
/gradlew
- -0
- +84
/gradlew.bat
- History
- Source
/gradlew.bat

7:13 am

Josh Zamor

More
e756a11
changed 1 file
master in openlmis-referencedata

OLMIS-5650, update raml2html and use relative file paths

- -2
- +2
/package.json
- History
- Source
- Diff
/package.json

9:08 pm

Josh Zamor

More
75a9a26
changed 0 files
master in openlmis-referencedata

Merge branch 'OLMIS-5493-togglz'

8:51 pm

Josh Zamor

More
d4e114d
changed 1 file
master, fix-datasources and 2 more in openlmis-ref-distro

OLMIS-5492, switch db image to one that supports debezium.

- -1
- +1
/.env
- History
- Source
- Diff
/.env

8:27 pm

Josh Zamor

More
1fcd65f
changed 1 file
master in openlmis-postgres

OLMIS-5492, switch postgres base image to debezium's postgres.

Both of these images are based off of the official postgres 9.6 image and both have postgis. The debezium image however is based off of alpine and includes the needed configuration and driver so that the debezium connector may connect to it.