Josh Zamor

About
  • First commit 05 May 2016
  • Latest commit 16 April 2019
Last Week All Time
Commits: 2 1,368

Reviews

0 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Josh Zamor is mapped to 64 committers over 34 repositories
Username joshzamor is mapped to:
Tuesday 16 Apr
6:40 pm

Josh Zamor

OLMIS-6192, add uat2 to terraform

Options
    • -0
    • +24
    /provision/terraform/uat/uat2/main.tf
    • -0
    • +11
    /provision/terraform/uat/uat2/terraform.tfvars
    • -0
    • +39
    /provision/terraform/uat/uat2/variables.tf
6:38 pm

Josh Zamor

OLMIS-6192, add missing import command.

Options
    • -0
    • +1
    /provision/terraform/README.md
Thursday 11 Apr
11:56 pm

Josh Zamor

11:56 pm

Josh Zamor

Thanks Mateusz Kwiatkowski.

Thanks Mateusz Kwiatkowski.

11:55 pm

Josh Zamor

11:55 pm

Josh Zamor

Thanks Mateusz Kwiatkowski, this was more tedious than I thought it might be, though it does still feel safer. Thanks for taking this on.

Thanks Mateusz Kwiatkowski, this was more tedious than I thought it might be, though it does still feel safer. Thanks for taking this on.

Wednesday 10 Apr
8:53 pm

Josh Zamor

Mateusz Kwiatkowski: I'm not that familiar with this part of spring, though I don't like the warning - it makes me wonder if this setting effects Hibernate or Redis connection pools. I don't think ...

Mateusz Kwiatkowski: I'm not that familiar with this part of spring, though I don't like the warning - it makes me wonder if this setting effects Hibernate or Redis connection pools. I don't think it does, but I'd hate to hit another hard to detect threading bug. The alternative of just passing the locale in sounds safer.

As a side topic I think we need to examine how we've been using Async - a quick survey of the code suggests to me we've gone too far.

Tuesday 09 Apr
2:21 pm

Josh Zamor

2:21 pm

Josh Zamor

Looks good, thanks!

Looks good, thanks!

2:20 pm

Josh Zamor

Agreed, thanks.

Agreed, thanks.

7:07 am

Josh Zamor

OLMIS-6183, configure nifi so it knows which host and port

Otherwise without the host port mapped we'll get CORS errors.

Options
    • -0
    • +2
    /reporting/.env
12:16 am

Josh Zamor

OLMIS-6183, add basic traefik

Options
    • -40
    • +6
    /reporting/docker-compose.yml
Monday 08 Apr
10:04 pm

Josh Zamor

OLMIS-6183, add hosts note on running locally.

Options
    • -2
    • +10
    /reporting/README.md
9:58 pm

Josh Zamor

OLMIS-6183, change db host mount to data volume.

Using a host mount isn't generally a good docker practice. It should only really be expected to work on Linux, and even then it doesn't work if the container is deployed to a managed infrastructure.

Options
    • -2
    • +2
    /reporting/docker-compose.yml
9:51 pm

Josh Zamor

OLMIS-6183, add a few intro notes on Kafka.

Options
    • -1
    • +18
    /reporting/README.md
9:42 pm

Josh Zamor

OLMIS-6183, remove unneeded host port binding.

Port bindings of nifi and superset should be unneeded with the reverse proxy.

Options
    • -5
    • +0
    /reporting/docker-compose.yml
9:19 pm

Josh Zamor

OLMIS-6183, remove un-needed port declarations.

Unneeded as declaring them is useful for documentation IF they'll be mapped to the host, however these are quite unlikely to be mapped there.

Options
    • -5
    • +0
    /reporting/docker-compose.yml
9:16 pm

Josh Zamor

OLMIS-6183, fix consul port

Not needed to move the consul port to 8501, didn't work anyhow (bug in that image), and undesirable given the rest of the services register with 8500.

Options
    • -1
    • +1
    /reporting/docker-compose.yml
Thursday 04 Apr
4:57 pm

Josh Zamor

4:57 pm

Josh Zamor

I'll resolve and I'll add some comments to openlmis/dev that highlight why v5 has a newer version of Gradle than v5.2. I know someone will be confused by this in 6 months without it.

I'll resolve and I'll add some comments to openlmis/dev that highlight why v5 has a newer version of Gradle than v5.2. I know someone will be confused by this in 6 months without it.

Wednesday 03 Apr
10:22 pm

Josh Zamor

When I say v5 of this, this == openlmis/dev

When I say v5 of this, this == openlmis/dev

10:21 pm

Josh Zamor

Left a couple comments. Thanks Elias.

Left a couple comments. Thanks Elias.

10:20 pm

Josh Zamor

With isPhysicalInventory() as well I wonder if it's time for an enum?

With isPhysicalInventory() as well I wonder if it's time for an enum?

10:17 pm

Josh Zamor

This is checking if the kit as defined in the DTO from the client matches the Kit definition as it is from ReferenceData, right? If so maybe this validate method would be better named validateUnpac...

This is checking if the kit as defined in the DTO from the client matches the Kit definition as it is from ReferenceData, right? If so maybe this validate method would be better named validateUnpackedKitsMatchReferenceDefinition?

10:11 pm

Josh Zamor

Does KIT_UNPACK_REASON_ID come from an env variable that we should see in https://github.com/OpenLMIS/openlmis-ref-distro/blob/master/settings-sample.env ?

Does KIT_UNPACK_REASON_ID come from an env variable that we should see in https://github.com/OpenLMIS/openlmis-ref-distro/blob/master/settings-sample.env ?

9:25 pm

Josh Zamor

I'm a bit confused - v5 of this moved to Gradle 5, and then v5.2 bumped back to gradle 4. That seems very confusing. Do we intend to remove v5? Does anything work correctly with v5?

I'm a bit confused - v5 of this moved to Gradle 5, and then v5.2 bumped back to gradle 4. That seems very confusing. Do we intend to remove v5? Does anything work correctly with v5?

Friday 08 Mar
6:17 am

Josh Zamor

Hmm, it should either ignore or replace associations from what I remember ~2 years ago. Also without the RAML change that's still needed I'm assuming that it might be taking you to the create metho...

Hmm, it should either ignore or replace associations from what I remember ~2 years ago. Also without the RAML change that's still needed I'm assuming that it might be taking you to the create method rather than the update?

Thursday 07 Mar
11:09 pm

Josh Zamor

Er wait, let me walk that back. a PUT /api/resource/{id} should be an update - the URI has to exist. A PUT /api/resource should create, and may do so with a specific id, but the ID has to be in t...

Er wait, let me walk that back. a 

PUT /api/resource/{id}

should be an update - the URI has to exist. A 

PUT /api/resource

should create, and may do so with a specific id, but the ID has to be in the body of the request. I think our guideline is a little vague there.

11:05 pm

Josh Zamor

Good catch and you're right. I'll see if I can get this in the airport tonight.

Good catch and you're right. I'll see if I can get this in the airport tonight.

11:04 pm

Josh Zamor

I'm assuming it should as it used to when I first implemented this resource some ~2 years ago. It should in fact be the only way to create the ProgramOrderable association.

I'm assuming it should as it used to when I first implemented this resource some ~2 years ago. It should in fact be the only way to create the ProgramOrderable association.