jhopen

About
  • First commit 20 September 2016
  • Latest commit 22 February 2017
Last Week All Time
Commits: 0 345

Reviews

0 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

jhopen is mapped to 17 committers over 17 repositories
Username jhopen is mapped to:
Wednesday 22 Feb 2017
3:28 pm

jhopen

3:02 pm

jhopen

OLMIS-1973 fixed 500 error code while converting to order
OLMIS-1973 fixed 500 error code while converting to order
2:52 pm

jhopen

OLMIS-1973 fixed 500 error code while converting to order

While converting RequisitionLineItems to OrderLineItems RequisitionLineItems marked as skipped are filtered out

Options
    • -0
    • +1
    /src/main/java/org/openlmis/requisition/web/OrderDtoBuilder.java
2:37 pm

jhopen

1:41 pm

jhopen

1:35 pm

jhopen

OLMIS-1474 fixed debug message when supported program not found

Options
    • -1
    • +2
    /src/main/java/org/openlmis/referencedata/web/FacilityController.java
1:17 pm

jhopen

it's because we can hardcode requested quantity for every line item but every line item has a different price per pack and size of a pack so packtoShip will also be different for every line item so...

it's because we can hardcode requested quantity for every line item but every line item has a different price per pack and size of a pack so packtoShip will also be different for every line item so I can't hardcode totalCost here

12:37 pm

jhopen

OLMIS-1474 When I enter Program UID in SupportedPrograms message error is not correct.
OLMIS-1474 When I enter Program UID in SupportedPrograms message error is not correct.
11:05 am

jhopen

Sebastian Brudziński are issues resolved?

Sebastian Brudziński are issues resolved?

11:02 am

jhopen

OLMIS-1474 facilityController searches program by id or code

when creating facility, controller will search program by id if code is not provided,

endpoint will return 400 if id nor code are provided,

added message to return when both id and code are null.

Options
    • -0
    • +1
    /src/main/java/org/openlmis/referencedata/util/messagekeys/ProgramMessageKeys.java
    • -1
    • +8
    /src/main/java/org/openlmis/referencedata/web/FacilityController.java
    • -0
    • +1
    /src/main/resources/messages_en.properties
8:37 am

jhopen

OLMIS-1802 removed unnecessary code, minor codestyle fixes

Options
    • -2
    • +1
    /src/cucumber/java/org/openlmis/contract_tests/requisition/RequisitionStepDefs.java
Tuesday 21 Feb 2017
4:15 pm

jhopen

OLMIS-1802 fixed failing contract test

removed hardcoded totalCost values and added method to count totalCost for each line item.

Options
    • -0
    • +25
    /src/cucumber/java/org/openlmis/contract_tests/requisition/RequisitionStepDefs.java
    • -18
    • +12
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RequisitionTests.feature
11:06 am

jhopen

looks like it is needed to obtain proper requisition to work with in later steps, without it, they throw an NPE.

looks like it is needed to obtain proper requisition to work with in later steps, without it, they throw an NPE.

9:00 am

jhopen

8:26 am

jhopen

because right should be named facility_approved_orderables_manage not facility_approved_product_manage like I did before Josh commented on the ticket, so I removed this file but it never left my lo...

because right should be named facility_approved_orderables_manage not facility_approved_product_manage like I did before Josh commented on the ticket, so I removed this file but it never left my local repository so I thought there is no problem since it was never on remote repo.

Monday 20 Feb 2017
5:50 pm

jhopen

OLMIS-1802 added test for calculating total cost
OLMIS-1802 added test for calculating total cost
5:45 pm

jhopen

OLMIS-1802 added test for calculating total cost

Options
    • -0
    • +65
    /src/cucumber/resources/org/openlmis/contract_tests/requisition_tests/RequisitionTests.feature
2:25 pm

jhopen

OLMIS-1593 Create Right: Manage facility approved products (orderables)
OLMIS-1593 Create Right: Manage facility approved products (orderables)
1:28 pm

jhopen

OLMIS-1593 fixed failing integration tests

added equals and hashCode methods to FacilityTypeApprovedProduct,

removed unused imports,

added doc to ProgramOrderableDeserializer.

Options
    • -3
    • +0
    /src/integration-test/java/org/openlmis/referencedata/web/FacilityTypeApprovedProductControllerIntegrationTest.java
    • -0
    • +41
    /src/main/java/org/openlmis/referencedata/domain/FacilityTypeApprovedProduct.java
    • -5
    • +0
    /src/main/java/org/openlmis/referencedata/domain/ProgramOrderable.java
    • -0
    • +15
    /src/main/java/org/openlmis/referencedata/domain/ProgramOrderableDeserializer.java
8:54 am

jhopen

OLMIS-1593 changed right name to FACILITY_APPROVED_ORDERABLES_MANAGE

fixed some integration tests,

added deserializer for ProgramOrderable.java,

changed response code for facilityTypeApprovedProducts/{id} DELETE endpoint to 204 from 200.

Options
    • -1
    • +1
    /src/integration-test/java/org/openlmis/referencedata/web/FacilityControllerIntegrationTest.java
    • -14
    • +39
    /src/integration-test/java/org/openlmis/referencedata/web/FacilityTypeApprovedProductControllerIntegrationTest.java
    • -0
    • +7
    /src/main/java/org/openlmis/referencedata/domain/ProgramOrderable.java
    • -0
    • +68
    /src/main/java/org/openlmis/referencedata/domain/ProgramOrderableDeserializer.java
    • -1
    • +2
    /src/main/java/org/openlmis/referencedata/domain/RightName.java
    • -1
    • +3
    /src/main/java/org/openlmis/referencedata/web/FacilityController.java
    • -6
    • +6
    /src/main/java/org/openlmis/referencedata/web/FacilityTypeApprovedProductController.java
    • -12
    • +0
    /src/main/resources/db/migration/20170215122344292__create_manage_facility_approved_product_right.sql
    • -0
    • +12
    /src/main/resources/db/migration/20170216082252561__create_facility_approved_orderables_manage_right.sql
Wednesday 15 Feb 2017
1:50 pm

jhopen

OLMIS-1593 Created FACILITY_APPROVED_PRODUCT_MANAGE right

added FACILITY_APPROVED_PRODUCT_MANAGE right,

added right check to facilityTypeApprovedProducts endpoints,

added integration tests,

modified raml.

Options
    • -0
    • +71
    /src/integration-test/java/org/openlmis/referencedata/web/FacilityTypeApprovedProductControllerIntegrationTest.java
    • -0
    • +1
    /src/main/java/org/openlmis/referencedata/domain/RightName.java
    • -0
    • +6
    /src/main/java/org/openlmis/referencedata/web/FacilityTypeApprovedProductController.java
    • -0
    • +16
    /src/main/resources/api-definition.yaml
    • -0
    • +12
    /src/main/resources/db/migration/20170215122344292__create_manage_facility_approved_product_right.sql
10:28 am

jhopen

10:19 am

jhopen

OLMIS-1913 modified number to be constatnt

Options
    • -1
    • +3
    /src/main/java/org/openlmis/requisition/validate/DraftRequisitionValidator.java
10:00 am

jhopen

Klaudia Pałkowska told me that this is the way this is calculated

Klaudia Pałkowska told me that this is the way this is calculated

9:30 am

jhopen

OLMIS-1913 added validation for totalStockoutDays
OLMIS-1913 added validation for totalStockoutDays
9:21 am

jhopen

OLMIS-1913 added validation for totalStockoutDays

added validation for field totalStockOutDays,

added unit test,

added proper message.

Options
    • -0
    • +2
    /src/main/java/org/openlmis/requisition/i18n/MessageKeys.java
    • -0
    • +17
    /src/main/java/org/openlmis/requisition/validate/DraftRequisitionValidator.java
    • -0
    • +1
    /src/main/resources/messages_en.properties
    • -0
    • +19
    /src/test/java/org/openlmis/requisition/validate/DraftRequisitionValidatorTest.java
8:24 am

jhopen

Tuesday 14 Feb 2017
3:55 pm

jhopen

OLMIS-1859 modified 3 integration tests

simplified extracting List from endpoints responses where it was possible,

in shouldFindRequisitionWithStatuses,

in shouldReturnOnlyRequisitionsForWhichUserHasRights,

in shouldReturnEmptyListIfUserHasNoRightsToSeeFoundedRequisitions.

Options
    • -18
    • +3
    /src/integration-test/java/org/openlmis/requisition/web/RequisitionControllerIntegrationTest.java
3:55 pm

jhopen

OLMIS-1859 modified 3 integration tests

simplified extracting List from endpoints responses where it was possible,

in shouldFindRequisitionWithStatuses,

in shouldReturnOnlyRequisitionsForWhichUserHasRights,

in shouldReturnEmptyListIfUserHasNoRightsToSeeFoundedRequisitions.

Options
    • -18
    • +3
    /src/integration-test/java/org/openlmis/requisition/web/RequisitionControllerIntegrationTest.java
3:19 pm

jhopen

it is used in almost every test to receive a List from the response, and in 807 line test you asked me to try not use this to get List so I guess this can be done simpler way. should I change it in...

it is used in almost every test to receive a List from the response, and in 807 line test you asked me to try not use this to get List so I guess this can be done simpler way. should I change it in every other test?