OLMIS-5674: Add extraData column on shipment Line Item. Persist any extra column defined in shipment...
OLMIS-5674: Add extraData column on shipment Line Item. Persist any extra column defined in shipment...
I think this is safe because this migration script was never released.

I think this is safe because this migration script was never released.

OLMIS-5673: parse incoming shipment files and persist as shipment objects
OLMIS-5673: parse incoming shipment files and persist as shipment objects
OLMIS-5670: poll ftp server for shipment files.
OLMIS-5670: poll ftp server for shipment files.
LocationTests was where the step was used. LocationTests.feature file is updated.

LocationTests was where the step was used. LocationTests.feature file is updated.

I was not sure about this. I have seen 3 patterns in the contract test around versions. Version number specified in the .env file. An explicit version specified inline. (Redis) No version specifie...

I was not sure about this. I have seen 3 patterns in the contract test around versions.

Version number specified in the .env file.
An explicit version specified inline. (Redis)
No version specified at all (FTP server)

https://github.com/OpenLMIS/openlmis-contract-tests/blob/c1a5b6789ab711f038f8e1c7b3a67a0b93501785/docker-compose.fulfillment.yml#L38

Is the version in the .env file for 'all' docker images that we use? I will update wiremock with version in the .env for now.

Yes, this token is important. It is coming from the subscription object. This header is used to authenticate at the upstream FHIR server. https://github.com/OpenLMIS/openlmis-contract-tests/blob/c...

Yes, this token is important. It is coming from the subscription object. This header is used to authenticate at the upstream FHIR server.

https://github.com/OpenLMIS/openlmis-contract-tests/blob/c1a5b6789ab711f038f8e1c7b3a67a0b93501785/src/cucumber/resources/org/openlmis/contract_tests/hapifhir/SubscriptionTests.feature#L18

OLMIS-5619: Add contract test for HAPI FHIR subscription.
OLMIS-5619: Add contract test for HAPI FHIR subscription.
Assume you had a json object that you submitted to /transferProperties rest API before this change. If you tried to use the same json object to create or update transferProperties now, without the ...

Assume you had a json object that you submitted to /transferProperties rest API before this change. If you tried to use the same json object to create or update transferProperties now, without the transferType attibute, it will throw an error.

You are right, I have tried to make the search API and others to have default so that those don't be breaking changes. However, the save method still requires the new attribute and if the new attribute is not supplied it will fail. This is why I thought this is a breaking change.

Thanks Mateusz Kwiatkowski I see you have updated the demo data. I have added your change to this review.

Thanks Mateusz Kwiatkowski I see you have updated the demo data. I have added your change to this review.

OLMIS-5480: update transfer properties so that both order and shipment file related transfer credentials...
OLMIS-5480: update transfer properties so that both order and shipment file related transfer credentials...
I created the review to make sure Lukas and you are aware of the auto-commit configuration changes. I will close this review.

I created the review to make sure Lukas and you are aware of the auto-commit configuration changes. I will close this review.

OLMIS-5598: enable subscriptions in openlmis-hapifhir
OLMIS-5598: enable subscriptions in openlmis-hapifhir
No. There never was CsvColumn Builder. FileColumnBuilder was added in this commit.

No. There never was CsvColumn Builder. FileColumnBuilder was added in this commit.

Thank you Nikodem Graczewski and Łukasz Lewczyński for reviewing this. I created a new review for a commit that affects the same files. The new review is for another refactoring that I did to appl...

Thank you Nikodem Graczewski and Łukasz Lewczyński for reviewing this.

I created a new review for a commit that affects the same files. The new review is for another refactoring that I did to apply the feedback I received on the sprint demo. By making it a new review, my hope is that it will be easier to review. I have marked the unresolved issues to resolved because those were resolved in a subsequent commit that went into that next review. I did not want to add that commit to this review, as that would double the effort it takes to review the same work twice.

I have resolved this issue as part of a commit that went into another review. I will mark this feedback as resolved so I can close this review on an obsolete file. https://github.com/OpenLMIS/open...

I have resolved this issue as part of a commit that went into another review. I will mark this feedback as resolved so I can close this review on an obsolete file.

https://github.com/OpenLMIS/openlmis-fulfillment/blob/b2ab87f581421c006cb0270c8a7984f659902450/src/main/java/org/openlmis/fulfillment/service/FileTemplateService.java#L40

This method is removed with a subsequent commit. I am going to resolve this issue here. https://github.com/OpenLMIS/openlmis-fulfillment/blob/b2ab87f581421c006cb0270c8a7984f659902450/src/main/java...
Point taken. I have done another round of refactoring to implement the feedback I received on the sprint demo. Instead of adding those changes to this review, I have created a new review. Hope that...

Point taken. I have done another round of refactoring to implement the feedback I received on the sprint demo. Instead of adding those changes to this review, I have created a new review. Hope that makes it easier.
The new review will have a few more additional tests so the commit could pass sonar analysis. The tests are not for new code. Those are for old code just written to satisfy sonar's 65% branch coverage quality gate. Hope it is okay to keep those in the same commit.

OLMIS-5581: Rename CsvFileTemplate to FileTemplate, increased coverage on some classes
OLMIS-5581: Rename CsvFileTemplate to FileTemplate, increased coverage on some classes
https://github.com/OpenLMIS/openlmis-contract-tests/commits/af7b218619c08df7060ae3e45c2a7f43a97400a3
Working on this.

Working on this.