Remove connection and data timeout settings to use the default

Remove unused variable

Remove @Query from OrderRepository, Add more orders in test.

Remove unecessary @Query, improve tests

OLMIS-5674: Add extraData column on shipment Line Item. Persist any extra column defined in shipment...
OLMIS-5674: Add extraData column on shipment Line Item. Persist any extra column defined in shipment...
I think this is safe because this migration script was never released.

I think this is safe because this migration script was never released.

OLMIS-5674: Add extraData column on shipment Line Item. Persist any extra column defined in shipment file template.

    • -0
    • +1
    /src/main/resources/db/migration/20181121023726318__add_extra_data_column_on_shipment_line_items.sql
Fix missing final keyword

OLMIS-5673: parse incoming shipment files and persist as shipment objects
OLMIS-5673: parse incoming shipment files and persist as shipment objects
OLMIS-5670: poll ftp server for shipment files.
OLMIS-5670: poll ftp server for shipment files.
OLMIS-5673: parse incoming shipment files and persist as shipment objects

    • -0
    • +3
    /src/test/resources/shipment_file_inconsistent.csv
    • -0
    • +3
    /src/test/resources/shipment_file_with_header.csv
OLMIS-5670: poll ftp server for shipment files.

    • -0
    • +89
    /src/main/resources/META-INF/shipment-ftp-context.xml
Review Feedback - rename step.

LocationTests was where the step was used. LocationTests.feature file is updated.

LocationTests was where the step was used. LocationTests.feature file is updated.

OLMIS-5619: Address code review feedbacks

I was not sure about this. I have seen 3 patterns in the contract test around versions. Version number specified in the .env file. An explicit version specified inline. (Redis) No version specifie...

I was not sure about this. I have seen 3 patterns in the contract test around versions.

Version number specified in the .env file.
An explicit version specified inline. (Redis)
No version specified at all (FTP server)

https://github.com/OpenLMIS/openlmis-contract-tests/blob/c1a5b6789ab711f038f8e1c7b3a67a0b93501785/docker-compose.fulfillment.yml#L38

Is the version in the .env file for 'all' docker images that we use? I will update wiremock with version in the .env for now.

Yes, this token is important. It is coming from the subscription object. This header is used to authenticate at the upstream FHIR server. https://github.com/OpenLMIS/openlmis-contract-tests/blob/c...

Yes, this token is important. It is coming from the subscription object. This header is used to authenticate at the upstream FHIR server.

https://github.com/OpenLMIS/openlmis-contract-tests/blob/c1a5b6789ab711f038f8e1c7b3a67a0b93501785/src/cucumber/resources/org/openlmis/contract_tests/hapifhir/SubscriptionTests.feature#L18

OLMIS-5619: reuse pause step, increase the pause to 30 seconds

OLMIS-5619: Add contract test for HAPI FHIR subscription.
OLMIS-5619: Add contract test for HAPI FHIR subscription.
OLMIS-5619: Add contract test for HAPI FHIR subscription.

OLMIS-5480: Remove constraint that was renamed, rename new constraint to be more descriptive.

OLMIS-5480: Set composite unique constraint on the domain class.

Assume you had a json object that you submitted to /transferProperties rest API before this change. If you tried to use the same json object to create or update transferProperties now, without the ...

Assume you had a json object that you submitted to /transferProperties rest API before this change. If you tried to use the same json object to create or update transferProperties now, without the transferType attibute, it will throw an error.

You are right, I have tried to make the search API and others to have default so that those don't be breaking changes. However, the save method still requires the new attribute and if the new attribute is not supplied it will fail. This is why I thought this is a breaking change.

Thanks Mateusz Kwiatkowski I see you have updated the demo data. I have added your change to this review.

Thanks Mateusz Kwiatkowski I see you have updated the demo data. I have added your change to this review.

OLMIS-5480: Added unique constraint, updated demo data