Disable caching of shipment templates. Makes it easier to test OLMIS-5832 - OLMIS-5835
Disable caching of shipment templates. Makes it easier to test OLMIS-5832 - OLMIS-5835
OLMIS-6010: improve test coverage
OLMIS-6010: improve test coverage
OLMIS-6010: improve test coverage

Bug Fix: rowsWithUnresolvedOrderable property should be visible in shipments api response

Remove unused setter, added a test

Makes sense. Thank you.

Makes sense. Thank you.

Split shipment error handler into a separate class to improve testability

Review feedback. Remove Gson and use Jackson for serializing unresolved orderable rows

Introduce methods to add line item and unresolved rows.

1. The code with Gson's implementation is one liner (Much simpler than jackson code I would be expected to write) 2. does not throw unhandled exception requiring further handling. 3. The library is...

1. The code with Gson's implementation is one liner (Much simpler than jackson code I would be expected to write) 2. does not throw unhandled exception requiring further handling. 3. The library is already available. I did not have to add it as a dependency in gradle file. Is Gson usage a significant problem that must be avoided?

Use existing MessageKeys instead of String.format

This commit contains work for two tickets. OLMIS-6010 and OLMIS-5986. This was a mistake I made and noticed only after I pushed the code. My apologies for this will make it harder to review.

This commit contains work for two tickets. OLMIS-6010 and OLMIS-5986. This was a mistake I made and noticed only after I pushed the code. My apologies for this will make it harder to review.

OLMIS-5986: For shipment files that did not process successfully, write an error log file in the errors...
OLMIS-5986: For shipment files that did not process successfully, write an error log file in the errors...
OLMIS-5985: Prefix archived shipment files with timestamp to avoid file name collision.
OLMIS-5985: Prefix archived shipment files with timestamp to avoid file name collision.
OLMIS-5675: Capture shipment line items with unresolved orderable in extra data
OLMIS-5675: Capture shipment line items with unresolved orderable in extra data
Update shipment schema to include rowsWithUnresolvedOrderable.

    • -0
    • +4
    /src/main/resources/schemas/shipment.json
OLMIS-5986: For shipment files that did not process successfully, write an error log file in the errors folder that describes why it failed to process.

Refactored shipment integration channel names for better readability.

OLMIS-5985: Prefix archived shipment files with timestamp to avoid file name collision.

OLMIS-5675: Capture shipment line items with unresolved orderable in extra data

Yes, this method is called only from the spring integration, service activators from one of the three xml files. In all the three cases, this method is triggered for files with csv extension that i...

Yes, this method is called only from the spring integration, service activators from one of the three xml files. In all the three cases, this method is triggered for files with csv extension that is found in the incoming directory.

OLMIS-5672: Accept changes to transfer properties and update the spring contexts that monitor for...
OLMIS-5672: Accept changes to transfer properties and update the spring contexts that monitor for...