Chongsun Ahn

OLMIS-6858 Reporting stack to data-pump strategy
OLMIS-6858 Reporting stack to data-pump strategy
Feel free to notify anyone else who should look at this review.

Feel free to notify anyone else who should look at this review.

There are two main connectors for each service (referencedata and requisition), one source (e.g. source-requisition) and one sink (e.g. sink-requisition). The additional sink connectors are for tab...

There are two main connectors for each service (referencedata and requisition), one source (e.g. source-requisition) and one sink (e.g. sink-requisition). The additional sink connectors are for tables that do not have a single id field defined as the primary key.

This is just to match the schema changes in the db.

This is just to match the schema changes in the db.

Script for starting up the stack locally. Not sure if it works in Linux and older versions of macOS.

Script for starting up the stack locally. Not sure if it works in Linux and older versions of macOS.

New settings to define access to the source db and the sink db (for the connectors).

New settings to define access to the source db and the sink db (for the connectors).

This is just for local dev, removing scalyr and logging to syslog, so the logs can be viewed through docker logs.

This is just for local dev, removing scalyr and logging to syslog, so the logs can be viewed through docker logs.

I don't expect we would start up with different versions for Kafka and Zookeeper, so there is just one Confluent version.

I don't expect we would start up with different versions for Kafka and Zookeeper, so there is just one Confluent version.

This is basically the schema in reference data and requisition, minus the foreign keys. Additionally, there is an additional table to define timeliness for each country, and then the materialized v...

This is basically the schema in reference data and requisition, minus the foreign keys. Additionally, there is an additional table to define timeliness for each country, and then the materialized views at the end.

These are here so that the folders exist when mounting the volume to the container.

These are here so that the folders exist when mounting the volume to the container.

OLMIS-6855 Set pageable to no pagination for orderableFulfills
OLMIS-6855 Set pageable to no pagination for orderableFulfills
Feel free to add anyone else, I'm not sure who is on the Core team anymore.

Feel free to add anyone else, I'm not sure who is on the Core team anymore.

OLMIS-6771 Update Spring Boot version to 2.x
OLMIS-6771 Update Spring Boot version to 2.x
OLMIS-6764 Upgrade Spring Boot to 2.2.2
OLMIS-6764 Upgrade Spring Boot to 2.2.2
OLMIS-6761 Upgrade Spring Boot to 2.2.2
OLMIS-6761 Upgrade Spring Boot to 2.2.2
I was a bit hesitant to roll out this new version of the service to all servers, but we can do that.

I was a bit hesitant to roll out this new version of the service to all servers, but we can do that.

OLMIS-6760 Upgrade Spring Boot to 2.2.2
OLMIS-6760 Upgrade Spring Boot to 2.2.2
I think Nifi seems to normally take a while to finish starting. Seems like things are getting updated properly, as there would be errors in the process groups if things were not.

I think Nifi seems to normally take a while to finish starting. Seems like things are getting updated properly, as there would be errors in the process groups if things were not.

Yes, I was quite pleased to see that the Nifi docker image had it included. Interesting, how can I recreate the issue you were having in order to support some basic error paths?

Yes, I was quite pleased to see that the Nifi docker image had it included.

Interesting, how can I recreate the issue you were having in order to support some basic error paths?

The review is mainly for any code smells in the preload.sh script. If you don't see any issues there, I can close this review.

The review is mainly for any code smells in the preload.sh script. If you don't see any issues there, I can close this review.

OLMIS-6481 Load process groups from templates, not registry
OLMIS-6481 Load process groups from templates, not registry
OLMIS-6473 Rename openlmisDatetime filter
OLMIS-6473 Rename openlmisDatetime filter