Chongsun Ahn

I think Nifi seems to normally take a while to finish starting. Seems like things are getting updated properly, as there would be errors in the process groups if things were not.

I think Nifi seems to normally take a while to finish starting. Seems like things are getting updated properly, as there would be errors in the process groups if things were not.

Yes, I was quite pleased to see that the Nifi docker image had it included. Interesting, how can I recreate the issue you were having in order to support some basic error paths?

Yes, I was quite pleased to see that the Nifi docker image had it included.

Interesting, how can I recreate the issue you were having in order to support some basic error paths?

The review is mainly for any code smells in the preload.sh script. If you don't see any issues there, I can close this review.

The review is mainly for any code smells in the preload.sh script. If you don't see any issues there, I can close this review.

OLMIS-6481 Load process groups from templates, not registry
OLMIS-6481 Load process groups from templates, not registry
OLMIS-6473 Rename openlmisDatetime filter
OLMIS-6473 Rename openlmisDatetime filter
Feel free to add a more appropriate reviewer.

Feel free to add a more appropriate reviewer.

OLMIS-6464 Make redis cache persistent using configurable parameter
OLMIS-6464 Make redis cache persistent using configurable parameter
Looks good to me.

Looks good to me.

I don't think JSON supports comments. I think this is fine for now, and will resolve the issue.

I don't think JSON supports comments. I think this is fine for now, and will resolve the issue.

Looks good to me. And the YAML parameterization is pretty slick.

Looks good to me. And the YAML parameterization is pretty slick.

Looks good to me.

Looks good to me.

This is true. I'm just wondering if we want to allow these json files to have local dev default values in case someone wants to use them to re-register the connector and they don't have to edit the...

This is true. I'm just wondering if we want to allow these json files to have local dev default values in case someone wants to use them to re-register the connector and they don't have to edit the file before using it. What do you think?

Yeah, basically I was using one docker compose file for both local development and the automated deployment. Some containers were logging to syslog, while others were not and just logging to stdout...

Yeah, basically I was using one docker compose file for both local development and the automated deployment. Some containers were logging to syslog, while others were not and just logging to stdout. I separated local dev and automated deployment into separate docker compose files, and the automated deployment containers all log to syslog now, so that they can be captured by scalyr.

OLMIS-6461 Change hardcoded values to configurable values
OLMIS-6461 Change hardcoded values to configurable values
OLMIS-6427 ETL pipeline automated deployment
OLMIS-6427 ETL pipeline automated deployment
OLMIS-6424 Get demo data automatically loaded into Casper v3 serverFix load data SQL error
OLMIS-6424 Get demo data automatically loaded into Casper v3 serverFix load data SQL error
This needs to be manually done, since demo data is loaded after refresh-db profile is run.

This needs to be manually done, since demo data is loaded after refresh-db profile is run.

The v3 server is pegged to 3.6, so this field still exists in the schema.

The v3 server is pegged to 3.6, so this field still exists in the schema.

The v3 instance should be read-only and should not be allowed to change data.

The v3 instance should be read-only and should not be allowed to change data.