Chris Kaczmarczyk

hey, Chongsun Ahn Josh Zamor Darius Jazayeri do you have any suggestions regarding that? Which design (shown in concept.png) looks more appropriate to you?

hey, Chongsun Ahn Josh Zamor Darius Jazayeri do you have any suggestions regarding that? Which design (shown in concept.png) looks more appropriate to you?

OK, it can be resolved on UI side

OK, it can be resolved on UI side

should be "in jrxml format"

should be "in jrxml format"

Makes sense to me. This UML Class Diagram wasn't done to show workflow but rather classes involved - it was visualized in each of the UML sequence diagrams. I guess the title of the ticket/review i...

Makes sense to me. This UML Class Diagram wasn't done to show workflow but rather classes involved - it was visualized in each of the UML sequence diagrams. I guess the title of the ticket/review is misleading.
Up to recent decision about fully encouraging OOD, we were rather using POJOs, meaning really thin domain layer and having logic in service or helper classes, that's another reason why it looks like ERD.
Anyway, thanks for the tips, we will include them in next iteration. Also, I think diagrams being done OOD way will result in refactor of current code base

Let's rework Class Diagram as per Josh Zamor remark in http://review.openlmis.org:7788/cru/FEOLMIS-173

Let's rework Class Diagram as per Josh Zamor remark in http://review.openlmis.org:7788/cru/FEOLMIS-173

OLMIS-945 UMLs: Create Order Workflow
OLMIS-945 UMLs: Create Order Workflow
old one

old one

Josh Zamor Do you feel like this need further documentation?

Josh Zamor Do you feel like this need further documentation?

Gotcha, sounds reasonable. It seems like downloading was not covered in the acceptance criteria of PoD customer configuration ticket. I created new ticket about adding download capability, refactor...

Gotcha, sounds reasonable. It seems like downloading was not covered in the acceptance criteria of PoD customer configuration ticket. I created new ticket about adding download capability, refactoring part of logic and fixing messages properties as per Style Guide - OLMIS-1006.
Would you like to add anything to the description?

Hi Josh Zamor and Chongsun Ahn, Mikolaj prepared a design preview - could someone from ILL team look at it?

Hi Josh Zamor and Chongsun Ahn,
Mikolaj prepared a design preview - could someone from ILL team look at it?

Josh Zamor That is a good question. As far as I know for time being we will be storing just IDs (references) of the related objects in the Reference Data Service. And it seems like caching is not y...

Josh Zamor That is a good question. As far as I know for time being we will be storing just IDs (references) of the related objects in the Reference Data Service. And it seems like caching is not yet implemented/fully designed yet (I might not be up-to-date with Product progress).
I guess we could edit diagram to show references/UUIDs for now, or clearly indicate which entities are from different service? I feel like caching needs more design, or documentation before we jump to it in the diagram. I guess after we will have it we can get back to diagram (potentially in different ticket, since this can take time). How does that sounds?

Hey Chongsun, "/podTemplates" endpoints sounds better to me, but that's personal opinion I guess If I understand properly you would like to add an ability to download the template? Do you see this ...

Hey Chongsun,
"/podTemplates" endpoints sounds better to me, but that's personal opinion I guess
If I understand properly you would like to add an ability to download the template? Do you see this as a benefit to user - how would the usecase look like?
Currently template is saved in DB after compilation of the Jasper, but we could look into ways of fetching it from DB and returning in xml format on GET request. (Maybe saving both formats would be simplest)
UPDATE: it's quite simple to return jasper template, even from compiled version

Chongsun Ahn should we add also all related Services to the diagram? This one mainly shows domain stuff

Chongsun Ahn should we add also all related Services to the diagram? This one mainly shows domain stuff