Thanks for working on this bug and putting your fix in a Fisheye review! You don't need to add me as a Reviewer on future reviews. Wes Brown can suggest if there are any other developers who should...

Thanks for working on this bug and putting your fix in a Fisheye review! You don't need to add me as a Reviewer on future reviews. Wes Brown can suggest if there are any other developers who should be added to reviews.

Question: It looks like this error message may be used for lots of different date fields. Do all the date fields that use this message accept the same format (yyyy-MM-dd)?

Question: It looks like this error message may be used for lots of different date fields. Do all the date fields that use this message accept the same format (yyyy-MM-dd)?

Add docs link to New Dev Onboarding

OLMIS-4635: Architecture documentation tweaks

OLMIS-4635: Architecture documentation tweaks

Added a cross-reference about Transifex

OLMIS-4223: Release Notes automated testing info

OLMIS-4223: For Release Notes v3.3.0, added component version numbers.

OLMIS-4223: Release Notes Template for 3.3.0

    • -0
    • +291
    /docs/source/releases/openlmis-ref-distro-v3.3.0.rst
I agree.

I agree.

On the other hand, it does make line 69 above more readable than trying to put all the conditions inline.

On the other hand, it does make line 69 above more readable than trying to put all the conditions inline.

And all your responses make sense to me. Thanks!

And all your responses make sense to me. Thanks!

LGTM

LGTM

Similar capitalization change here (shipmentId -> shipmentid). If this is intentional and matches our style guide or works without changing Java code, that's great. Just wanted to flag it.

Similar capitalization change here (shipmentId -> shipmentid). If this is intentional and matches our style guide or works without changing Java code, that's great. Just wanted to flag it.

Is there any reason to still keep lines 4-5-6 in place? Why bother adding those 3 columns here if we are going to create an all-new table? (Feel free to leave it this way if there's a reason; it lo...

Is there any reason to still keep lines 4-5-6 in place? Why bother adding those 3 columns here if we are going to create an all-new table? (Feel free to leave it this way if there's a reason; it looks like it will work this way.)

Capitalization on columns appears to have changed (eg; vvmStatus -> vvmstatus and rejectionReasonId -> rejectionreasonid). Does that mean we need to change Java code to match?

Capitalization on columns appears to have changed (eg; vvmStatus -> vvmstatus and rejectionReasonId -> rejectionreasonid). Does that mean we need to change Java code to match?

LGTM

LGTM

OLMIS-4222: Add demo data ISAs for syringe at 3 health facilities

    • -0
    • +504
    /demo-data/referencedata.ideal_stock_amounts.json
OLMIS-4222: Add demo data ISAs for syringe

    • -1
    • +57
    /demo-data/referencedata.ideal_stock_amounts.json
OLMIS-4222: Reorder demo data EPI requisition columns

    • -18
    • +18
    /demo-data/requisition.columns_maps.json
OLMIS-4222: Add demo data for historical EPI requisitions by divo1 (AC#6)

    • -0
    • +468
    /demo-data/requisition.requisition_line_items.json
    • -0
    • +28
    /demo-data/requisition.requisitions.json
    • -0
    • +56
    /demo-data/requisition.status_changes.json
OLMIS-4222: Add demo data for EPI requisition from divo1 to rivo (AC#6)

    • -0
    • +234
    /demo-data/requisition.requisition_line_items.json
    • -0
    • +14
    /demo-data/requisition.requisitions.json
    • -0
    • +28
    /demo-data/requisition.status_changes.json
OLMIS-4222: Fix demo data EPI requisitions to change TradeItems to CommodityTypes (AC#6)

    • -8
    • +8
    /demo-data/requisition.requisition_line_items.json
OLMIS-4222: Fix demo data EPI requisitions to remove Gas and Diluents (AC#6)

    • -175
    • +0
    /demo-data/requisition.requisition_line_items.json
OLMIS-4222: Fix demo data FTAPs for EPI to remove Gas and Diluents (AC#6)

    • -27
    • +0
    /demo-data/referencedata.facility_type_approved_products.json
OLMIS-4222: Set demo data for EPI program to Skip Authorization Step

    • -1
    • +3
    /demo-data/referencedata.programs.json