Boniface Chacha

TZUP-203 : fixed the property names for equipments in create and update

    • -3
    • +3
    /src/equipments-edit/equipments-edit.html
TZUP-225, TZUP-226 added permissions for managing equipments on models and energy types

Signed-off-by: Boniface Chacha <bonifacechacha@gmail.com>

TZUP-203 : added permission for managing equipments

added equipment manage right

added equipment manage right

hassan I have made the changes you recommended

hassan I have made the changes you recommended

TZUP-212 : corrected the notification messages on the tests

this is resolved

this is resolved

TZUP-225, TZUP-226, TZUP-243 added permissions for managing equipments on equipment, models and energy types
TZUP-225, TZUP-226, TZUP-243 added permissions for managing equipments on equipment, models and energy types
TZUP: 203 Implemented the GUI for managing equipment list
TZUP: 203 Implemented the GUI for managing equipment list
TZUP-225, TZUP-226 added permissions for managing equipments on models and energy types

Signed-off-by: Boniface Chacha <bonifacechacha@gmail.com>

TZUP-203 : added permission for managing equipments

TZUP-203 : added test for equipment edit view

TZUP-203 : Create GUI for managing Equipment List

    • -0
    • +207
    /src/equipments-edit/equipments-edit.controller.spec.js
    • -0
    • +39
    /src/equipments-edit/equipments-edit.html
    • -0
    • +38
    /src/equipments-edit/equipments-edit.module.js
    • -0
    • +71
    /src/equipments-edit/equipments-edit.routes.js
    • -0
    • +18
    /src/equipments-edit/messages_en.json
    • -0
    • +34
    /src/equipments-list/equipments-list.html
    • -0
    • +36
    /src/equipments-list/equipments-list.module.js
    • -0
    • +52
    /src/equipments-list/equipments-list.routes.js
    • -0
    • +12
    /src/equipments-list/messages_en.json
    • -0
    • +101
    /src/equipments/equipment-data-builder.spec.js
    • -0
    • +61
    /src/equipments/equipment.js
    • -0
    • +31
    /src/equipments/equipments.module.js
    • -0
    • +118
    /src/equipments/equipments.service.js
Create API for managing equipment list
Create API for managing equipment list
TZUP-234 Created API for managing equipment list

Signed-off-by: Boniface Chacha <bonifacechacha@gmail.com>

    • -0
    • +110
    /src/main/java/org/openlmis/equipment/domain/Equipment.java
    • -0
    • +85
    /src/main/java/org/openlmis/equipment/dto/EquipmentDto.java
    • -1
    • +135
    /src/main/resources/api-definition.yaml
    • -0
    • +5
    /src/main/resources/db/migration/20210830175857637__add_primary_key_contraints_for_model_and_energy_type.sql
  1. … 7 more files in changeset.
TZUP-212 implemented the UI for managing equipment energy types

TZUP-212 : Create UI for managing equipment energy types
TZUP-212 : Create UI for managing equipment energy types
TZUP-211 corrected tests

Signed-off-by: Boniface Chacha <bonifacechacha@gmail.com>

TZUP-212 implemented the UI for managing equipment energy types

TZUP-211 corrected tests

Signed-off-by: Boniface Chacha <bonifacechacha@gmail.com>

Okay, I understand. I will remove this one. In my view, I usually consider integration tests as not only for testing the integration of the different components with external systems but rather to ...

Okay, I understand. I will remove this one.
In my view, I usually consider integration tests as not only for testing the integration of the different components with external systems but rather to also tests the integrations of these components within the system. That is why I included tests for the integration of the Service and the Repository.

However, I also understand how you pointed out that the other tests will cover the intended purpose and adding this will just add more code to maintain.

I agree, I have remove the repetitive deleteAll.

I agree, I have remove the repetitive deleteAll.

TZUP-211 added test for NOT_FOUND GET 404

Signed-off-by: Boniface Chacha <bonifacechacha@gmail.com>

TZUP-211 added test for NOT_FOUND GET 404

Signed-off-by: Boniface Chacha <bonifacechacha@gmail.com>

TZUP-211 added test for NOT_FOUND GET 404

Signed-off-by: Boniface Chacha <bonifacechacha@gmail.com>

TZUP-211 removed non essential tests