Adugna Worku

Yes it fixes the problem. Angular's $filter('filter') searches a subset of string instead of the whole string. for $filter('filter') if our search string is 'Ju' , both ''Ju' 'June' will be return...

Yes it fixes the problem. Angular's $filter('filter') searches a subset of string instead of the whole string.

for $filter('filter') if our search string is 'Ju' , both ''Ju' 'June' will be returned

But with the latest update Array.prototype.filter, only 'Ju' will be returned. The former implementation was considering 'MANAGE_ORDERABLE' and other right having 'MANAGE_ORDERABLE' as a subset as a same right.

Grouping is not a one time thing. In physical inventory page, its possible to add new and remove existing line item after the page loaded. This requires grouping after adding and removing operation.

Grouping is not a one time thing. In physical inventory page, its possible to add new and remove existing line item after the page loaded. This requires grouping after adding and removing operation.

OLMIS-4403: Fix rights under role edit form to appropriatly show status
OLMIS-4403: Fix rights under role edit form to appropriatly show status
OLMIS-5438 Categorize orderables under correct product categories
OLMIS-5438 Categorize orderables under correct product categories
OLMIS-4968 - make packsToShip Rnr column to be visible on approval page or on all pages based on the new admin template option
OLMIS-4968 - make packsToShip Rnr column to be visible on approval page or on all pages based on the new admin template option
This work was already done some time ago, and got reverted by other recent changes, so I have to re-do it again. The change log that states this feature/change is already there. OLMIS-3288(https:...

This work was already done some time ago, and got reverted by other recent changes, so I have to re-do it again. The change log that states this feature/change is already there.

OLMIS-3288(https://openlmis.atlassian.net/browse/OLMIS-3288): Add option of fetching processing periods only by programId. Useful for report filters

update processingPeriods search to also fetch by programid. Useful for report filter the loads periods...
update processingPeriods search to also fetch by programid. Useful for report filter the loads periods...
Mateusz Kwiatkowski Based on the fix and comment I added before, is additional test required since character overflow feature it is already covered by other existing test?

Mateusz Kwiatkowski Based on the fix and comment I added before, is additional test required since character overflow feature it is already covered by other existing test?

We check the max length of the input on the view with ng-maxlength. Once the entered text length exceeds the max limit, the validator sets the model undefined. For valid input we have two possible ...

We check the max length of the input on the view with ng-maxlength. Once the entered text length exceeds the max limit, the validator sets the model undefined. For valid input we have two possible values - empty text or text with length less than the max limit.

So if the value gets set undefined, the validation has failed for ng-maxlength validator.

OLMIS-4719 : Fix requisition template validation when definition column excceeds max limit
OLMIS-4719 : Fix requisition template validation when definition column excceeds max limit
OLMIS-3982: Add facility validation for duplicate program supported
OLMIS-3982: Add facility validation for duplicate program supported
OLMIS-4815 fix Facility Assignment Configuration Errors report doesn't always update error
OLMIS-4815 fix Facility Assignment Configuration Errors report doesn't always update error
This is because the existing implementation for fetching processingPeriods (parameter validation) has been changed in relation with the ticket.

This is because the existing implementation for fetching processingPeriods (parameter validation) has been changed in relation with the ticket.

The new endpoint has been removed.

The new endpoint has been removed.

Thanks Mateusz. On the report filter, ProcessingPeriod needs to be loaded only by programId. But /api/processingPeriods GET endpoint requires both ProgramId and FacilityId. Do you think it is fine ...

Thanks Mateusz. On the report filter, ProcessingPeriod needs to be loaded only by programId. But /api/processingPeriods GET endpoint requires both ProgramId and FacilityId. Do you think it is fine to change the validation behavior of /api/processingPeriods" GET endpoint?

OLMIS-3288 - Expose rest endpoint for reports processing period filter
OLMIS-3288 - Expose rest endpoint for reports processing period filter