Adugna Worku

OLMIS-5886 : Add `Additional quantity required` column in Requisition print
OLMIS-5886 : Add `Additional quantity required` column in Requisition print
sure

sure

Yes, as the OP of the ticket (OLMIS-5866) mentioned on the description, a wrong UUID is accepted without throwing a validation exception. On current version of java, 'UUID.fromString' method accept...

Yes, as the OP of the ticket (OLMIS-5866) mentioned on the description, a wrong UUID is accepted without throwing a validation exception. On current version of java, 'UUID.fromString' method accepts UUIDs with a missing part and convert them to a valid format adding some weird values to them. Which is a bug and shall throw IllegalArgumentException. So to overcome this, we can compare the original String value we want to convert with the converted UUID value accepted by the method after converting it to String.

One of the reported bug - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8188902

Basically line number 110 and 113 throws the same king of exception. The reason the 'if' block is added, as i have mentioned on the above comment, UUID.fromString() have a gap in identifying a vali...

Basically line number 110 and 113 throws the same king of exception. The reason the 'if' block is added, as i have mentioned on the above comment, UUID.fromString() have a gap in identifying a valid UUIDs and its just a secondary check. So both section are expected to throw IllegalArgumentException if there is a wrong format. And finally this is caught by line 118 and we re-throw ValidationException in a single place, which is decorated with a proper message and values. If we are not going to code-duplicate line 119 to line 113.

OLMIS-5866: Improve UUID validation
OLMIS-5866: Improve UUID validation
OLMIS-5527 : Fix facility type list page pagination
OLMIS-5527 : Fix facility type list page pagination
OLMIS-5527 : Sort facility alphabetically by name on Administration/Facilities
OLMIS-5527 : Sort facility alphabetically by name on Administration/Facilities
Isn't this always true? rendering the subsequent lines to be a dead code?

Isn't this always true? rendering the subsequent lines to be a dead code?

Sure I will close it.

Sure I will close it.

OLMIS-4583: Added demo data for Valid Source in Stock Management for Balaka District Warehouse
OLMIS-4583: Added demo data for Valid Source in Stock Management for Balaka District Warehouse
OLMIS-5601: Display Products categorized within the Product Categories on the Physical Inventory
OLMIS-5601: Display Products categorized within the Product Categories on the Physical Inventory
OLMIS-4926 - update demo data README for missing rights and textual update
OLMIS-4926 - update demo data README for missing rights and textual update
https://github.com/OpenLMIS/openlmis-ui-components/commit/2733f775a75cb3bfa677316a6f26ccde731ff283 did that https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif
Yes. https://openlmis.atlassian.net/browse/OLMIS-3446

Yes. https://openlmis.atlassian.net/browse/OLMIS-3446

Make offline latency timeout configurable at build time
Make offline latency timeout configurable at build time