Adugna Worku

OLMIS-5866 : dded review comments from FEOLMIS-3594

OLMIS-5886 : Add `Additional quantity required` column in Requisition print
OLMIS-5886 : Add `Additional quantity required` column in Requisition print
OLMIS-5886 : show additional quatity required column on requsition print

sure

sure

Yes, as the OP of the ticket (OLMIS-5866) mentioned on the description, a wrong UUID is accepted without throwing a validation exception. On current version of java, 'UUID.fromString' method accept...

Yes, as the OP of the ticket (OLMIS-5866) mentioned on the description, a wrong UUID is accepted without throwing a validation exception. On current version of java, 'UUID.fromString' method accepts UUIDs with a missing part and convert them to a valid format adding some weird values to them. Which is a bug and shall throw IllegalArgumentException. So to overcome this, we can compare the original String value we want to convert with the converted UUID value accepted by the method after converting it to String.

One of the reported bug - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8188902

Basically line number 110 and 113 throws the same king of exception. The reason the 'if' block is added, as i have mentioned on the above comment, UUID.fromString() have a gap in identifying a vali...

Basically line number 110 and 113 throws the same king of exception. The reason the 'if' block is added, as i have mentioned on the above comment, UUID.fromString() have a gap in identifying a valid UUIDs and its just a secondary check. So both section are expected to throw IllegalArgumentException if there is a wrong format. And finally this is caught by line 118 and we re-throw ValidationException in a single place, which is decorated with a proper message and values. If we are not going to code-duplicate line 119 to line 113.

OLMIS-5866: Improve UUID validation
OLMIS-5866: Improve UUID validation
Fix sonar issue

OLMIS-5866: Improve UUID validation

OLMIS-5527: fix soanr issue

OLMIS-5527: sort facility list page

OLMIS-5527: fix failing test

OLMIS-5527: refactore facility ist admin page pagination and sorting

OLMIS-5527 : Fix facility type list page pagination
OLMIS-5527 : Fix facility type list page pagination
OLMIS-5527 : Sort facility alphabetically by name on Administration/Facilities
OLMIS-5527 : Sort facility alphabetically by name on Administration/Facilities
OLMIS-5527 : On facility list screen, sort facility by name

OLMIS-5204 : Fixed facility type list pagination

Isn't this always true? rendering the subsequent lines to be a dead code?

Isn't this always true? rendering the subsequent lines to be a dead code?

Sure I will close it.

Sure I will close it.