Adugna Worku

About
  • First commit 31 May 2018
  • Latest commit 13 February 2019
Last Week All Time
Commits: 2 50

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Adugna Worku is mapped to 11 committers over 11 repositories
Username adugna is mapped to:
Wednesday 13 Feb
2:58 pm

Adugna Worku

2:56 pm

Adugna Worku

8:13 am

Adugna Worku

6:53 am

Adugna Worku

OLMIS-5866 : dded review comments from FEOLMIS-3594

Options
    • -1
    • +6
    /src/main/java/org/openlmis/notification/web/SearchParams.java
5:59 am

Adugna Worku

Tuesday 12 Feb
3:15 pm

Adugna Worku

OLMIS-5886 : Add `Additional quantity required` column in Requisition print
OLMIS-5886 : Add `Additional quantity required` column in Requisition print
3:06 pm

Adugna Worku

OLMIS-5886 : show additional quatity required column on requsition print

Options
    • -0
    • +1
    /CHANGELOG.md
    • -37
    • +21
    /src/main/resources/jasperTemplates/requisition.jrxml
    • -7
    • +38
    /src/main/resources/jasperTemplates/requisitionLines.jrxml
Monday 11 Feb
1:07 pm

Adugna Worku

Wednesday 06 Feb
4:22 pm

Adugna Worku

sure

sure

Tuesday 05 Feb
3:29 pm

Adugna Worku

Yes, as the OP of the ticket (OLMIS-5866) mentioned on the description, a wrong UUID is accepted without throwing a validation exception. On current version of java, 'UUID.fromString' method accept...

Yes, as the OP of the ticket (OLMIS-5866) mentioned on the description, a wrong UUID is accepted without throwing a validation exception. On current version of java, 'UUID.fromString' method accepts UUIDs with a missing part and convert them to a valid format adding some weird values to them. Which is a bug and shall throw IllegalArgumentException. So to overcome this, we can compare the original String value we want to convert with the converted UUID value accepted by the method after converting it to String.

One of the reported bug - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8188902

3:27 pm

Adugna Worku

Basically line number 110 and 113 throws the same king of exception. The reason the 'if' block is added, as i have mentioned on the above comment, UUID.fromString() have a gap in identifying a vali...

Basically line number 110 and 113 throws the same king of exception. The reason the 'if' block is added, as i have mentioned on the above comment, UUID.fromString() have a gap in identifying a valid UUIDs and its just a secondary check. So both section are expected to throw IllegalArgumentException if there is a wrong format. And finally this is caught by line 118 and we re-throw ValidationException in a single place, which is decorated with a proper message and values. If we are not going to code-duplicate line 119 to line 113.

Sunday 03 Feb
10:41 am

Adugna Worku

OLMIS-5866: Improve UUID validation
OLMIS-5866: Improve UUID validation
10:21 am

Adugna Worku

Fix sonar issue

Options
    • -1
    • +1
    /src/main/java/org/openlmis/notification/web/SearchParams.java
9:53 am

Adugna Worku

OLMIS-5866: Improve UUID validation

Options
    • -0
    • +1
    /CHANGELOG.md
    • -1
    • +9
    /src/main/java/org/openlmis/notification/web/SearchParams.java
    • -0
    • +2
    /src/test/java/org/openlmis/notification/web/SearchParamsTest.java
Thursday 24 Jan
9:41 pm

Adugna Worku

Monday 21 Jan
11:42 am

Adugna Worku

OLMIS-5527: fix soanr issue

Options
    • -4
    • +27
    /src/integration-test/java/org/openlmis/referencedata/repository/FacilityRepositoryIntegrationTest.java
    • -2
    • +2
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/FacilityRepositoryImpl.java
Friday 18 Jan
4:22 pm

Adugna Worku

OLMIS-5527: sort facility list page

Options
    • -1
    • +2
    /src/admin-facility-list/admin-facility-list.routes.js
    • -2
    • +3
    /src/admin-facility-list/admin-facility-list.routes.spec.js
4:19 pm

Adugna Worku

OLMIS-5527: fix failing test

Options
    • -6
    • +21
    /src/integration-test/java/org/openlmis/referencedata/web/FacilityControllerIntegrationTest.java
    • -1
    • +2
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/FacilityRepositoryImpl.java
    • -2
    • +6
    /src/main/java/org/openlmis/referencedata/service/FacilityService.java
    • -1
    • +1
    /src/main/java/org/openlmis/referencedata/web/FacilityController.java
11:21 am

Adugna Worku

OLMIS-5527: refactore facility ist admin page pagination and sorting

Options
    • -11
    • +17
    /src/integration-test/java/org/openlmis/referencedata/repository/FacilityRepositoryIntegrationTest.java
    • -7
    • +11
    /src/integration-test/java/org/openlmis/referencedata/web/FacilityControllerIntegrationTest.java
    • -1
    • +1
    /src/main/java/org/openlmis/referencedata/repository/FacilityRepository.java
    • -3
    • +5
    /src/main/java/org/openlmis/referencedata/repository/custom/FacilityRepositoryCustom.java
    • -6
    • +53
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/FacilityRepositoryImpl.java
    • -11
    • +18
    /src/main/java/org/openlmis/referencedata/service/FacilityService.java
    • -3
    • +6
    /src/main/java/org/openlmis/referencedata/web/FacilityController.java
    • -23
    • +38
    /src/test/java/org/openlmis/referencedata/service/FacilityServiceTest.java
Wednesday 16 Jan
11:01 am

Adugna Worku

Tuesday 15 Jan
10:45 pm

Adugna Worku

OLMIS-5527 : Fix facility type list page pagination
OLMIS-5527 : Fix facility type list page pagination
10:41 pm

Adugna Worku

OLMIS-5527 : Sort facility alphabetically by name on Administration/Facilities
OLMIS-5527 : Sort facility alphabetically by name on Administration/Facilities
10:14 pm

Adugna Worku

OLMIS-5527 : On facility list screen, sort facility by name

Options
    • -0
    • +6
    /CHANGELOG.md
    • -0
    • +16
    /src/integration-test/java/org/openlmis/referencedata/repository/FacilityRepositoryIntegrationTest.java
    • -0
    • +2
    /src/main/java/org/openlmis/referencedata/repository/FacilityRepository.java
    • -5
    • +5
    /src/main/java/org/openlmis/referencedata/repository/custom/impl/FacilityRepositoryImpl.java
    • -1
    • +1
    /src/main/java/org/openlmis/referencedata/service/FacilityService.java
    • -5
    • +5
    /src/test/java/org/openlmis/referencedata/service/FacilityServiceTest.java
9:51 pm

Adugna Worku

OLMIS-5204 : Fixed facility type list pagination

Options
    • -0
    • +1
    /CHANGELOG.md
    • -4
    • +4
    /src/admin-facility-type-list/admin-facility-type-list.routes.js
9:56 am

Adugna Worku

Isn't this always true? rendering the subsequent lines to be a dead code?

Isn't this always true? rendering the subsequent lines to be a dead code?

Monday 24 Dec 2018
5:33 am

Adugna Worku

5:33 am

Adugna Worku

Sure I will close it.

Sure I will close it.

Thursday 29 Nov 2018
12:49 pm

Adugna Worku

Monday 05 Nov 2018
10:20 am

Adugna Worku

10:18 am

Adugna Worku