Adugna Worku

This work was already done some time ago, and got reverted by other recent changes, so I have to re-do it again. The change log that states this feature/change is already there. OLMIS-3288(https:...

This work was already done some time ago, and got reverted by other recent changes, so I have to re-do it again. The change log that states this feature/change is already there.

OLMIS-3288(https://openlmis.atlassian.net/browse/OLMIS-3288): Add option of fetching processing periods only by programId. Useful for report filters

update processingPeriods search to also fetch by programid. Useful for report filter the loads periods...
update processingPeriods search to also fetch by programid. Useful for report filter the loads periods...
update processingPeriods search to fetch only by programid. Useful for report filter the loads periods by program only

Fix sonar issue

Fix facility performance test

Mateusz Kwiatkowski Based on the fix and comment I added before, is additional test required since character overflow feature it is already covered by other existing test?

Mateusz Kwiatkowski Based on the fix and comment I added before, is additional test required since character overflow feature it is already covered by other existing test?

We check the max length of the input on the view with ng-maxlength. Once the entered text length exceeds the max limit, the validator sets the model undefined. For valid input we have two possible ...

We check the max length of the input on the view with ng-maxlength. Once the entered text length exceeds the max limit, the validator sets the model undefined. For valid input we have two possible values - empty text or text with length less than the max limit.

So if the value gets set undefined, the validation has failed for ng-maxlength validator.

fix appropriate varialbe naming

refactor facility supported program validation

Fix sonar error

OLMIS-4719 : Fix requisition template validation when definition column excceeds max limit
OLMIS-4719 : Fix requisition template validation when definition column excceeds max limit
Change double quote

OLMIS-4719 : Fix requisition template validation when definition column excceeds max limit

OLMIS-3982: Add facility validation for duplicate program supported
OLMIS-3982: Add facility validation for duplicate program supported
OLMIS-3982: Add facility validation for duplicate program supported

OLMIS-3289 : Fixed Null values in the Facility Assignment Report columns

    • -0
    • +2
    /src/main/resources/db/migration/20180625071455026__update_facility_assignment_config_report_remove_null_columns.sql
OLMIS-4815 fix Facility Assignment Configuration Errors report doesn't always update error
OLMIS-4815 fix Facility Assignment Configuration Errors report doesn't always update error
This is because the existing implementation for fetching processingPeriods (parameter validation) has been changed in relation with the ticket.

This is because the existing implementation for fetching processingPeriods (parameter validation) has been changed in relation with the ticket.

The new endpoint has been removed.

The new endpoint has been removed.

OLMIS-3288 : remove obsolete message key reference

OLMIS-3288 : Update timeliness report dependecy demo data

    • -1
    • +1
    /demo-data/requisition.jasper_template_parameter_dependencies.json
    • -1
    • +1
    /demo-data/requisition.template_parameters.json
OLMIS-3288 : Fix report filters dependecy placeholder name to be flexibly named based on data from db

    • -1
    • +1
    /src/report/report-generate.controller.js
OLMIS-3288 : Make processingPeriod optionally search with only ProgramId

OLMIS-4815 fix Facility Assignment Configuration Errors report doesn't always update error

    • -0
    • +3
    /src/main/resources/db/migration/20180615115930788__update_facility_assignment_configuration_report.sql
Remove rest endpoint to use default processing period GET rest end point

Thanks Mateusz. On the report filter, ProcessingPeriod needs to be loaded only by programId. But /api/processingPeriods GET endpoint requires both ProgramId and FacilityId. Do you think it is fine ...

Thanks Mateusz. On the report filter, ProcessingPeriod needs to be loaded only by programId. But /api/processingPeriods GET endpoint requires both ProgramId and FacilityId. Do you think it is fine to change the validation behavior of /api/processingPeriods" GET endpoint?