Adugna Worku

I would prefer the original way

Nikodem Graczewski There is something tricky here.

Array.prototype.flatMap() works on chrome version >=69

Unfortunately my virtual machine Chrome version is 66. And flatMap is not supported. That was the reason i was saying its not working.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap

So changing to flatMap won't that create a problem?

This doesn't return object in a desired format. I will stick with the existing implementation

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

The message is correct but the key can't be changed this time, since Issue, Receive and Upack share similar keys for the message since they use the same html template

ditto

Issue, receive and unpack pages uses a single html view but separate message files. The prefix of the message key is up-to the page that will be rendered but the suffix is already hard coded in the html file.

So in this case the message value is appropriate but the key is not. changing the key required all the message to be changed in the other modules also. So this implementation shall be refactored for the future but till then the html file is our guide.

Take a look at stock-adjustment/stock-adjustment.html

Sure

This piece of code will return a random reason

No. when the unpack reason view loaded, take a look at unpack-kit-creation.routes.js line 78. Method returns ONLY two reasons of type AGGREGATION. They are -
1. Kit Unpack (DEBIT)
2. Unpacked From Kit (CREDIT).

So we will use Unpacked From Kit (CREDIT) reason for the constituent line item

I didn't understood well what you mean by "Facility Return" but we need the CREDIT type reason here. During unpacking, the Kit will be DEBITED from SOH and Kit constituents SOH amount will be CREDITED. Kit line item comes from the UI and constituent line item will be generated here with reason type CREDIT.

I am not sure how we can use it here.

But her we want to generate new Array objects by accessing a second level depth array of other object with our reducing anything.

You can advise me on this.

adjustment-creation.controller is shared by - Issue, Receive and Unpack pages. the current method will be executed when the operation is kit unpacking.

N.B During unpacking, the user just add the kit as a line item on the view (table) and since we know the corresponding constituents we generate them behind the scene among with a proper unpacked quantity for each constituent when we finally submit the data.

vm.addedLineItem is an object Which is bound with the table in the view. If the data transformation, generating kit constituents, is done on this object unnecessary and confusing change will be displayed in the view.