Already implemented as instructed here on commit OLMIS-5959: Enable facility type button and set facility type input required (https://github.com/OpenLMIS/openlmis-requisition-ui/commit/1446f6a3209...

Already implemented as instructed here on commit OLMIS-5959: Enable facility type button and set facility type input required (https://github.com/OpenLMIS/openlmis-requisition-ui/commit/1446f6a3209ba7245e04f5adc85d4d4258917b52)

Hello, should i close this review?

Hello, should i close this review?

Noted

Noted

That was wrong, i have already resolved it

That was wrong, i have already resolved it

OLMIS-5945:Fix updating adjustment reason failure
OLMIS-5945:Fix updating adjustment reason failure
Hello Nikodem Graczewski, no problem

Hello Nikodem Graczewski, no problem

Okay, will do so

Okay, will do so

Should I revert back to required?

Should I revert back to required?

Fixed this

Fixed this

Fixed this

Fixed this

Fixed this

Fixed this

I have corrected this test, now am checking "should not clear orderables if there is still a facility associated"

I have corrected this test, now am checking "should not clear orderables if there is still a facility associated"

Agree with you but there was another ticket which says facility type is not mandatory (https://openlmis.atlassian.net/browse/OLMIS-5848)

Agree with you but there was another ticket which says facility type is not mandatory (https://openlmis.atlassian.net/browse/OLMIS-5848)

Noted, thank you

Noted, thank you

Added on this commit (OLMIS-5959:Disable facility type add button until facility type is selected), also changed the logic instead of making facility type required i just disable add button because...

Added on this commit (OLMIS-5959:Disable facility type add button until facility type is selected), also changed the logic instead of making facility type required i just disable add button because facility type is not supposed to be mandatory

OLMIS-5959: Make facility type input required on add template form
OLMIS-5959: Make facility type input required on add template form
I have removed old test and add new one on this commit OLMIS-5915:Update unit test to not clear the product fields if there is still a facility associated

I have removed old test and add new one on this commit OLMIS-5915:Update unit test to not clear the product fields if there is still a facility associated

OLMIS-5915:Fixed products disappear after removing one of the Facility on the Add/Edit Association...
OLMIS-5915:Fixed products disappear after removing one of the Facility on the Add/Edit Association...
OLMIS-5848: Fixed a bug with facility type marked as required when creating a requisition templat
OLMIS-5848: Fixed a bug with facility type marked as required when creating a requisition templat