Made ftp file transfer and email sending configurable on requisition to order
Made ftp file transfer and email sending configurable on requisition to order
OLMIS-7181: Made Stock Card Summaries cache user-specific
OLMIS-7181: Made Stock Card Summaries cache user-specific
Also, if you need to do things like change ConfigurationSettings to ConfigurationSetting, it would be ideal to have that as a separate review. It's challenging to review multiple things in the same...

Also, if you need to do things like change ConfigurationSettings to ConfigurationSetting, it would be ideal to have that as a separate review. It's challenging to review multiple things in the same review.

We should not be modifying migrations, especially if the code has already been versioned and released. That will break existing implementations. If we need to change schema stuff, we need to create...

We should not be modifying migrations, especially if the code has already been versioned and released. That will break existing implementations. If we need to change schema stuff, we need to create a new migration.

move csv generation logic to a service

Oh, I see https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

Oh, I see

use requisition line item dto to get product data

Updated

Updated

I have managed to extract some parts of code

I have managed to extract some parts of code

Yes, but pending-offline-events.service.decorator should use getUserEventsFromStorage because we don't need there all the information that the getOfflineEvents returns

Yes, but pending-offline-events.service.decorator should use getUserEventsFromStorage because we don't need there all the information that the getOfflineEvents returns

Hmm.. but from what I see, in the pending-offline-events.service.decorator we use only the getOfflineEvents function

Hmm.. but from what I see, in the pending-offline-events.service.decorator we use only the getOfflineEvents function

Do you think you can extract something from the functions getOfflineEvents or combineResponses to make them a little smaller?

Do you think you can extract something from the functions getOfflineEvents or combineResponses to make them a little smaller?

The description of this function and the getUserEventsFromStorage are the same. However, this function returns more information

The description of this function and the getUserEventsFromStorage are the same. However, this function returns more information

This function is only used by getOfflineEvents but should also be used by pending-offline-events.service.decorator

This function is only used by getOfflineEvents but should also be used by pending-offline-events.service.decorator

I was renaming column titles to match elmis and added a new column called 'price'

I was renaming column titles to match elmis and added a new column called 'price'

Can you explain why some existing SQL migrations have been removed/modified?

Can you explain why some existing SQL migrations have been removed/modified?