OpenLMIS

OpenLMIS

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 7
Total Commits: 3,863
Last Commit: 01 Jan 70
Commits this week: 7

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 25 Mar
9:39 pm

Chongsun Ahn

I'm getting similar issues as Jasmine 1.x when making proposed changes. I don't think this is the right way to go, so I'm going to close this review.

I'm getting similar issues as Jasmine 1.x when making proposed changes. I don't think this is the right way to go, so I'm going to close this review.

6:53 pm

Sebastian Brudziński

4:13 pm

Ian

3:26 pm

Klaudia Pałkowska

Merged into one.

Merged into one.

3:25 pm

Klaudia Pałkowska

Removed.

Removed.

3:24 pm

Nikodem Graczewski and Paulina Mironiuk

3:23 pm

Klaudia Pałkowska and Nikodem Graczewski

3:14 pm

Nikodem Graczewski

Will do https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

Will do

3:07 pm

Paulina Mironiuk

What do you think about the new name?

What do you think about the new name?

3:02 pm

Chongsun Ahn

That will be done, but will be in a separate review.

That will be done, but will be in a separate review.

1:55 pm

Klaudia Pałkowska and Paulina Mironiuk

1:53 pm

Nikodem Graczewski

Could we change the name to more descriptive?

Could we change the name to more descriptive?

1:52 pm

Nikodem Graczewski

1:48 pm

Nikodem Graczewski

Remove this inline-style.

Remove this inline-style.

1:46 pm

Nikodem Graczewski

Only one button should be marked as primary for a specific screen.

Only one button should be marked as primary for a specific screen.

1:44 pm

Nikodem Graczewski

User Array.prototype.map instead.

User Array.prototype.map instead.

1:44 pm

Nikodem Graczewski

User Array.prototype.map instead.

User Array.prototype.map instead.

1:42 pm

Nikodem Graczewski

This isn't consistent with the rest of the table forms. Please rework this to use 'openlmis-invalid' directive inside the table. Also, wrap the table element in form and update the "Save Kit Unpack...

This isn't consistent with the rest of the table forms. Please rework this to use 'openlmis-invalid' directive inside the table. Also, wrap the table element in form and update the "Save Kit Unpack List" to be a submit button of the said form.

1:37 pm

Nikodem Graczewski

1:32 pm

Nikodem Graczewski

Why using the apply here?

Why using the apply here?

1:30 pm

Nikodem Graczewski

Please user FunctionDecorator.

Please user FunctionDecorator.

1:29 pm

Nikodem Graczewski

Change the key so it matches the message.

Change the key so it matches the message.

1:26 pm

Nikodem Graczewski

Change key to "adminProductView.kitUnpackList".

Change key to "adminProductView.kitUnpackList".

1:25 pm

Nikodem Graczewski

Change key to "adminProductView.createKitUnpackList".

Change key to "adminProductView.createKitUnpackList".

1:25 pm

Nikodem Graczewski

According to our style guide, it should say what we are saving.

According to our style guide, it should say what we are saving.

1:22 pm

Nikodem Graczewski

Please, use OrderableResource instead.

Please, use OrderableResource instead.

1:21 pm

Nikodem Graczewski

It can simply be "ids.length".

It can simply be "ids.length".

1:20 pm

Nikodem Graczewski

Please add unit tests for this file.

Please add unit tests for this file.

1:20 pm

Nikodem Graczewski

Please, use Array.prototype.map instead.

Please, use Array.prototype.map instead.

1:19 pm

Nikodem Graczewski

What is the "c"? Could we give it a more meaningful name?

What is the "c"? Could we give it a more meaningful name?