OpenLMIS

OpenLMIS

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 6
Total Commits: 4,132
Last Commit: 01 Jan 70
Commits this week: 6

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Today
3 hrs ago

Elly Makuba

Made ftp file transfer and email sending configurable on requisition to order
Made ftp file transfer and email sending configurable on requisition to order
3 hrs ago

Elly Makuba

Friday 05 Mar
10:49 am

Klaudia Pałkowska

10:25 am

Paulina Buzderewicz

OLMIS-7181: Made Stock Card Summaries cache user-specific
OLMIS-7181: Made Stock Card Summaries cache user-specific
Thursday 04 Mar
4:42 am

Ian

Wednesday 03 Mar
6:32 pm

Elly Makuba

6:31 pm

Chongsun Ahn

Also, if you need to do things like change ConfigurationSettings to ConfigurationSetting, it would be ideal to have that as a separate review. It's challenging to review multiple things in the same...

Also, if you need to do things like change ConfigurationSettings to ConfigurationSetting, it would be ideal to have that as a separate review. It's challenging to review multiple things in the same review.

6:28 pm

Chongsun Ahn

We should not be modifying migrations, especially if the code has already been versioned and released. That will break existing implementations. If we need to change schema stuff, we need to create...

We should not be modifying migrations, especially if the code has already been versioned and released. That will break existing implementations. If we need to change schema stuff, we need to create a new migration.

12:34 pm

Klaudia Pałkowska

10:20 am

Aleksandra Sołtys

9:48 am

erickmbwana@gmail.com

move csv generation logic to a service

Options
    • -0
    • +84
    /src/main/java/org/openlmis/requisition/service/QuantificationExtractService.java
    • -60
    • +4
    /src/main/java/org/openlmis/requisition/web/QuantificationExtractController.java
9:39 am

Paulina Buzderewicz

Oh, I see https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

Oh, I see

9:36 am

erickmbwana@gmail.com

use requisition line item dto to get product data

Options
    • -10
    • +11
    /src/main/java/org/openlmis/requisition/web/QuantificationExtractController.java
9:03 am

Paulina Buzderewicz

Updated

Updated

9:02 am

Paulina Buzderewicz

I have managed to extract some parts of code

I have managed to extract some parts of code

9:01 am

Paulina Buzderewicz

8:57 am

Aleksandra Sołtys

8:56 am

Aleksandra Sołtys

8:55 am

Aleksandra Sołtys

8:23 am

Aleksandra Sołtys

Yes, but pending-offline-events.service.decorator should use getUserEventsFromStorage because we don't need there all the information that the getOfflineEvents returns

Yes, but pending-offline-events.service.decorator should use getUserEventsFromStorage because we don't need there all the information that the getOfflineEvents returns

8:05 am

Paulina Buzderewicz

Hmm.. but from what I see, in the pending-offline-events.service.decorator we use only the getOfflineEvents function

Hmm.. but from what I see, in the pending-offline-events.service.decorator we use only the getOfflineEvents function

7:48 am

Aleksandra Sołtys

Do you think you can extract something from the functions getOfflineEvents or combineResponses to make them a little smaller?

Do you think you can extract something from the functions getOfflineEvents or combineResponses to make them a little smaller?

7:45 am

Elly Makuba

7:18 am

Aleksandra Sołtys

The description of this function and the getUserEventsFromStorage are the same. However, this function returns more information

The description of this function and the getUserEventsFromStorage are the same. However, this function returns more information

7:16 am

Aleksandra Sołtys

This function is only used by getOfflineEvents but should also be used by pending-offline-events.service.decorator

This function is only used by getOfflineEvents but should also be used by pending-offline-events.service.decorator

6:17 am

Elly Makuba

I was renaming column titles to match elmis and added a new column called 'price'

I was renaming column titles to match elmis and added a new column called 'price'

Tuesday 02 Mar
5:28 pm

Chongsun Ahn

5:28 pm

Chongsun Ahn

Can you explain why some existing SQL migrations have been removed/modified?

Can you explain why some existing SQL migrations have been removed/modified?

5:24 pm

Chongsun Ahn

5:22 pm

Chongsun Ahn