I'd say check the "blame" button but then it says it was Chongsun... I know I added this block before the service was re-named. What was I thinking!? Ugh the textual hate I can convey in this text area widget!!!!
Couple questions: 1. if I'm using it correctly, I can't seem to trigger the errors through `gradle check`, `gradle pmdMain` or `gradle pmdIntegrationTest`. That is, I added duplicate imports and unused private fields and no errors popped up in `build/reports/pmd/` 2. does Klaudia now have access to Crucible?
Looking great, couple questions: 1. should we incorporate nginx into the typical developer experience (here being developing one service), instead of a separate compose step? 2. We should probably add this to the service-template
Also FYI I forked/cloned this one to openlmis on github just so we have the code and know the license. We should likely establish this as a best practice.
How does a non-OpenLMIS developer use this to build the service? It seems like we've made a presumption that a user will have credentials to get the translations since there is one combined process: push messages and pull new translations. I would think that to be good open source citizens, we'd need to support anyone building one of our services, regardless if they have Transifex credentials. To do this I think we'd need to:
state that our policy for all services is that the translations for all services (governed by us) are of an appropriate license and are publicly downloadable by anyone
the default/convention in the build process, should it not have credentials to transifex, is to only attempt the download of the latest translations
This is what I was thinking of when I asked if we could "integrate" it into the dev environment. It could be useful here as it's closer to production - security will also likely be done here (nginx) and might be applicable in development in a service. Let me know if this works for you and if you think it'd be a hindrance or a help. Thanks.
Unfortunately it appears that the Transifex client does not allow interacting with the Transifex server (including pulling of resources) without authentication credentials. So, how will others be able to access these resources?
Does transifex need to occur for Sonar to provide an analysis? It seems like we might be able to reduce some of the configuration if we didn't need to notify transfiex. Then we could add to the docker-compose.builder.yml instructions for interacting with our sonarqube server.
Hi Jakub Kondrat, it works here but we're using Docker 1.12. In the PR, I changed the docker compose so that the nginx proxy was linked to the service. This creates a (fake) dependency which will bring up nginx, like it does postgres, when you run docker-compose run --service-ports requisition.
Hi Josh. As discussed, I know we'll need to remove hardcoded URLs. I also plan on adding this to the "openlmis-example" repository, as you mentioned. Assuming we like it, it would be great to advertise the approach to testing illustrated by UserIntegrationTest.java. It gets more done that the other tests in org.openlmis.referencedata.web, and seems a little less verbose.