Add Audit Logging to Template-Service

Activity

FEOLMIS-987 12

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 28m 8 Hi Chongsun - thank you again for your great feedback. I’...
    Reviewer - Complete 11m 4 Looks good, thanks.
    Total   39m 12  
    #permalink

    Objectives

    The goal of this review is to make sure that auditing logging has been added to the Template Service in a reasonable way, and that its style guide has been updated accordingly.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    A couple of stuff to resolve; otherwise looks good.

    A couple of stuff to resolve; otherwise looks good.

    Ben Leibert

    Hi Chongsun - thank you again for your great feedback. I’ve addressed it with...

    Hi Chongsun - thank you again for your great feedback. I’ve addressed it within WidgetController and STYLE-GUIDE.md, and hope you can please review the result. At Brandon’s suggestion, I’ve also attached “For_the_Dev_Forum.docx,” which I hope you can please review. If everything looks good to you, I think we’ll be able to close OLMIS-1605. Thanks again!

    Chongsun Ahn

    Looks good, thanks.

    Looks good, thanks.

    /For_the_Dev_Forum.docx Added
    Open in IDE #permalink
    /src/main/java/.../template/domain/Widget.java Changed
    /src/main/.../repository/WidgetRepository.java Changed
    /src/main/.../security/UserNameProvider.java Added
    /src/main/.../template/util/Pagination.java Added 1
    Open in IDE #permalink
    /src/main/.../template/web/BaseController.java Added 1
    Open in IDE #permalink
    /src/main/.../web/WidgetController.java Changed 2
    /src/main/.../template/Application.java Changed
    /src/.../template/AuditLogInitializer.java Added 1
    Open in IDE #permalink
    /src/main/.../schemas/auditLogEntry.json Added 1
    Open in IDE #permalink
    /src/main/resources/api-definition.yaml Changed 1
    /STYLE-GUIDE.md Changed 2
    /build.gradle Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against