OLMIS-969 Start a shared library for Services

Activity

FEOLMIS-828 3

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 23m 1 TODO: Move rest of the shared code to openlmis-service-util
    Reviewer - Complete 10m 2 LGTM - we can move the code as we go
    Total   33m 3  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Jakub Kondrat

    TODO: Move rest of the shared code to openlmis-service-util

    TODO: Move rest of the shared code to openlmis-service-util

    Paweł Gesek

    LGTM - we can move the code as we go

    LGTM - we can move the code as we go

    /src/.../web/UserControllerIntegrationTest.java Changed
    /src/main/.../util/PasswordResetRequest.java Deleted
    Open in IDE #permalink
    /src/main/java/.../auth/util/Version.java Deleted
    Open in IDE #permalink
    /src/main/.../auth/web/UserController.java Changed
    /src/main/.../auth/web/VersionController.java Changed
    /build.gradle Changed
    /src/main/java/.../example/util/Version.java Deleted
    Open in IDE #permalink
    /src/main/.../web/VersionController.java Changed
    /build.gradle Changed
    /src/main/.../domain/BaseEntity.java Changed
    /src/main/.../fulfillment/domain/View.java Deleted
    Open in IDE #permalink
    /build.gradle Changed
    /src/.../web/NotificationControllerIntegrationTest.java Changed
    /src/main/.../util/ErrorResponse.java Deleted
    Open in IDE #permalink
    /src/main/.../util/NotificationRequest.java Deleted
    Open in IDE #permalink
    /src/main/.../notification/util/Version.java Deleted
    Open in IDE #permalink
    /src/main/.../web/NotificationController.java Changed
    /src/main/.../web/VersionController.java Changed
    /build.gradle Changed
    /src/.../web/UserControllerIntegrationTest.java Changed
    /src/main/.../referencedata/domain/User.java Changed
    /src/.../errorhandling/RefDataErrorHandling.java Changed
    /src/main/.../service/UserService.java Changed
    /src/main/.../util/ErrorResponse.java Deleted
    Open in IDE #permalink
    /src/main/.../util/NotificationRequest.java Deleted
    Open in IDE #permalink
    /src/main/.../util/PasswordChangeRequest.java Deleted
    Open in IDE #permalink
    /src/main/.../util/PasswordResetRequest.java Deleted
    Open in IDE #permalink
    /src/main/.../referencedata/util/Version.java Deleted
    Open in IDE #permalink
    /src/main/.../referencedata/util/View.java Deleted
    Open in IDE #permalink
    /src/main/.../web/BaseController.java Changed
    /src/main/.../web/FacilityController.java Changed
    /src/main/.../web/FacilityTypeController.java Changed
    /src/.../web/ProcessingScheduleController.java Changed
    /src/.../web/ProductCategoryController.java Changed
    /src/main/.../web/RightController.java Changed
    /src/main/.../web/UserController.java Changed
    /src/main/.../web/VersionController.java Changed
    /src/test/.../service/UserServiceTest.java Changed
    /build.gradle Changed
    /src/.../errorhandling/AbstractErrorHandling.java Changed
    Open in IDE #permalink
    /src/.../errorhandling/AbstractErrorHandling.java Changed
    /src/.../errorhandling/GlobalErrorHandling.java Changed
    Open in IDE #permalink
    /src/.../errorhandling/GlobalErrorHandling.java Changed
    /src/main/.../domain/BaseEntity.java Changed
    /src/.../domain/BaseTimestampedEntity.java Changed
    /src/main/.../requisition/domain/Comment.java Changed
    /src/.../errorhandling/RequisitionErrorHandling.java Changed
    Open in IDE #permalink
    /src/.../errorhandling/RequisitionErrorHandling.java Changed
    /src/main/.../service/NotificationRequest.java Deleted
    Open in IDE #permalink
    /src/main/.../service/NotificationService.java Changed
    /src/main/.../web/RequisitionController.java Changed
    /src/main/.../web/VersionController.java Changed
    /src/main/.../utils/ErrorResponse.java Deleted
    Open in IDE #permalink
    /src/main/java/.../openlmis/utils/Version.java Deleted
    Open in IDE #permalink
    /src/main/java/org/openlmis/view/View.java Deleted
    Open in IDE #permalink
    /src/.../service/NotificationServiceTest.java Changed
    /src/.../web/RequisitionControllerTest.java Changed
    /build.gradle Changed
    /.signing/.gitignore Added
    Open in IDE #permalink
    /src/main/.../openlmis/util/ErrorResponse.java Added
    Open in IDE #permalink
    /src/main/.../util/NotificationRequest.java Added
    Open in IDE #permalink
    /src/main/.../util/PasswordChangeRequest.java Added
    Open in IDE #permalink
    /src/main/.../util/PasswordResetRequest.java Added
    Open in IDE #permalink
    /src/main/java/.../openlmis/util/Version.java Added
    Open in IDE #permalink
    /src/main/java/org/openlmis/util/View.java Added
    Open in IDE #permalink
    /src/main/.../utils/ErrorResponse.java Deleted
    Open in IDE #permalink
    /src/main/resources/version.properties Added
    Open in IDE #permalink
    /.gitignore Added
    Open in IDE #permalink
    /README.md Added 1
    Open in IDE #permalink
    /build.gradle Added
    /build.sh Added
    Open in IDE #permalink
    /docker-compose.yml Added
    Open in IDE #permalink
    /gradle.properties Added
    Open in IDE #permalink
    /settings.gradle Added
    Open in IDE #permalink
    /src/main/java/.../template/util/Version.java Deleted
    Open in IDE #permalink
    /src/main/.../web/VersionController.java Changed
    /build.gradle Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against