TZUP-207 Role Assignments

Activity

FEOLMIS-4414 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 54m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 8m 4 Role assignments should have a Convert ID at the beginnin...
    Total   2h 2m 4  
    #permalink

    Objectives

    TZUP-207 Role Assignments

    • How to store delivery zone from v2 to v3
    • Default value for column type in v3 role_assignment table

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Chongsun Ahn

    Fulfillment role assignments should not be added to its own table, but rather...

    Fulfillment role assignments should not be added to its own table, but rather the role_assignments table in the v3 database. The system does not use permissions in a new fulfillment_role_assignments table.

    Chongsun Ahn

    The fulfillment role assignments transform does not look right. It should loo...

    The fulfillment role assignments transform does not look right. It should look very similar to the role assignments transform, but instead of mapping program id and supervisory node id, it maps facility/warehouse id. So it should not be using SQL to update, but rather should be going through the same transform process:

    • Consume from Kafka
    • Convert ID
    • Check for delete
    • Map roles
    • Map users
    • Map facilities/warehouses
    • Replace schemas
    • Remove extended attributes and set defaults
    • Publish to Kafka
    • Save to cache

    Chongsun Ahn

    Role assignments should have a Convert ID at the beginning, before checking f...

    Role assignments should have a Convert ID at the beginning, before checking for delete. The reason for this is that you may be updating an existing role assignment, and you want to use the same UUID instead of generating a new one every time.

    /config/.../templates/TransformFulfillmentRoleAssignmentsV2ToV3.xml Added
    /config/.../templates/TransformRoleAssignmentsV2ToV3.xml Added
    /connect-reg/connectors/register-v2-source.json Changed 1
    /connect-reg/connectors/register-v3-sink.json Changed
    /connect-reg/connectors/register-v3-sink.json Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time